Re: [PATCH 05/10] Reduce per table entry overhead by 4 bytes

view
thread

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Nitin Gupta

Subject: Re: [PATCH 05/10] Reduce per table entry overhead by 4 bytes

Date: Monday, August 9, 2010 - 9:55 pm

On 08/10/2010 12:29 AM, Pekka Enberg wrote:
quoted text> On Mon, Aug 9, 2010 at 8:26 PM, Nitin Gupta <ngupta@vflare.org> wrote:
>> Each zram device maintains an array (table) that maps
>> index within the device to the location of corresponding
>> compressed chunk. Currently we store 'struct page' pointer,
>> offset with page and various flags separately which takes
>> 12 bytes per table entry. Now all these are encoded in a
>> single 'phys_add_t' value which results in savings of 4 bytes
>> per entry (except on PAE systems).
>>
>> Unfortunately, cleanups related to some variable renames
>> were mixed in this patch. So, please bear some additional
>> noise.
> 
> The noise makes this patch pretty difficult to review properly. Care
> to spilt the patch into two pieces?
> 

Ok, I will split them as separate patches.

Thanks for all the reviews and Acks.
Nitin

--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 00/10] zram: various improvements and cleanups, Nitin Gupta, (Mon Aug 9, 10:26 am)

[PATCH 01/10] Replace ioctls with sysfs interface, Nitin Gupta, (Mon Aug 9, 10:26 am)

[PATCH 02/10] Remove need for explicit device initialization, Nitin Gupta, (Mon Aug 9, 10:26 am)

[PATCH 03/10] Use percpu stats, Nitin Gupta, (Mon Aug 9, 10:26 am)

[PATCH 04/10] Use percpu buffers, Nitin Gupta, (Mon Aug 9, 10:26 am)

[PATCH 05/10] Reduce per table entry overhead by 4 bytes, Nitin Gupta, (Mon Aug 9, 10:26 am)

[PATCH 06/10] Block discard support, Nitin Gupta, (Mon Aug 9, 10:26 am)

[PATCH 07/10] Increase compressed page size threshold, Nitin Gupta, (Mon Aug 9, 10:26 am)

[PATCH 08/10] Some cleanups, Nitin Gupta, (Mon Aug 9, 10:26 am)

[PATCH 09/10] Update zram documentation, Nitin Gupta, (Mon Aug 9, 10:26 am)

[PATCH 10/10] Document sysfs entries, Nitin Gupta, (Mon Aug 9, 10:26 am)

Re: [PATCH 07/10] Increase compressed page size threshold, Pekka Enberg, (Mon Aug 9, 11:32 am)

Re: [PATCH 01/10] Replace ioctls with sysfs interface, Pekka Enberg, (Mon Aug 9, 11:34 am)

Re: [PATCH 02/10] Remove need for explicit device initiali ..., Pekka Enberg, (Mon Aug 9, 11:36 am)

Re: [PATCH 03/10] Use percpu stats, Pekka Enberg, (Mon Aug 9, 11:44 am)

Re: [PATCH 04/10] Use percpu buffers, Pekka Enberg, (Mon Aug 9, 11:57 am)

Re: [PATCH 05/10] Reduce per table entry overhead by 4 bytes, Pekka Enberg, (Mon Aug 9, 11:59 am)

Re: [PATCH 08/10] Some cleanups, Pekka Enberg, (Mon Aug 9, 12:02 pm)

Re: [PATCH 10/10] Document sysfs entries, Pekka Enberg, (Mon Aug 9, 12:02 pm)

Re: [PATCH 06/10] Block discard support, Pekka Enberg, (Mon Aug 9, 12:03 pm)

Re: [PATCH 06/10] Block discard support, Jens Axboe, (Mon Aug 9, 7:23 pm)

Re: [PATCH 01/10] Replace ioctls with sysfs interface, Nitin Gupta, (Mon Aug 9, 8:06 pm)

Re: [PATCH 02/10] Remove need for explicit device initiali ..., Nitin Gupta, (Mon Aug 9, 8:38 pm)

Re: [PATCH 03/10] Use percpu stats, Andrew Morton, (Mon Aug 9, 9:34 pm)

Re: [PATCH 04/10] Use percpu buffers, Nitin Gupta, (Mon Aug 9, 9:47 pm)

Re: [PATCH 06/10] Block discard support, Nitin Gupta, (Mon Aug 9, 9:54 pm)

Re: [PATCH 05/10] Reduce per table entry overhead by 4 bytes, Nitin Gupta, (Mon Aug 9, 9:55 pm)

Re: [PATCH 04/10] Use percpu buffers, Pekka Enberg, (Mon Aug 9, 10:05 pm)

Re: [PATCH 04/10] Use percpu buffers, Nitin Gupta, (Mon Aug 9, 10:32 pm)

Re: [PATCH 04/10] Use percpu buffers, Pekka Enberg, (Tue Aug 10, 12:36 am)

Re: [PATCH 06/10] Block discard support, Jens Axboe, (Tue Aug 10, 8:54 am)

Re: [PATCH 03/10] Use percpu stats, Nitin Gupta, (Wed Aug 11, 9:39 am)

Re: [PATCH 03/10] Use percpu stats, Andrew Morton, (Wed Aug 11, 10:18 am)

Re: [PATCH 03/10] Use percpu stats, Christoph Lameter, (Mon Aug 30, 9:20 am)

Re: [PATCH 03/10] Use percpu stats, Nitin Gupta, (Tue Aug 31, 1:31 pm)

Re: [PATCH 03/10] Use percpu stats, Eric Dumazet, (Tue Aug 31, 2:28 pm)

Re: [PATCH 03/10] Use percpu stats, Christoph Lameter, (Tue Aug 31, 2:35 pm)

Re: [PATCH 03/10] Use percpu stats, Eric Dumazet, (Tue Aug 31, 2:41 pm)

Re: [PATCH 00/10] zram: various improvements and cleanups, Greg KH, (Tue Aug 31, 3:37 pm)

Re: [PATCH 01/10] Replace ioctls with sysfs interface, Dave Hansen, (Tue Aug 31, 4:06 pm)

Re: [PATCH 00/10] zram: various improvements and cleanups, Anton Blanchard, (Tue Aug 31, 8:32 pm)

Re: [PATCH 03/10] Use percpu stats, Anton Blanchard, (Tue Aug 31, 8:41 pm)

Re: [PATCH 03/10] Use percpu stats, Anton Blanchard, (Tue Aug 31, 8:51 pm)

Re: [PATCH 03/10] Use percpu stats, Christoph Lameter, (Wed Sep 1, 1:05 pm)

Re: [PATCH 03/10] Use percpu stats, Eric Dumazet, (Wed Sep 1, 1:38 pm)

Re: [PATCH 03/10] Use percpu stats, Christoph Lameter, (Wed Sep 1, 5:34 pm)

[patch -rc] oom: always return a badness score of non-zero ..., David Rientjes, (Thu Sep 9, 12:07 pm)

Re: [patch -rc] oom: always return a badness score of non- ..., Dave Hansen, (Thu Sep 9, 12:48 pm)

Re: [patch -rc] oom: always return a badness score of non- ..., David Rientjes, (Thu Sep 9, 2:00 pm)

Re: [patch -rc] oom: always return a badness score of non- ..., Dave Hansen, (Thu Sep 9, 2:10 pm)

Re: [patch -rc] oom: always return a badness score of non- ..., David Rientjes, (Thu Sep 9, 2:40 pm)

Re: [PATCH 03/10] Use percpu stats, Andrew Morton, (Fri Sep 17, 1:59 pm)

Re: OOM panics with zram, Nitin Gupta, (Sun Oct 3, 11:41 am)

Re: OOM panics with zram, Dave Hansen, (Sun Oct 3, 12:27 pm)

Re: OOM panics with zram, Nitin Gupta, (Sun Oct 3, 12:40 pm)

Re: OOM panics with zram, Ed Tomlinson, (Mon Oct 4, 4:08 am)

Re: OOM panics with zram, Greg KH, (Tue Oct 5, 4:43 pm)

Re: OOM panics with zram, Nitin Gupta, (Tue Oct 5, 7:29 pm)

Re: OOM panics with zram, Greg KH, (Tue Oct 5, 7:36 pm)

Re: OOM panics with zram, Nitin Gupta, (Tue Oct 5, 9:30 pm)

Re: OOM panics with zram, Pekka Enberg, (Wed Oct 6, 12:38 am)

Re: OOM panics with zram, Greg KH, (Wed Oct 6, 7:02 am)

Re: OOM panics with zram, Greg KH, (Wed Oct 6, 7:03 am)

Re: OOM panics with zram, Pekka Enberg, (Wed Oct 6, 7:16 am)

Re: OOM panics with zram, Nitin Gupta, (Wed Oct 6, 7:53 am)

Navigation

Popular discussions


linux-kernel:
Rusty Russell	Re: 2.6.22-rc3-mm1
Gautham R Shenoy	[PATCH 1/8] Enhance process freezer interface for usage beyond software suspend
Jeffrey V. Merkey	Re: Versioning file system
James Bottomley	Re: [PATCH -mm 1/2] scsi: remove dma_is_consistent usage in 53c700
David Miller	Re: NO_HZ: timer interrupt stuck
git:
Oliver Kullmann	Re: how to move with history?
Junio C Hamano	Re: [PATCH 2/3] git-add--interactive: remove hunk coalescing
Miles Bader	Re: way to automatically add untracked files?
Harvey Harrison	Re: [SoC RFC] libsvn-fs-git: A git backend for the subversion filesystem
Alex Riesen	Re: git exclude patterns for directory
git-commits-head:
Linux Kernel Mailing List	V4L/DVB: tm6000: add special usb request to quit i2c tuner transfer
Linux Kernel Mailing List	OMAP: DSS2: SDI driver
Linux Kernel Mailing List	PCI: introduce pci_pcie_cap()
Linux Kernel Mailing List	netfilter: nf_conntrack_sip: add T.38 FAX support
Linux Kernel Mailing List	drivers/acpi: use kasprintf
linux-netdev:
Timo Teräs	ip xfrm policy semantics
David Miller	Re: [2.6.30-rc3] powerpc: compilation error of mace module
Patrick McHardy	Re: [rfc 02/13] [RFC 02/13] netfilter: nf_conntrack_sip: Add callid parser
webmaster Maintenance	&#32852;&#31995;&#31995;&#32479;&#31649;&#29702;&#21592;
Krzysztof Oledzki	Re: Error: an inet prefix is expected rather than "0/0".
openbsd-misc:
Ted Bullock	Re: Proliant DL380 G3 cannot get on network
Úlfar M. E. Johnson	installing openbsd in xen
Eric Furman	Re: Defending OpenBSD Performance
Damien Miller	Re: Patching a SSH 'Weakness'
frantisek holop	Re: mount ffs as msdos, system hangs

Colocation donated by:

Syndicate