Re: gpio-addr-flash warnings on x86/highmem (Re: i386 allmodconfig, current mainline)

Previous thread: i386 allmodconfig, current mainline by Andrew Morton on Monday, August 9, 2010 - 4:43 pm. (11 messages)

Next thread: Your winning number is: (CT-222-6747,FGN/P-900-56 by wins on Monday, August 9, 2010 - 4:43 pm. (1 message)
From: Mike Frysinger
Date: Monday, August 9, 2010 - 4:52 pm

i did get a bug report about this in the past, but honestly i havent
gotten around to fixing the issues.  it's been low priority as my
understanding is that the warning shows up in configurations where the
driver isnt realistically usable.  not making excuses, just laying out
the reality of things.
-mike
--

From: Andrew Morton
Date: Monday, August 9, 2010 - 5:07 pm

On Mon, 9 Aug 2010 19:52:35 -0400

Casting a resource_size_t to a kernel pointer is plain naughty.

I guess an acceptable "fix" would be to disable to offending combinations
in Kconfig and add a

	BUILD_BUG_ON(sizeof(gpios->start) != sizeof(void *))

to catch stragglers.

But please do fix warnings, if only because the warning storm from
allmodconfig causes people to miss important warnings in all the noise.
--

From: Mike Frysinger
Date: Monday, August 9, 2010 - 5:12 pm

i agree now, but when i wrote the driver, i wasnt aware of these


i try to be proactive with warnings that show up for my arch
(Blackfin), but admittedly i can get a little lazy when i'm not
directly affected

i think i should be able to find time before 2.6.36 to send out a
patch for the issue
-mike
--

Previous thread: i386 allmodconfig, current mainline by Andrew Morton on Monday, August 9, 2010 - 4:43 pm. (11 messages)

Next thread: Your winning number is: (CT-222-6747,FGN/P-900-56 by wins on Monday, August 9, 2010 - 4:43 pm. (1 message)