Home » Mailing list archives » linux-kernel » 2010 » August » 1

Re: [PATCH 04/25] ata: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used)

Previous thread: [PATCH 03/25] atm: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used) by Peter Huewe on Thursday, July 15, 2010 - 11:38 am. (2 messages)

Next thread: [PATCH] edac: mpc85xx: Fix coldplug/hotplug module autoloading by Anton Vorontsov on Thursday, July 15, 2010 - 11:40 am. (1 message)
[view original message]
From: Peter Huewe
Subject: [PATCH 04/25] ata: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used)
Date: Thursday, July 15, 2010 - 11:39 am

From: Peter Huewe <peterhuewe@gmx.de>

This patch converts pci_table entries, where .subvendor=PCI_ANY_ID and
.subdevice=PCI_ANY_ID, .class=0 and .class_mask=0, to use the
PCI_VDEVICE macro, and thus improves readability.

Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
---
 drivers/ata/pata_scc.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/ata/pata_scc.c b/drivers/ata/pata_scc.c
index d9db3f8..fe36966 100644
--- a/drivers/ata/pata_scc.c
+++ b/drivers/ata/pata_scc.c
@@ -168,8 +168,7 @@ static const unsigned long JCACTSELtbl[2][7] = {
 };
 
 static const struct pci_device_id scc_pci_tbl[] = {
-	{PCI_VENDOR_ID_TOSHIBA_2, PCI_DEVICE_ID_TOSHIBA_SCC_ATA,
-	 PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
+	{ PCI_VDEVICE(TOSHIBA_2, PCI_DEVICE_ID_TOSHIBA_SCC_ATA), 0},
 	{ }	/* terminate list */
 };
 
-- 
1.7.1

--


[ message continues ]
[view original message]
From: Jeff Garzik
Subject: Re: [PATCH 04/25] ata: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used)
Date: Sunday, August 1, 2010 - 4:48 pm

applied

I would prefer to leave ata_piix as it is, though.  It's nice and 
manageable :)


--


[ message continues ]
Previous thread: [PATCH 03/25] atm: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used) by Peter Huewe on Thursday, July 15, 2010 - 11:38 am. (2 messages)

Next thread: [PATCH] edac: mpc85xx: Fix coldplug/hotplug module autoloading by Anton Vorontsov on Thursday, July 15, 2010 - 11:40 am. (1 message)