Re: [PATCH 1/6] writeback: pass writeback_control down to move_expired_inodes()

Previous thread: [PATCH 4/6] writeback: sync expired inodes first in background writeback by Wu Fengguang on Wednesday, July 21, 2010 - 10:09 pm. (14 messages)

Next thread: [PATCH 6/6] writeback: introduce writeback_control.inodes_written by Wu Fengguang on Wednesday, July 21, 2010 - 10:09 pm. (2 messages)
From: Wu Fengguang
Date: Wednesday, July 21, 2010 - 10:09 pm

This is to prepare for moving the dirty expire policy to move_expired_inodes().
No behavior change.

Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
---
 fs/fs-writeback.c |   16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

--- linux-next.orig/fs/fs-writeback.c	2010-07-21 20:12:38.000000000 +0800
+++ linux-next/fs/fs-writeback.c	2010-07-21 20:14:38.000000000 +0800
@@ -213,8 +213,8 @@ static bool inode_dirtied_after(struct i
  * Move expired dirty inodes from @delaying_queue to @dispatch_queue.
  */
 static void move_expired_inodes(struct list_head *delaying_queue,
-			       struct list_head *dispatch_queue,
-				unsigned long *older_than_this)
+				struct list_head *dispatch_queue,
+				struct writeback_control *wbc)
 {
 	LIST_HEAD(tmp);
 	struct list_head *pos, *node;
@@ -224,8 +224,8 @@ static void move_expired_inodes(struct l
 
 	while (!list_empty(delaying_queue)) {
 		inode = list_entry(delaying_queue->prev, struct inode, i_list);
-		if (older_than_this &&
-		    inode_dirtied_after(inode, *older_than_this))
+		if (wbc->older_than_this &&
+		    inode_dirtied_after(inode, *wbc->older_than_this))
 			break;
 		if (sb && sb != inode->i_sb)
 			do_sb_sort = 1;
@@ -257,10 +257,10 @@ static void move_expired_inodes(struct l
  *                 => b_more_io inodes
  *                 => remaining inodes in b_io => (dequeue for sync)
  */
-static void queue_io(struct bdi_writeback *wb, unsigned long *older_than_this)
+static void queue_io(struct bdi_writeback *wb, struct writeback_control *wbc)
 {
 	list_splice_init(&wb->b_more_io, &wb->b_io);
-	move_expired_inodes(&wb->b_dirty, &wb->b_io, older_than_this);
+	move_expired_inodes(&wb->b_dirty, &wb->b_io, wbc);
 }
 
 static int write_inode(struct inode *inode, struct writeback_control *wbc)
@@ -519,7 +519,7 @@ void writeback_inodes_wb(struct bdi_writ
 	wbc->wb_start = jiffies; /* livelock avoidance */
 	spin_lock(&inode_lock);
 	if (!wbc->for_kupdate || ...
From: Jan Kara
Date: Friday, July 23, 2010 - 11:16 am

Looks OK.

-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR
--

From: Mel Gorman
Date: Monday, July 26, 2010 - 3:44 am

Can't see any problem.

Acked-by: Mel Gorman <mel@csn.ul.ie>

-- 
Mel Gorman
Part-time Phd Student                          Linux Technology Center
University of Limerick                         IBM Dublin Software Lab
--

From: Minchan Kim
Date: Sunday, August 1, 2010 - 8:23 am

Reviewed-by: Minchan Kim <minchan.kim@gmail.com>

-- 
Kind regards,
Minchan Kim
--

Previous thread: [PATCH 4/6] writeback: sync expired inodes first in background writeback by Wu Fengguang on Wednesday, July 21, 2010 - 10:09 pm. (14 messages)

Next thread: [PATCH 6/6] writeback: introduce writeback_control.inodes_written by Wu Fengguang on Wednesday, July 21, 2010 - 10:09 pm. (2 messages)