[Bug #16450] MTD drivers cannot be unloaded

Previous thread: Re: Formal Reiser4 inclusion and todo list? by Christian Stroetmann on Sunday, August 1, 2010 - 6:43 am. (4 messages)

Next thread: tracing lost time in early boot by Martin Pirker on Sunday, August 1, 2010 - 7:28 am. (2 messages)
From: Rafael J. Wysocki
Date: Sunday, August 1, 2010 - 6:46 am

This message contains a list of some regressions from 2.6.34,
for which there are no fixes in the mainline known to the tracking team.
If any of them have been fixed already, please let us know.

If you know of any other unresolved regressions from 2.6.34, please let us
know either and we'll add them to the list.  Also, please let us know
if any of the entries below are invalid.

Each entry from the list will be sent additionally in an automatic reply
to this message with CCs to the people involved in reporting and handling
the issue.


Listed regressions statistics:

  Date          Total  Pending  Unresolved
  ----------------------------------------
  2010-08-01      100       27          23
  2010-07-23       94       33          25
  2010-07-09       79       45          37
  2010-06-21       46       37          26
  2010-06-09       15       13          10


Unresolved regressions
----------------------

Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=16462
Subject		: unable to connect to AP on legal channels 12/13
Submitter	: Daniel J Blueman <daniel.blueman@gmail.com>
Date		: 2010-07-25 17:06 (8 days old)


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=16458
Subject		: Bluetooth disabled after resume
Submitter	: AttilaN <attila123456@gmail.com>
Date		: 2010-07-25 09:33 (8 days old)


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=16450
Subject		: MTD drivers cannot be unloaded
Submitter	: Ben Hutchings <bhutchings@solarflare.com>
Date		: 2010-07-24 00:17 (9 days old)


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=16448
Subject		: 2.6.35-rc5 panic at __br_deliver+0x64/0xe0 with kvm bridge networking
Submitter	: caiqian@redhat.com
Date		: 2010-07-23 3:25 (10 days old)
Message-ID	: <198123598.1050221279855515402.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com>
References	: http://marc.info/?l=linux-kernel&m=127985553916052&w=2


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=16423
Subject		: ...
From: Rafael J. Wysocki
Date: Sunday, August 1, 2010 - 6:46 am

This message has been generated automatically as a part of a summary report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.34.  Please verify if it still should be listed and let the tracking team
know (either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=16173
Subject		: After uncompressing the kernel, at boot time, the server hangs.
Submitter	: David Hill <hilld@binarystorm.net>
Date		: 2010-06-09 23:25 (54 days old)
First-Bad-Commit: http://git.kernel.org/linus/cf7500c0ea133d66f8449d86392d83f840102632
Handled-By	: Eric W. Biederman <ebiederm@xmission.com>


--

From: Rafael J. Wysocki
Date: Sunday, August 1, 2010 - 6:52 am

This message has been generated automatically as a part of a summary report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.34.  Please verify if it still should be listed and let the tracking team
know (either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=16215
Subject		: sysfs: cannot create duplicate filename '/class/net/bnep0'
Submitter	: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
Date		: 2010-06-15 14:55 (48 days old)
Handled-By	: Eric W. Biederman <ebiederm@xmission.com>


--

From: Rafael J. Wysocki
Date: Sunday, August 1, 2010 - 6:52 am

This message has been generated automatically as a part of a summary report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.34.  Please verify if it still should be listed and let the tracking team
know (either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=16221
Subject		: 2.6.35-rc2-git5 -- [drm:drm_mode_getfb] *ERROR* invalid framebuffer id
Submitter	: Miles Lane <miles.lane@gmail.com>
Date		: 2010-06-11 20:31 (52 days old)
Message-ID	: <AANLkTim0jVRyqkwlGOcrg_XTvUQwcBYfWJX-aRzkkrLG@mail.gmail.com>
References	: http://marc.info/?l=linux-kernel&m=127628828119623&w=2


--

From: Rafael J. Wysocki
Date: Sunday, August 1, 2010 - 6:52 am

This message has been generated automatically as a part of a summary report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.34.  Please verify if it still should be listed and let the tracking team
know (either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=16228
Subject		: BUG/boot failure on Dell Precision T3500 (pci/ahci_stop_engine)
Submitter	: Brian Bloniarz <phunge0@hotmail.com>
Date		: 2010-06-16 17:57 (47 days old)
Handled-By	: Bjorn Helgaas <bjorn.helgaas@hp.com>


--

From: Bjorn Helgaas
Date: Sunday, August 1, 2010 - 5:27 pm

This bug should still be on the list.  I hope to work on it this week.

Bjorn
--

From: Rafael J. Wysocki
Date: Sunday, August 1, 2010 - 6:52 am

This message has been generated automatically as a part of a summary report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.34.  Please verify if it still should be listed and let the tracking team
know (either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=16337
Subject		: general protection fault: 0000 [#1] SMP
Submitter	: Justin P. Mattock <justinmattock@gmail.com>
Date		: 2010-07-03 22:59 (30 days old)
Message-ID	: <4C2FC0E3.6050101@gmail.com>
References	: http://marc.info/?l=linux-kernel&m=127819798215589&w=2


--

From: Justin P. Mattock
Date: Sunday, August 1, 2010 - 6:01 pm

Ive played around with the machine that originally hit this. but still 
cant seem to reproduce or trigger this.

Justin P. Mattock
--

From: Rafael J. Wysocki
Date: Monday, August 2, 2010 - 6:34 am

I'll close it, then.  Please reopen if you reproduce the issue.

Rafael
--

From: Justin P. Mattock
Date: Monday, August 2, 2010 - 6:47 am

o.k. Ill keep my eye out for this.. and if im able to reproduce I'll 
bisect it re-open this bug etc...

Justin P. Mattock
--

From: Rafael J. Wysocki
Date: Sunday, August 1, 2010 - 6:52 am

This message has been generated automatically as a part of a summary report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.34.  Please verify if it still should be listed and let the tracking team
know (either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=16365
Subject		: kernel BUG at fs/btrfs/extent-tree.c:1353
Submitter	: Johannes Hirte <johannes.hirte@fem.tu-ilmenau.de>
Date		: 2010-07-08 14:27 (25 days old)
Message-ID	: <201007081627.24654.johannes.hirte@fem.tu-ilmenau.de>
References	: http://marc.info/?l=linux-kernel&m=127859960725931&w=2


--

From: Rafael J. Wysocki
Date: Sunday, August 1, 2010 - 6:52 am

This message has been generated automatically as a part of a summary report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.34.  Please verify if it still should be listed and let the tracking team
know (either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=16312
Subject		: WARNING: at fs/fs-writeback.c:1127 __mark_inode_dirty
Submitter	: Zdenek Kabelac <zdenek.kabelac@gmail.com>
Date		: 2010-06-28 9:40 (35 days old)
Message-ID	: <AANLkTin24fr5O4_q5Xbo9Y_NKkEmtcp6Hgmr9_4qXaFz@mail.gmail.com>
References	: http://marc.info/?l=linux-kernel&m=127771804806465&w=2
Handled-By	: Jan Kara <jack@suse.cz>
Patch		: https://bugzilla.kernel.org/attachment.cgi?id=27272


--

From: Rafael J. Wysocki
Date: Sunday, August 1, 2010 - 6:52 am

This message has been generated automatically as a part of a summary report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.34.  Please verify if it still should be listed and let the tracking team
know (either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=16393
Subject		: kernel BUG at fs/block_dev.c:765!
Submitter	: Markus Trippelsdorf <markus@trippelsdorf.de>
Date		: 2010-07-14 13:52 (19 days old)
Message-ID	: <20100714135217.GA1797@arch.tripp.de>
References	: http://marc.info/?l=linux-kernel&m=127911564213748&w=2


--

From: Rafael J. Wysocki
Date: Sunday, August 1, 2010 - 6:52 am

This message has been generated automatically as a part of a summary report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.34.  Please verify if it still should be listed and let the tracking team
know (either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=16396
Subject		: [bisected] resume from suspend freezes system
Submitter	: tomas m <tmezzadra@gmail.com>
Date		: 2010-07-15 02:32 (18 days old)
Handled-By	: Rafael J. Wysocki <rjw@sisk.pl>


--

From: Rafael J. Wysocki
Date: Sunday, August 1, 2010 - 6:52 am

This message has been generated automatically as a part of a summary report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.34.  Please verify if it still should be listed and let the tracking team
know (either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=16450
Subject		: MTD drivers cannot be unloaded
Submitter	: Ben Hutchings <bhutchings@solarflare.com>
Date		: 2010-07-24 00:17 (9 days old)


--

From: Rafael J. Wysocki
Date: Sunday, August 1, 2010 - 6:52 am

This message has been generated automatically as a part of a summary report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.34.  Please verify if it still should be listed and let the tracking team
know (either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=16458
Subject		: Bluetooth disabled after resume
Submitter	: AttilaN <attila123456@gmail.com>
Date		: 2010-07-25 09:33 (8 days old)


--

From: Oliver Neukum
Date: Monday, August 2, 2010 - 5:19 am

Which power state is that? S1, S3 or S4?

	Regards
		Oliver
--

From: Rafael J. Wysocki
Date: Sunday, August 1, 2010 - 6:52 am

This message has been generated automatically as a part of a summary report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.34.  Please verify if it still should be listed and let the tracking team
know (either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=16448
Subject		: 2.6.35-rc5 panic at __br_deliver+0x64/0xe0 with kvm bridge networking
Submitter	: caiqian@redhat.com
Date		: 2010-07-23 3:25 (10 days old)
Message-ID	: <198123598.1050221279855515402.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com>
References	: http://marc.info/?l=linux-kernel&m=127985553916052&w=2


--

From: Rafael J. Wysocki
Date: Sunday, August 1, 2010 - 6:52 am

This message has been generated automatically as a part of a summary report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.34.  Please verify if it still should be listed and let the tracking team
know (either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=16462
Subject		: unable to connect to AP on legal channels 12/13
Submitter	: Daniel J Blueman <daniel.blueman@gmail.com>
Date		: 2010-07-25 17:06 (8 days old)


--

From: Daniel J Blueman
Date: Monday, August 2, 2010 - 7:58 am

Yes, I just managed to reproduce this with 2.6.35-final, and will
update the bugzilla entry with the wire-capture needed.
-- 
Daniel J Blueman
--

From: Justin P. Mattock
Date: Monday, August 2, 2010 - 8:49 am

ahh.. cool.. lets get this bug fixed...

Justin P. Mattock
--

From: Justin P. Mattock
Date: Monday, August 2, 2010 - 8:51 am

Oops just realized your talking about another bug. nevermind.

Justin P. Mattock
--

From: Rafael J. Wysocki
Date: Sunday, August 1, 2010 - 6:52 am

This message has been generated automatically as a part of a summary report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.34.  Please verify if it still should be listed and let the tracking team
know (either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=16406
Subject		: Badness with the kernel version 2.6.35-rc1-git1 running on P6 box
Submitter	: divya <dipraksh@linux.vnet.ibm.com>
Date		: 2010-07-16 8:50 (17 days old)
Message-ID	: <4C401D56.3070108@linux.vnet.ibm.com>
References	: http://marc.info/?l=linux-kernel&m=127927024906085&w=2


--

From: Rafael J. Wysocki
Date: Sunday, August 1, 2010 - 6:52 am

This message has been generated automatically as a part of a summary report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.34.  Please verify if it still should be listed and let the tracking team
know (either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=16423
Subject		: netfilter/iptables stopped logging 2.6.35-rc
Submitter	: auto401300@hushmail.com
Date		: 2010-07-17 10:20 (16 days old)
Message-ID	: <20100717072036.1BBE52804B@smtp.hushmail.com>
References	: http://lkml.indiana.edu/hypermail/linux/kernel/1007.2/00440.html


--

From: Rafael J. Wysocki
Date: Sunday, August 1, 2010 - 6:52 am

This message has been generated automatically as a part of a summary report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.34.  Please verify if it still should be listed and let the tracking team
know (either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=16405
Subject		: Brightness Adjustment on Toshiba nb305 Netbooks is non-functional.
Submitter	: John Mesmon <jmesmon@gmail.com>
Date		: 2010-07-15 23:40 (18 days old)
First-Bad-Commit: http://git.kernel.org/linus/74a365b3f354fafc537efa5867deb7a9fadbfe27
Handled-By	: Matthew Garrett <mjg59-kernel@srcf.ucam.org>
Patch		: https://bugzilla.kernel.org/attachment.cgi?id=27236


--

From: Rafael J. Wysocki
Date: Sunday, August 1, 2010 - 6:52 am

This message has been generated automatically as a part of a summary report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.34.  Please verify if it still should be listed and let the tracking team
know (either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=16399
Subject		: perf failed with kernel 2.6.35-rc
Submitter	: Zhang, Yanmin <yanmin_zhang@linux.intel.com>
Date		: 2010-07-13 8:14 (20 days old)
First-Bad-Commit: http://git.kernel.org/linus/1ac62cfff252fb668405ef3398a1fa7f4a0d6d15
Message-ID	: <1279008849.2096.913.camel@ymzhang.sh.intel.com>
References	: http://marc.info/?l=linux-kernel&m=127900880212470&w=2


--

From: Rafael J. Wysocki
Date: Sunday, August 1, 2010 - 6:52 am

This message has been generated automatically as a part of a summary report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.34.  Please verify if it still should be listed and let the tracking team
know (either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=16400
Subject		: 2.6.35-rc5 inconsistent lock state
Submitter	: Martin Pirker <lkml.collector@gmail.com>
Date		: 2010-07-14 20:33 (19 days old)
Message-ID	: <AANLkTikDF0TL6OyPVCzPlUTwxFehcrETn3ysgSSeTq92@mail.gmail.com>
References	: http://marc.info/?l=linux-kernel&m=127913961025267&w=2


--

From: Rafael J. Wysocki
Date: Sunday, August 1, 2010 - 6:52 am

This message has been generated automatically as a part of a summary report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.34.  Please verify if it still should be listed and let the tracking team
know (either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=16310
Subject		: arm omap invalid module format
Submitter	: Robert Nelson <robertcnelson@gmail.com>
Date		: 2010-06-28 17:30 (35 days old)
First-Bad-Commit: http://git.kernel.org/linus/d0679c730395d0bde9a46939e7ba255b4ba7dd7c
Handled-By	: Michal Marek <mmarek@suse.cz>
Patch		: https://bugzilla.kernel.org/attachment.cgi?id=26999


--

From: Rafael J. Wysocki
Date: Sunday, August 1, 2010 - 6:52 am

This message has been generated automatically as a part of a summary report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.34.  Please verify if it still should be listed and let the tracking team
know (either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=16322
Subject		: WARNING: at /arch/x86/include/asm/processor.h:1005 read_measured_perf_ctrs+0x5a/0x70()
Submitter	: boris64 <bugzilla.kernel.org@boris64.net>
Date		: 2010-07-01 13:54 (32 days old)
Handled-By	: H. Peter Anvin <hpa@zytor.com>


--

From: Rafael J. Wysocki
Date: Sunday, August 1, 2010 - 6:52 am

This message has been generated automatically as a part of a summary report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.34.  Please verify if it still should be listed and let the tracking team
know (either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=16369
Subject		: Yet another 2.6.35 regression (AGP)?
Submitter	: Woody Suwalski <terraluna977@gmail.com>
Date		: 2010-07-09 14:21 (24 days old)
Message-ID	: <4C373084.8000503@gmail.com>
References	: http://marc.info/?l=linux-kernel&m=127868797119254&w=2


--

From: Rafael J. Wysocki
Date: Sunday, August 1, 2010 - 6:52 am

This message has been generated automatically as a part of a summary report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.34.  Please verify if it still should be listed and let the tracking team
know (either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=16383
Subject		: Regression with e1000e from 2.6.34.1 to 2.6.35-rc5
Submitter	: Stefan Behte <craig@haquarter.de>
Date		: 2010-07-14 00:44 (19 days old)


--

From: Rafael J. Wysocki
Date: Sunday, August 1, 2010 - 6:52 am

This message has been generated automatically as a part of a summary report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.34.  Please verify if it still should be listed and let the tracking team
know (either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=16278
Subject		: lvm snapshot causes deadlock in 2.6.35
Submitter	: Phillip Susi <psusi@cfl.rr.com>
Date		: 2010-06-23 16:55 (40 days old)
Handled-By	: Eric Sandeen <sandeen@redhat.com>
Patch		: https://bugzilla.kernel.org/attachment.cgi?id=26933


--

From: Rafael J. Wysocki
Date: Sunday, August 1, 2010 - 6:52 am

This message has been generated automatically as a part of a summary report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.34.  Please verify if it still should be listed and let the tracking team
know (either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=16307
Subject		: i915 in kernel 2.6.35-rc3, high number of wakeups
Submitter	: Enrico Bandiello <enban@postal.uv.es>
Date		: 2010-06-26 16:57 (37 days old)
Message-ID	: <<4C26317A.5070309@postal.uv.es>>
References	: http://marc.info/?l=linux-kernel&m=127757403404259&w=2


--

From: Rafael J. Wysocki
Date: Sunday, August 1, 2010 - 6:52 am

This message has been generated automatically as a part of a summary report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.34.  Please verify if it still should be listed and let the tracking team
know (either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=16380
Subject		: Loop devices act strangely in 2.6.35
Submitter	: Artem S. Tashkinov <t.artem@mailcity.com>
Date		: 2010-07-13 23:21 (20 days old)


--

From: Rafael J. Wysocki
Date: Sunday, August 1, 2010 - 6:52 am

This message has been generated automatically as a part of a summary report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.34.  Please verify if it still should be listed and let the tracking team
know (either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=16184
Subject		: Container, X86-64, i386, iptables rule
Submitter	: Jean-Marc Pigeon <jmp@safe.ca>
Date		: 2010-06-12 04:17 (51 days old)
Handled-By	: Patrick McHardy <kaber@trash.net>


--

From: Rafael J. Wysocki
Date: Sunday, August 1, 2010 - 6:52 am

This message has been generated automatically as a part of a summary report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.34.  Please verify if it still should be listed and let the tracking team
know (either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=16265
Subject		: Why is kslowd accumulating so much CPU time?
Submitter	: Theodore Ts'o <tytso@mit.edu>
Date		: 2010-06-09 18:36 (54 days old)
First-Bad-Commit: http://git.kernel.org/linus/fbf81762e385d3d45acad057b654d56972acf58c
Message-ID	: <E1OMQ88-0002a1-Gb@closure.thunk.org>
References	: http://marc.info/?l=linux-kernel&m=127610857819033&w=4


--

From: Stefan Richter
Date: Sunday, August 1, 2010 - 7:48 am

Subject		: 2.6.35-rc6+: i915: Bisected regression
Submitter	: Thomas Meyer <thomas@m3y3r.de>
Date		: Sun, 1 Aug 2010 11:01:00 +0200
Message-ID	: <201008011101.01429.thomas@m3y3r.de>
References	: http://lkml.org/lkml/2010/8/1/43
First-Bad-Commit:
http://git.kernel.org/linus/d1b851fc0d105caa6b6e3e7c92d2987dfb52cbe0

-- 
Stefan Richter
-=====-==-=- =--- ----=
http://arcgraph.de/sr/
--

From: Rafael J. Wysocki
Date: Sunday, August 1, 2010 - 8:50 am

Thanks!

Please note, however, that regressions reported by e-mail are only put into
the Bugzilla if the reports are at least one week old.

Rafael
--

From: Linus Torvalds
Date: Sunday, August 1, 2010 - 11:01 am

This has a proposed patch. I don't know what the status of it is, though. Jens?


This one is interesting. And I think I perhaps see where it's coming from.

bd_start_claiming() (through bd_prepare_to_claim()) has two separate
success cases: either there was no holder (bd_claiming is NULL) or the
new holder was already claiming it (bd_claiming == holder).

Note in particular the case of the holder _already_ holding it. What happens is:

 - bd_start_claiming() succeeds because we had _already_ claimed it
with the same holder

 - then some error happens, and we call bd_abort_claiming(), which
does whole->bd_claiming = NULL;

 - the original holder thinks it still holds the bd, but it has been released!

 - a new claimer comes in, and succeeds because bd_claiming is now NULL.

 - we now have two "owners" of the bd, but bd_claiming only points to
the second one.

I think bd_start_claiming() needs to do some kind of refcount for the
nested holder case, and bd_abort_claiming() needs to decrement the
refcount and only clear the bd_claiming field when it goes down to
zero.

I dunno. Maybe there's something else going on, but it does look
suspicious, and the above would explain the BUG_ON().


Should hopefully be fixed by commit e7b96f28c58c ("agp/intel: Use the

This one is reportedly fixed by commit 83ba7b071f30 ("writeback:

Fixed by commit 24b1442d01ae155ea716dfb94ed21605541c317d.

                             Linus
--

From: Tejun Heo
Date: Monday, August 2, 2010 - 9:32 am

Hello, Linus.


Yeah, that definitely sounds plausible.  I think the condition check
in bd_prepare_to_claim() should have been "if (whole->bd_claiming)"
instead of "if (whole->bd_claiming && whole->bd_claiming != holder)".
It doesn't make much sense to allow multiple parallel claiming
operations anyway and the comment above already says - "This function
fails if @bdev is already claimed by another holder and waits if
another claiming is in progress."

I'll try to build a test case and verify it.

Thank you.

-- 
tejun
--

From: Rafael J. Wysocki
Date: Sunday, August 1, 2010 - 2:37 pm

Closed.

Thanks,
Rafael
--

From: Tejun Heo
Date: Wednesday, August 4, 2010 - 8:40 am

bd_prepare_to_claim() incorrectly allowed multiple attempts for
exclusive open to progress in parallel if the attempting holders are
identical.  This triggered BUG_ON() as reported in the following bug.

  https://bugzilla.kernel.org/show_bug.cgi?id=16393

__bd_abort_claiming() is used to finish claiming blocks and doesn't
work if multiple openers are inside a claiming block.  Allowing
multiple parallel open attempts to continue doesn't gain anything as
those are serialized down in the call chain anyway.  Fix it by always
allowing only single open attempt in a claiming block.

This problem can easily be reproduced by adding a delay after
bd_prepare_to_claim() and attempting to mount two partitions of a
disk.

stable: only applicable to v2.6.35

Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Maciej Rutecki <maciej.rutecki@gmail.com>
Cc: stable@kernel.org
---
 fs/block_dev.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/block_dev.c b/fs/block_dev.c
index 99d6af8..b3171fb 100644
--- a/fs/block_dev.c
+++ b/fs/block_dev.c
@@ -681,8 +681,8 @@ retry:
 	if (!bd_may_claim(bdev, whole, holder))
 		return -EBUSY;

-	/* if someone else is claiming, wait for it to finish */
-	if (whole->bd_claiming && whole->bd_claiming != holder) {
+	/* if claiming is already in progress, wait for it to finish */
+	if (whole->bd_claiming) {
 		wait_queue_head_t *wq = bit_waitqueue(&whole->bd_claiming, 0);
 		DEFINE_WAIT(wait);

--

From: Tejun Heo
Date: Wednesday, August 4, 2010 - 8:59 am

bd_prepare_to_claim() incorrectly allowed multiple attempts for
exclusive open to progress in parallel if the attempting holders are
identical.  This triggered BUG_ON() as reported in the following bug.

  https://bugzilla.kernel.org/show_bug.cgi?id=16393

__bd_abort_claiming() is used to finish claiming blocks and doesn't
work if multiple openers are inside a claiming block.  Allowing
multiple parallel open attempts to continue doesn't gain anything as
those are serialized down in the call chain anyway.  Fix it by always
allowing only single open attempt in a claiming block.

This problem can easily be reproduced by adding a delay after
bd_prepare_to_claim() and attempting to mount two partitions of a
disk.

stable: only applicable to v2.6.35

Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Markus Trippelsdorf <markus@trippelsdorf.de>
Cc: stable@kernel.org
---
Oops, had the wrong reported-by credit.  Updated.

Thanks.

 fs/block_dev.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/block_dev.c b/fs/block_dev.c
index 99d6af8..b3171fb 100644
--- a/fs/block_dev.c
+++ b/fs/block_dev.c
@@ -681,8 +681,8 @@ retry:
 	if (!bd_may_claim(bdev, whole, holder))
 		return -EBUSY;

-	/* if someone else is claiming, wait for it to finish */
-	if (whole->bd_claiming && whole->bd_claiming != holder) {
+	/* if claiming is already in progress, wait for it to finish */
+	if (whole->bd_claiming) {
 		wait_queue_head_t *wq = bit_waitqueue(&whole->bd_claiming, 0);
 		DEFINE_WAIT(wait);

--

From: Jens Axboe
Date: Thursday, August 5, 2010 - 2:02 am

Thanks Tejun, applied.

-- 
Jens Axboe


Confidentiality Notice: This e-mail message, its contents and any attachments to it are confidential to the intended recipient, and may contain information that is privileged and/or exempt from disclosure under applicable law. If you are not the intended recipient, please immediately notify the sender and destroy the original e-mail message and any attachments (and any copies that may have been made) from your system or otherwise. Any unauthorized use, copying, disclosure or distribution of this information is strictly prohibited.
--

From: Markus Trippelsdorf
Date: Thursday, August 5, 2010 - 2:17 am

It's already in mainline:
e75aa85892b2ee78c79edac720868cbef16e62eb

-- 
»A man who doesn't know he is in prison can never escape.«
William S. Burroughs
--

From: Jens Axboe
Date: Thursday, August 5, 2010 - 2:20 am

Irk, had not noticed yet, my for-2.6.36 branch isn't fully merged
up yet. Thanks for the heads-up.

-- 
Jens Axboe


Confidentiality Notice: This e-mail message, its contents and any attachments to it are confidential to the intended recipient, and may contain information that is privileged and/or exempt from disclosure under applicable law. If you are not the intended recipient, please immediately notify the sender and destroy the original e-mail message and any attachments (and any copies that may have been made) from your system or otherwise. Any unauthorized use, copying, disclosure or distribution of this information is strictly prohibited.
--

From: Larry Finger
Date: Sunday, August 1, 2010 - 12:39 pm

I am beginning to think that Bug 16312 is not the same as Bug 16122. Even with
the patches from 16312, I still get warnings as below:

[   11.728776] ------------[ cut here ]------------
[   11.728787] WARNING: at fs/fs-writeback.c:964 __mark_inode_dirty+0x10f/0x1a0()
[   11.728790] Hardware name: HP Pavilion dv2700 Notebook PC
[   11.728792] Modules linked in: loop(+) dm_mod ide_cd_mod cdrom
snd_hda_codec_conexant ide_pci_generic arc4 ecb b43 rng_core mac80211
snd_hda_intel r8712u(C) cfg80211 snd_hda_codec amd74xx snd_pcm sg ide_core
rfkill led_class snd_timer ssb mmc_core pcmcia snd joydev k8temp hwmon
i2c_nforce2 pcmcia_core forcedeth serio_raw snd_page_alloc i2c_core battery ac
button ext4 mbcache jbd2 crc16 ohci_hcd sd_mod ehci_hcd usbcore fan processor
ahci libahci libata scsi_mod thermal
[   11.728854] Pid: 2449, comm: udisks-part-id Tainted: G         C
2.6.35-rc6-realtek+ #15
[   11.728857] Call Trace:
[   11.728865]  [<ffffffff8104608a>] warn_slowpath_common+0x7a/0xb0
[   11.728869]  [<ffffffff810460d5>] warn_slowpath_null+0x15/0x20
[   11.728874]  [<ffffffff81129d5f>] __mark_inode_dirty+0x10f/0x1a0
[   11.728879]  [<ffffffff8111e07d>] touch_atime+0x12d/0x170
[   11.728885]  [<ffffffff810cab91>] generic_file_aio_read+0x5c1/0x720
[   11.728890]  [<ffffffff81107ca2>] do_sync_read+0xd2/0x110
[   11.728896]  [<ffffffff81077e7d>] ? trace_hardirqs_on+0xd/0x10
[   11.728900]  [<ffffffff811083c3>] vfs_read+0xb3/0x170
[   11.728906]  [<ffffffff81002d1c>] ? sysret_check+0x27/0x62
[   11.728909]  [<ffffffff811084cc>] sys_read+0x4c/0x80
[   11.728914]  [<ffffffff81002ceb>] system_call_fastpath+0x16/0x1b
[   11.728917] ---[ end trace 32e16cacad33229f ]---
[   11.728919] bdi-block not registered

The warnings do not occur with every boot and appear to be some kind of race
condition.

Larry
--

Previous thread: Re: Formal Reiser4 inclusion and todo list? by Christian Stroetmann on Sunday, August 1, 2010 - 6:43 am. (4 messages)

Next thread: tracing lost time in early boot by Martin Pirker on Sunday, August 1, 2010 - 7:28 am. (2 messages)