Home » Mailing list archives » linux-kernel » 2010 » July » 8

Re: [PATCH 18/18] vfs: make no_llseek the default

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Arnd Bergmann
Subject: Re: [PATCH 18/18] vfs: make no_llseek the default
Date: Thursday, July 8, 2010 - 6:18 am

On Thursday 08 July 2010, Tetsuo Handa wrote:

Yes, the total patch is almost 200kb, which I considered too large.
I explained this in the changelog.

In retrospect, I probably should have sent it all anyway, because the
changelog is already very long and a few other people did not realize
this either because they did only read the patch but not the changelog.

As I mentioned to Boaz Harrosh, the full patch is available on
http://git.kernel.org/?p=linux/kernel/git/arnd/bkl.git;a=patch;h=dc731e01d2a08eb66ae08...
and I'll send it out completely if I send out the series again.

I first want to make sure we have consensus on the semantic patch though.
In particular, I want to be sure everyone agrees on the following questions:

- should we kill default_llseek in favour of a more generic generic_file_llseek
  that also covers special files?
- if not, should default_llseek get renamed to something else?
- should I bother adding .llseek=no_llseek if we make that the default in the
  next step anyway?
- should I drop all the automatically generated comments?
- Do I need to split this patch up into per-maintainer chunks and send them
  through the individual trees, or do we just apply the semantic patch treewide
  at the end of the merge window?

	Arnd
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 00/18] VFS: turn no_llseek into the default, Arnd Bergmann, (Wed Jul 7, 2:40 pm)
[PATCH 04/18] ib/qib: use generic_file_llseek, Arnd Bergmann, (Wed Jul 7, 2:40 pm)
[PATCH 05/18] arm/omap: use generic_file_llseek in iommu_debug, Arnd Bergmann, (Wed Jul 7, 2:40 pm)
[PATCH 07/18] staging: use llseek in all file operations, Arnd Bergmann, (Wed Jul 7, 2:40 pm)
[PATCH 09/18] tracing: use generic_file_llseek for debugfs, Arnd Bergmann, (Wed Jul 7, 2:40 pm)
[PATCH 12/18] raw: use explicit llseek file operations, Arnd Bergmann, (Wed Jul 7, 2:40 pm)
[PATCH 13/18] ima: use generic_file_llseek for securityfs, Arnd Bergmann, (Wed Jul 7, 2:40 pm)
[PATCH 15/18] viotape: use noop_llseek, Arnd Bergmann, (Wed Jul 7, 2:40 pm)
[PATCH 17/18] vfs: don't use BKL in default_llseek, Arnd Bergmann, (Wed Jul 7, 2:40 pm)
[PATCH 18/18] vfs: make no_llseek the default, Arnd Bergmann, (Wed Jul 7, 2:40 pm)
Re: [PATCH 09/18] tracing: use generic_file_llseek for debugfs, Frederic Weisbecker, (Wed Jul 7, 2:58 pm)
Re: [PATCH 18/18] vfs: make no_llseek the default, Tetsuo Handa, (Thu Jul 8, 4:25 am)
Re: [PATCH 18/18] vfs: make no_llseek the default, Arnd Bergmann, (Thu Jul 8, 5:08 am)
Re: [PATCH 13/18] ima: use generic_file_llseek for securityfs, Mimi Zohar, (Thu Jul 8, 5:50 am)
Re: [PATCH 18/18] vfs: make no_llseek the default, Tetsuo Handa, (Thu Jul 8, 5:57 am)
Re: [PATCH 13/18] ima: use generic_file_llseek for securityfs, Arnd Bergmann, (Thu Jul 8, 6:00 am)
Re: [PATCH 13/18] ima: use generic_file_llseek for securityfs, Mimi Zohar, (Thu Jul 8, 6:18 am)
Re: [PATCH 18/18] vfs: make no_llseek the default, Arnd Bergmann, (Thu Jul 8, 6:18 am)
Re: [PATCH 13/18] ima: use generic_file_llseek for securityfs, James Morris, (Thu Jul 8, 3:52 pm)
Re: [PATCH 18/18] vfs: make no_llseek the default, James Morris, (Thu Jul 8, 3:55 pm)
Re: [PATCH 13/18] ima: use generic_file_llseek for securityfs, Arnd Bergmann, (Fri Jul 9, 6:00 am)
Re: [PATCH 13/18] ima: use generic_file_llseek for securityfs, James Morris, (Sun Jul 11, 4:45 pm)
Re: [PATCH 04/18] ib/qib: use generic_file_llseek, Roland Dreier, (Wed Jul 21, 11:40 am)
[tip:perf/core] tracing: Use generic_file_llseek for debugfs, tip-bot for Arnd Ber ..., (Wed Jul 21, 1:52 pm)
Re: [PATCH 12/18] raw: use explicit llseek file operations, Frederic Weisbecker, (Wed Jul 21, 4:50 pm)
Re: [PATCH 15/18] viotape: use noop_llseek, Frederic Weisbecker, (Wed Jul 21, 4:59 pm)