[PATCH] omfs: fix memory leak

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Davidlohr Bueso
Date: Saturday, July 3, 2010 - 7:33 pm

Hi,

In omfs_fill_super(), when returning on error, sbi is not being freed.

Thanks,
Davidlohr.

Signed-off-by: Davidlohr Bueso <dave@gnu.org>
---
 fs/omfs/inode.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/fs/omfs/inode.c b/fs/omfs/inode.c
index 089839a..253846e 100644
--- a/fs/omfs/inode.c
+++ b/fs/omfs/inode.c
@@ -523,12 +523,14 @@ static int omfs_fill_super(struct super_block *sb, void *data, int silent)
 	}
 	printk(KERN_DEBUG "omfs: Mounted volume %s\n", omfs_rb->r_name);
 
-	ret = 0;
+	ret = 0; /* success */
 out_brelse_bh2:
 	brelse(bh2);
 out_brelse_bh:
 	brelse(bh);
 end:
+	if (ret != 0)
+		kfree(sbi);
 	return ret;
 }
 
-- 
1.7.0.4



--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] omfs: fix memory leak, Davidlohr Bueso, (Sat Jul 3, 7:33 pm)
Re: [PATCH] omfs: fix memory leak, Davidlohr Bueso, (Sun Jul 4, 10:12 pm)
Re: [linux-karma-devel] [PATCH] omfs: fix memory leak, Davidlohr Bueso, (Mon Jul 5, 9:50 pm)