Re: [PATCH]md:dm.c Fix warning: statement with no effect

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Justin P. Mattock

Subject: Re: [PATCH]md:dm.c Fix warning: statement with no effect

Date: Saturday, July 31, 2010 - 12:13 pm

On 07/31/2010 12:07 PM, Alasdair G Kergon wrote:
quoted text> On Sat, Jul 31, 2010 at 12:05:04PM -0700, Justin P. Mattock wrote:
>> haven't heard any feedback on this any ideas?
>>> Ive noticed that having CONFIG_BLK_DEV_INTEGRITY=n I get warning messages generated by GCC(below)
>>>     CC      drivers/md/dm.o
>>> drivers/md/dm.c: In function 'split_bvec':
>>> drivers/md/dm.c:1117:3: warning: statement with no effect
>>> drivers/md/dm.c: In function 'clone_bio':
>>> drivers/md/dm.c:1145:3: warning: statement with no effect
>
> I'd suggest hiding it inside the .h files and not trying to scatter #ifdefs
> throughout the code.
>
> Alasdair
>
>


cool thanks.. I'll have a look and see if I can come up with something.

Justin P. Mattock
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH]md:dm.c Fix warning: statement with no effect, Justin P. Mattock, (Mon Jul 12, 6:26 pm)

Re: [PATCH]md:dm.c Fix warning: statement with no effect, Justin P. Mattock, (Sat Jul 31, 12:05 pm)

Re: [PATCH]md:dm.c Fix warning: statement with no effect, Alasdair G Kergon, (Sat Jul 31, 12:07 pm)

Re: [PATCH]md:dm.c Fix warning: statement with no effect, Justin P. Mattock, (Sat Jul 31, 12:13 pm)

Re: [PATCH]md:dm.c Fix warning: statement with no effect, Justin P. Mattock, (Sun Aug 1, 3:23 pm)


linux-kernel:
David Howells	[PATCH] KEYS: Use the variable 'key' in keyctl_describe_key()
Dave Jones	Re: OT: character encodings (was: Linux 2.6.20-rc4)
Greg Kroah-Hartman	[PATCH 17/36] sysdev: detect multiple driver registrations
Sam Ravnborg	Re: [PATCH] kbuild: fix make V=1
Nick Piggin	Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures
linux-netdev:
Jarek Poplawski	Re: [PATCH] flush_work_sync vs. flush_scheduled_work Re: [PATCH] PHYLIB: IRQ event...
Lennert Buytenhek	Re: Distributed Switch Architecture(DSA)
Daniel Schaffrath	Re: tcp bw in 2.6
Matt Mackall	Re: [regression] nf_iterate(), BUG: unable to handle kernel NULL pointer dereference
Gerrit Renker	[PATCH 37/37] dccp: Debugging functions for feature negotiation
git:
Stephen R. van den Berg	Re: [RFC] origin link for cherry-pick and revert
Junio C Hamano	Re: [PATCH 1/2] Teach git-describe to display distances from tags.
Johannes Schindelin	Re: [PATCH 2/2] git-svn: support fetch with autocrlf on
Dan Chokola	Re: how do you "force a pull"?
Junio C Hamano	Re: [PATCH 6/6] Teach core object handling functions about gitlinks
openbsd-misc:
Claudio Jeker	Re: Vlan Tag on Vlan Tag (l2tunneling)
Josh Grosse	ssh/sshd challenge-response seems to have stopped working in -current
Pieter Verberne	File collision while using pkg_add
Tomas Bodzar	bsd: uvm_mapent_alloc: out of static map entries
Community First Financial	Teacher A+ Loan
git-commits-head:
Linux Kernel Mailing List	tracing: protect reader of cmdline output
Linux Kernel Mailing List	kconfig: recalc symbol value before showing search results
Linux Kernel Mailing List	KVM: VMX: Clear CR4.VMXE in hardware_disable
Linux Kernel Mailing List	USB: set correct configuration in probe of ti_usb_3410_5052
Linux Kernel Mailing List	ath9k: Added get_survey callback in order to get channel noise