Re: [PATCHv10 2.6.35-rc6-tip 10/14] perf: rename common fields/functions from kprobe to probe.

view
thread

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Masami Hiramatsu

Subject: Re: [PATCHv10 2.6.35-rc6-tip 10/14] perf: rename common fields/functions from kprobe to probe.

Date: Thursday, July 29, 2010 - 4:51 am

Srikar Dronamraju wrote:
quoted text> As a precursor for perf to support uprobes, rename fields/functions
> that had kprobe in their name but can be shared across perf-kprobes
> and perf-uprobes to probe.

Yeah, renaming itself is OK for me. But please do it carefully,
I can see some gaps between 1st line and 2nd line like below
after applying this patch...

static int kprobe_convert_to_perf_probe(struct probe_trace_point *tp,
                                       struct perf_probe_point *pp)

But just a trivial style issue. :)

-- 
Masami HIRAMATSU
2nd Research Dept.
Hitachi, Ltd., Systems Development Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCHv10 2.6.35-rc6-tip 0/14] Uprobes Patches, Srikar Dronamraju, (Tue Jul 27, 4:08 am)

[PATCHv10 2.6.35-rc6-tip 1/14] mm: Move replace_page() / ..., Srikar Dronamraju, (Tue Jul 27, 4:09 am)

[PATCHv10 2.6.35-rc6-tip 2/14] uprobes: Breakpoint insert ..., Srikar Dronamraju, (Tue Jul 27, 4:09 am)

[PATCHv10 2.6.35-rc6-tip 3/14] uprobes: Slot allocation f ..., Srikar Dronamraju, (Tue Jul 27, 4:09 am)

[PATCHv10 2.6.35-rc6-tip 4/14] uprobes: x86 specific func ..., Srikar Dronamraju, (Tue Jul 27, 4:09 am)

[PATCHv10 2.6.35-rc6-tip 5/14] uprobes: Uprobes (un)regis ..., Srikar Dronamraju, (Tue Jul 27, 4:09 am)

[PATCHv10 2.6.35-rc6-tip 6/14] uprobes: X86 support for U ..., Srikar Dronamraju, (Tue Jul 27, 4:10 am)

[PATCHv10 2.6.35-rc6-tip 7/14] uprobes: Uprobes Documentation, Srikar Dronamraju, (Tue Jul 27, 4:10 am)

[PATCHv10 2.6.35-rc6-tip 8/14] trace: Extract out common ..., Srikar Dronamraju, (Tue Jul 27, 4:10 am)

[PATCHv10 2.6.35-rc6-tip 9/14] trace: uprobes trace_event ..., Srikar Dronamraju, (Tue Jul 27, 4:10 am)

[PATCHv10 2.6.35-rc6-tip 10/14] perf: rename common field ..., Srikar Dronamraju, (Tue Jul 27, 4:10 am)

[PATCHv10 2.6.35-rc6-tip 11/14] perf: perf interface for ..., Srikar Dronamraju, (Tue Jul 27, 4:11 am)

[PATCHv10 2.6.35-rc6-tip 12/14] perf: Add third parameter ..., Srikar Dronamraju, (Tue Jul 27, 4:11 am)

[PATCHv10 2.6.35-rc6-tip 13/14] [RFC] perf: Show Potentia ..., Srikar Dronamraju, (Tue Jul 27, 4:11 am)

[PATCHv10 2.6.35-rc6-tip 14/14] [RFC] perf: show function ..., Srikar Dronamraju, (Tue Jul 27, 4:11 am)

Re: [PATCHv10 2.6.35-rc6-tip 8/14] trace: Extract out com ..., Masami Hiramatsu, (Tue Jul 27, 6:22 am)

Re: [PATCHv10 2.6.35-rc6-tip 8/14] trace: Extract out com ..., Srikar Dronamraju, (Tue Jul 27, 7:03 am)

Re: [PATCHv10 2.6.35-rc6-tip 8/14] trace: Extract out com ..., Masami Hiramatsu, (Wed Jul 28, 12:56 am)

Re: [PATCHv10 2.6.35-rc6-tip 9/14] trace: uprobes trace_e ..., Masami Hiramatsu, (Wed Jul 28, 10:04 pm)

Re: [PATCHv10 2.6.35-rc6-tip 9/14] trace: uprobes trace_e ..., Srikar Dronamraju, (Wed Jul 28, 10:20 pm)

Re: [PATCHv10 2.6.35-rc6-tip 10/14] perf: rename common f ..., Masami Hiramatsu, (Thu Jul 29, 4:51 am)

Re: [PATCHv10 2.6.35-rc6-tip 11/14] perf: perf interface ..., Masami Hiramatsu, (Thu Jul 29, 5:01 am)

Re: [PATCHv10 2.6.35-rc6-tip 11/14] perf: perf interface ..., Srikar Dronamraju, (Thu Jul 29, 7:11 am)

Re: [PATCHv10 2.6.35-rc6-tip 10/14] perf: rename common f ..., Srikar Dronamraju, (Thu Jul 29, 7:13 am)

Re: [PATCHv10 2.6.35-rc6-tip 9/14] trace: uprobes trace_e ..., Srikar Dronamraju, (Thu Jul 29, 7:15 am)

Re: [PATCHv10 2.6.35-rc6-tip 8/14] trace: Extract out com ..., Srikar Dronamraju, (Thu Jul 29, 7:16 am)

Re: [PATCHv10 2.6.35-rc6-tip 10/14] perf: rename common f ..., Arnaldo Carvalho de Melo, (Thu Jul 29, 12:42 pm)

Re: [PATCHv10 2.6.35-rc6-tip 11/14] perf: perf interface ..., Arnaldo Carvalho de Melo, (Fri Jul 30, 12:19 pm)

Re: [PATCHv10 2.6.35-rc6-tip 11/14] perf: perf interface ..., Srikar Dronamraju, (Fri Jul 30, 7:57 pm)

Re: [PATCHv10 2.6.35-rc6-tip 11/14] perf: perf interface ..., Arnaldo Carvalho de Melo, (Sat Jul 31, 12:30 pm)

Re: [PATCHv10 2.6.35-rc6-tip 11/14] perf: perf interface ..., Masami Hiramatsu, (Sun Aug 1, 6:51 pm)

Re: [PATCHv10 2.6.35-rc6-tip 9/14] trace: uprobes trace_e ..., Frederic Weisbecker, (Sun Aug 1, 7:20 pm)

Re: [PATCHv10 2.6.35-rc6-tip 9/14] trace: uprobes trace_e ..., Frederic Weisbecker, (Sun Aug 1, 7:28 pm)

Re: [PATCHv10 2.6.35-rc6-tip 9/14] trace: uprobes trace_e ..., Masami Hiramatsu, (Sun Aug 1, 8:45 pm)

Re: [PATCHv10 2.6.35-rc6-tip 9/14] trace: uprobes trace_e ..., Srikar Dronamraju, (Sun Aug 1, 11:46 pm)

Re: [PATCHv10 2.6.35-rc6-tip 9/14] trace: uprobes trace_e ..., Frederic Weisbecker, (Mon Aug 2, 12:46 am)

[tip:perf/core] perf probe: Rename common fields/functions ..., tip-bot for Srikar D ..., (Mon Aug 2, 12:53 am)

Re: [PATCHv10 2.6.35-rc6-tip 9/14] trace: uprobes trace_e ..., Ingo Molnar, (Mon Aug 2, 12:56 am)

Re: [PATCHv10 2.6.35-rc6-tip 9/14] trace: uprobes trace_e ..., Frederic Weisbecker, (Mon Aug 2, 12:58 am)

Re: [PATCHv10 2.6.35-rc6-tip 9/14] trace: uprobes trace_e ..., Christoph Hellwig, (Mon Aug 2, 1:00 am)

Re: [PATCHv10 2.6.35-rc6-tip 9/14] trace: uprobes trace_e ..., Masami Hiramatsu, (Mon Aug 2, 2:29 am)

Re: [PATCHv10 2.6.35-rc6-tip 9/14] trace: uprobes trace_e ..., Christoph Hellwig, (Mon Aug 2, 2:36 am)

Re: [PATCHv10 2.6.35-rc6-tip 11/14] perf: perf interface ..., Srikar Dronamraju, (Mon Aug 2, 5:27 am)

[PATCH] perf: expose event__process function, Srikar Dronamraju, (Mon Aug 2, 5:38 am)

[PATCHv10 2.6.35-rc6-tip 11/14] perf: perf interface for ..., Srikar Dronamraju, (Mon Aug 2, 5:41 am)

Re: [PATCHv10 2.6.35-rc6-tip 11/14] perf: perf interface ..., Arnaldo Carvalho de Melo, (Mon Aug 2, 7:56 am)

[tip:perf/core] perf: expose event__process function, tip-bot for Srikar D ..., (Thu Aug 5, 1:01 am)

Re: [PATCHv10 2.6.35-rc6-tip 12/14] perf: Add third param ..., Arnaldo Carvalho de Melo, (Thu Aug 5, 8:19 am)

Re: [PATCHv10 2.6.35-rc6-tip 12/14] perf: Add third param ..., Arnaldo Carvalho de Melo, (Thu Aug 5, 8:20 am)

Re: [PATCHv10 2.6.35-rc6-tip 12/14] perf: Add third param ..., Srikar Dronamraju, (Thu Aug 5, 8:23 am)

Navigation

Popular discussions


linux-kernel:
Greg KH	Og dreams of kernels
Jens Axboe