login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2010
»
July
»
22
Re: [PATCH 1/6] Driver core: Fix potential memory leak
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Greg KH
Subject:
Re: [PATCH 1/6] Driver core: Fix potential memory leak
Date: Thursday, July 22, 2010 - 4:39 pm
On Thu, Jul 22, 2010 at 03:09:01PM -0700, Patrick Pannuto wrote:
quoted text
> In both of the 'goto out' cases, priv has already > been allocated and assigned to bus->p. We reset > bus->p to NULL, but neglect to free bus->p > > Signed-off-by: Patrick Pannuto <ppannuto@codeaurora.org> > --- > drivers/base/bus.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/base/bus.c b/drivers/base/bus.c > index 12eec3f..eb1b7fa 100644 > --- a/drivers/base/bus.c > +++ b/drivers/base/bus.c > @@ -945,8 +945,8 @@ bus_devices_fail: > bus_remove_file(bus, &bus_attr_uevent); > bus_uevent_fail: > kset_unregister(&bus->p->subsys); > - kfree(bus->p); > out: > + kfree(bus->p);
This fix is already in my tree. thanks, greg k-h --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
Possible memory leaks on driver core error paths
, Patrick Pannuto
, (Thu Jul 22, 3:09 pm)
[PATCH 1/6] Driver core: Fix potential memory leak
, Patrick Pannuto
, (Thu Jul 22, 3:09 pm)
[PATCH 2/6] Driver core: Fix memory leak on bus_register e ...
, Patrick Pannuto
, (Thu Jul 22, 3:09 pm)
[PATCH 3/6] Driver core: Fix memory leak on class_register ...
, Patrick Pannuto
, (Thu Jul 22, 3:09 pm)
[PATCH 4/6] Driver core: Fix memory leak on sysdev_class_r ...
, Patrick Pannuto
, (Thu Jul 22, 3:09 pm)
[PATCH 5/6] ocfs2: Fix memory leak on mlog_sys_init error path
, Patrick Pannuto
, (Thu Jul 22, 3:09 pm)
[PATCH 6/6] kobj: Fix memory leak on error path of kset_cr ...
, Patrick Pannuto
, (Thu Jul 22, 3:09 pm)
Re: [PATCH 1/6] Driver core: Fix potential memory leak
, Greg KH
, (Thu Jul 22, 4:39 pm)
Re: [PATCH 2/6] Driver core: Fix memory leak on bus_regist ...
, Greg KH
, (Thu Jul 22, 4:41 pm)
Re: [PATCH 3/6] Driver core: Fix memory leak on class_regi ...
, Greg KH
, (Thu Jul 22, 4:41 pm)
Re: [PATCH 4/6] Driver core: Fix memory leak on sysdev_cla ...
, Greg KH
, (Thu Jul 22, 4:41 pm)
Re: [PATCH 6/6] kobj: Fix memory leak on error path of kse ...
, Greg KH
, (Thu Jul 22, 4:43 pm)
Re: [PATCH 5/6] ocfs2: Fix memory leak on mlog_sys_init er ...
, Pekka Enberg
, (Fri Jul 23, 10:01 am)
Re: [PATCH 2/6] Driver core: Fix memory leak on bus_regist ...
, Patrick Pannuto
, (Fri Jul 23, 6:19 pm)
Re: [PATCH 2/6] Driver core: Fix memory leak on bus_regist ...
, Patrick Pannuto
, (Fri Jul 23, 6:48 pm)
Re: [PATCH 2/6] Driver core: Fix memory leak on bus_regist ...
, Greg KH
, (Mon Jul 26, 4:45 pm)
Re: [PATCH 2/6] Driver core: Fix memory leak on bus_regist ...
, Greg KH
, (Mon Jul 26, 5:00 pm)
Navigation
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Michael Trimarchi
Re: [PATCH] VFS: make file->f_pos access atomic on 32bit arch
Miklos Szeredi
[patch 14/15] vfs: more path_permission() conversions
Serge E. Hallyn
Re: [RFC v5][PATCH 7/8] Infrastructure for shared objects
Bernd Schmidt
Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Takashi Iwai
[PATCH 2/2] input: Add LED support to Synaptics device
git
:
Junio C Hamano
Re: mingw, windows, crlf/lf, and git
Eyvind Bernhardsen
Re: Where has "git ls-remote" reference pattern matching gone?
Shawn O. Pearce
Re: Switching from CVS to GIT
Todd Zullinger
Re: [PATCH 2/2] send-email: rfc2047-quote subject lines with non-ascii characters
Santi Béjar
Re: How to use git-fmt-merge-msg?
linux-netdev
:
Ramkrishna Vepa
[net-2.6 PATCH 1/10] Neterion: New driver: Driver help file
Mark Anthony
invitation / inquiry
Ingo Molnar
Re: [PATCH 08/16] dma-debug: add core checking functions
David Miller
Re: [PATCH 1/3] f_phonet: dev_kfree_skb instead of dev_kfree_skb_any in TX callback
Sascha Hauer
[PATCH 03/12] fec: do not typedef struct types
git-commits-head
:
Linux Kernel Mailing List
amba: struct device - replace bus_id with dev_name(), dev_set_name()
Linux Kernel Mailing List
MIPS: Yosemite: Convert SMP startup lock to arch spinlock.
Linux Kernel Mailing List
ARM: S5PC100: IRQ and timer
Linux Kernel Mailing List
davinci: edma: clear interrupt status for interrupt enabled channels only
Linux Kernel Mailing List
x86, mm, kprobes: fault.c, simplify notify_page_fault()
openbsd-misc
:
Daniel A. Ramaley
Re: [semi-OT] Can anyone recommend an OpenBSD-compatible colour laser printer?
Matthias Kilian
Re: can't get vesa @ 1280x800 or nv
Tobias Ulmer
Re: Problem after upgrade 4.5 to 4.6: ERR M
Philip Guenther
Re: SIGCHLD and libpthread.so
J.C. Roberts
Re: [semi-OT] Can anyone recommend an OpenBSD-compatible colour laser printer?
Colocation donated by:
Syndicate