[PATCH 16/49] memblock: Make memblock_find_region() out of memblock_alloc_region()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Yinghai Lu
Date: Monday, July 19, 2010 - 4:56 pm

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>

This function will be used to locate a free area to put the new memblock
arrays when attempting to resize them. memblock_alloc_region() is gone,
the two callsites now call memblock_add_region().

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
 mm/memblock.c |   20 +++++++++-----------
 1 files changed, 9 insertions(+), 11 deletions(-)

diff --git a/mm/memblock.c b/mm/memblock.c
index 21ba089..eae3dc0 100644
--- a/mm/memblock.c
+++ b/mm/memblock.c
@@ -309,8 +309,8 @@ static phys_addr_t memblock_align_up(phys_addr_t addr, phys_addr_t size)
 	return (addr + (size - 1)) & ~(size - 1);
 }
 
-static phys_addr_t __init memblock_alloc_region(phys_addr_t start, phys_addr_t end,
-					   phys_addr_t size, phys_addr_t align)
+static phys_addr_t __init memblock_find_region(phys_addr_t start, phys_addr_t end,
+					  phys_addr_t size, phys_addr_t align)
 {
 	phys_addr_t base, res_base;
 	long j;
@@ -318,12 +318,8 @@ static phys_addr_t __init memblock_alloc_region(phys_addr_t start, phys_addr_t e
 	base = memblock_align_down((end - size), align);
 	while (start <= base) {
 		j = memblock_overlaps_region(&memblock.reserved, base, size);
-		if (j < 0) {
-			/* this area isn't reserved, take it */
-			if (memblock_add_region(&memblock.reserved, base, size) < 0)
-				base = ~(phys_addr_t)0;
+		if (j < 0)
 			return base;
-		}
 		res_base = memblock.reserved.regions[j].base;
 		if (res_base < size)
 			break;
@@ -356,8 +352,9 @@ static phys_addr_t __init memblock_alloc_nid_region(struct memblock_region *mp,
 
 		this_end = memblock_nid_range(start, end, &this_nid);
 		if (this_nid == nid) {
-			phys_addr_t ret = memblock_alloc_region(start, this_end, size, align);
-			if (ret != ~(phys_addr_t)0)
+			phys_addr_t ret = memblock_find_region(start, this_end, size, align);
+			if (ret != ~(phys_addr_t)0 &&
+			    memblock_add_region(&memblock.reserved, ret, size) >= 0)
 				return ret;
 		}
 		start = this_end;
@@ -432,8 +429,9 @@ phys_addr_t __init __memblock_alloc_base(phys_addr_t size, phys_addr_t align, ph
 		if (memblocksize < size)
 			continue;
 		base = min(memblockbase + memblocksize, max_addr);
-		res_base = memblock_alloc_region(memblockbase, base, size, align);
-		if (res_base != ~(phys_addr_t)0)
+		res_base = memblock_find_region(memblockbase, base, size, align);
+		if (res_base != ~(phys_addr_t)0 &&
+		    memblock_add_region(&memblock.reserved, res_base, size) >= 0)
 			return res_base;
 	}
 	return 0;
-- 
1.6.4.2

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH -v25 00/49] Use memblock with x86, Yinghai Lu, (Mon Jul 19, 4:56 pm)
[PATCH 02/49] x86,mm: fix 32bit numa sparsemem, Yinghai Lu, (Mon Jul 19, 4:56 pm)
[PATCH 16/49] memblock: Make memblock_find_region() out of ..., Yinghai Lu, (Mon Jul 19, 4:56 pm)
[PATCH 33/49] memblock: Add memblock_find_in_range(), Yinghai Lu, (Mon Jul 19, 4:56 pm)
[PATCH 40/49] memblock: Add find_memory_core_early(), Yinghai Lu, (Mon Jul 19, 4:56 pm)
[PATCH 45/49] x86: Use memblock to replace early_res, Yinghai Lu, (Mon Jul 19, 4:56 pm)
[PATCH 47/49] x86: Remove not used early_res code, Yinghai Lu, (Mon Jul 19, 4:56 pm)
[PATCH 49/49] x86: remove old bootmem code, Yinghai Lu, (Mon Jul 19, 4:56 pm)
Re: [PATCH -v25 00/49] Use memblock with x86, Linus Torvalds, (Mon Jul 19, 5:14 pm)
Re: [PATCH -v25 00/49] Use memblock with x86, Yinghai Lu, (Mon Jul 19, 5:35 pm)
Re: [PATCH -v25 00/49] Use memblock with x86, H. Peter Anvin, (Tue Jul 20, 11:29 am)