drivers/gpu/drm/radeon/r600_blit.c: fix possible NULL pointer derefernce

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Alexander Y. Fomichev
Date: Monday, July 19, 2010 - 2:42 pm

This patch fix possible NULL pointer dereference when
r600_prepare_blit_copy tries to fill dev_priv->blit_vb->file_priv
without check of dev_priv->blit_vb. dev_priv->blit_vb should be
filled by r600_nomm_get_vb but latest can fail with EAGAIN.
Addresses: https://bugzilla.kernel.org/show_bug.cgi?id=16375

---
 drivers/gpu/drm/radeon/r600_blit.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/gpu/drm/radeon/r600_blit.c b/drivers/gpu/drm/radeon/r600_blit.c
index f4fb88e..0df4a2b 100644
--- a/drivers/gpu/drm/radeon/r600_blit.c
+++ b/drivers/gpu/drm/radeon/r600_blit.c
@@ -541,6 +541,8 @@ r600_prepare_blit_copy(struct drm_device *dev, struct drm_file *file_priv)
        DRM_DEBUG("\n");

        r600_nomm_get_vb(dev);
+       if (!dev_priv->blit_vb)
+               return;

        dev_priv->blit_vb->file_priv = file_priv;

--
1.7.1.1
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
drivers/gpu/drm/radeon/r600_blit.c: fix possible NULL poin ..., Alexander Y. Fomichev, (Mon Jul 19, 2:42 pm)
Re: drivers/gpu/drm/radeon/r600_blit.c: fix possible NULL ..., Alexander Y. Fomichev, (Tue Jul 20, 1:13 pm)
Re: drivers/gpu/drm/radeon/r600_blit.c: fix possible NULL ..., Alexander Y. Fomichev, (Tue Jul 20, 2:07 pm)
Re: drivers/gpu/drm/radeon/r600_blit.c: fix possible NULL ..., Alexander Y. Fomichev, (Wed Jul 21, 12:06 am)