login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2010
»
July
»
19
Re: [PATCH 2/3] [fs/sysv] V7: Adjust sanity checks for some volumes
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Christoph Hellwig
Subject:
Re: [PATCH 2/3] [fs/sysv] V7: Adjust sanity checks for some volumes
Date: Monday, July 19, 2010 - 7:54 am
> if (fs16_to_cpu(sbi, v7sb->s_nfree) > V7_NICFREE ||
quoted text
> fs16_to_cpu(sbi, v7sb->s_ninode) > V7_NICINOD || > - fs32_to_cpu(sbi, v7sb->s_time) == 0) > - goto failed; > + fs32_to_cpu(sbi, v7sb->s_fsize) > V7_MAXSIZE) > + return 0;
Ok.
quoted text
> v7i = (struct sysv_inode *)(bh2->b_data + 64); > if ((fs16_to_cpu(sbi, v7i->i_mode) & ~0777) != S_IFDIR || > (fs32_to_cpu(sbi, v7i->i_size) == 0) || > - (fs32_to_cpu(sbi, v7i->i_size) & 017) != 0) > + (fs32_to_cpu(sbi, v7i->i_size) & 017) > + (fs32_to_cpu(sbi, v7i->i_size) > V7_NFILES * > + sizeof (struct sysv_dir_entry))) {
Maybe I'm missing something, but without and additional || on the first line you added this doesn't look like it will compile. --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
Re: A few V7 fs improvements
, Christoph Hellwig
, (Mon Jul 19, 7:53 am)
Re: [PATCH 1/3] [fs/sysv] Add v7 alias
, Christoph Hellwig
, (Mon Jul 19, 7:53 am)
Re: [PATCH 2/3] [fs/sysv] V7: Adjust sanity checks for som ...
, Christoph Hellwig
, (Mon Jul 19, 7:54 am)
Re: [PATCH 3/3] [fs/sysv] V7: Add support for non-PDP11 v7 ...
, Christoph Hellwig
, (Mon Jul 19, 7:58 am)
Re: A few V7 fs improvements
, Bill Davidsen
, (Mon Jul 19, 9:10 am)
A few V7 fs improvements
, Lubomir Rintel
, (Mon Jul 19, 10:16 am)
[PATCH 1/3] [fs/sysv] Add v7 alias
, Lubomir Rintel
, (Mon Jul 19, 10:16 am)
[PATCH 2/3] [fs/sysv] V7: Adjust sanity checks for some vo ...
, Lubomir Rintel
, (Mon Jul 19, 10:16 am)
[PATCH 3/3] [fs/sysv] V7: Add support for non-PDP11 v7 fil ...
, Lubomir Rintel
, (Mon Jul 19, 10:16 am)
Re: [PATCH 2/3] [fs/sysv] V7: Adjust sanity checks for som ...
, Lubomir Rintel
, (Tue Jul 20, 3:31 am)
Re: [PATCH 3/3] [fs/sysv] V7: Add support for non-PDP11 v7 ...
, Lubomir Rintel
, (Tue Jul 20, 3:41 am)
[PATCH] V7: Adjust sanity checks for some volumes
, Lubomir Rintel
, (Wed Jul 21, 6:11 pm)
Re: [PATCH 3/3] [fs/sysv] V7: Add support for non-PDP11 v7 ...
, Lubomir Rintel
, (Wed Jul 21, 6:17 pm)
[PATCH] V7: Add support for non-PDP11 v7 filesystems
, Lubomir Rintel
, (Wed Jul 21, 6:18 pm)
Re: [PATCH 3/3] [fs/sysv] V7: Add support for non-PDP11 v7 ...
, Al Viro
, (Sat Jul 24, 6:51 am)
Re: A few V7 fs improvements
, Artem Bityutskiy
, (Sat Jul 24, 10:23 pm)
[PATCH] V7: Add support for non-PDP11 v7 filesystems
, Lubomir Rintel
, (Sun Jul 25, 3:59 pm)
Re: [PATCH] V7: Add support for non-PDP11 v7 filesystems
, Randy Dunlap
, (Sun Jul 25, 5:26 pm)
Re: [PATCH] V7: Add support for non-PDP11 v7 filesystems
, Andrew Morton
, (Mon Jul 26, 4:52 pm)
Re: [PATCH] V7: Add support for non-PDP11 v7 filesystems
, Lubomir Rintel
, (Mon Jul 26, 5:19 pm)
Re: [PATCH] V7: Add support for non-PDP11 v7 filesystems
, Andrew Morton
, (Mon Jul 26, 5:29 pm)
Navigation
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Michael Trimarchi
Re: [PATCH] VFS: make file->f_pos access atomic on 32bit arch
Miklos Szeredi
[patch 14/15] vfs: more path_permission() conversions
Serge E. Hallyn
Re: [RFC v5][PATCH 7/8] Infrastructure for shared objects
Bernd Schmidt
Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Takashi Iwai
[PATCH 2/2] input: Add LED support to Synaptics device
git
:
Junio C Hamano
Re: mingw, windows, crlf/lf, and git
Eyvind Bernhardsen
Re: Where has "git ls-remote" reference pattern matching gone?
Shawn O. Pearce
Re: Switching from CVS to GIT
Todd Zullinger
Re: [PATCH 2/2] send-email: rfc2047-quote subject lines with non-ascii characters
Santi Béjar
Re: How to use git-fmt-merge-msg?
linux-netdev
:
Ramkrishna Vepa
[net-2.6 PATCH 1/10] Neterion: New driver: Driver help file
Mark Anthony
invitation / inquiry
Ingo Molnar
Re: [PATCH 08/16] dma-debug: add core checking functions
David Miller
Re: [PATCH 1/3] f_phonet: dev_kfree_skb instead of dev_kfree_skb_any in TX callback
Sascha Hauer
[PATCH 03/12] fec: do not typedef struct types
git-commits-head
:
Linux Kernel Mailing List
amba: struct device - replace bus_id with dev_name(), dev_set_name()
Linux Kernel Mailing List
MIPS: Yosemite: Convert SMP startup lock to arch spinlock.
Linux Kernel Mailing List
ARM: S5PC100: IRQ and timer
Linux Kernel Mailing List
davinci: edma: clear interrupt status for interrupt enabled channels only
Linux Kernel Mailing List
x86, mm, kprobes: fault.c, simplify notify_page_fault()
openbsd-misc
:
Daniel A. Ramaley
Re: [semi-OT] Can anyone recommend an OpenBSD-compatible colour laser printer?
Matthias Kilian
Re: can't get vesa @ 1280x800 or nv
Tobias Ulmer
Re: Problem after upgrade 4.5 to 4.6: ERR M
Philip Guenther
Re: SIGCHLD and libpthread.so
J.C. Roberts
Re: [semi-OT] Can anyone recommend an OpenBSD-compatible colour laser printer?
Colocation donated by:
Syndicate