Re: [Intel-gfx] [PATCH] drm/i915: Selectively enable self-reclaim

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linus Torvalds
Date: Sunday, July 18, 2010 - 9:59 am

On Sun, Jul 18, 2010 at 7:27 AM, M. Vefa Bicakci <bicave@superonline.com> wrote:

Thanks for the extensive testing, and I'm committing the one-liner to
add it, and cc'ing it to stable. I'm pretty certain that there is
something overly fragile in the i915 driver that this flag makes so
much of a difference, but at the same time I'm actually happy that
it's that reclaimable flag, because at least that one was always the
"conceptually makes sense" one.

So I suspected it would be some low-memory issue and the flag that
woudl turn out to matter would be the NOMEMALLOC one, but I'm happy to
have been wrong. Adding __GFP_RECLAIMABLE is sane, although I really
would like to understand why the i915 driver apparently cares so
deeply about the allocation/freeing patterns.

But whatever. Thanks again for being such a thorough tester,

                        Linus
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
OOM-Killer kills too much with 2.6.32.2, Roman Jarosz, (Thu Jan 14, 6:15 am)
Re: OOM-Killer kills too much with 2.6.32.2, David Rientjes, (Fri Jan 22, 5:40 pm)
Re: OOM-Killer kills too much with 2.6.32.2, KOSAKI Motohiro, (Sun Jan 24, 6:48 pm)
Re: OOM-Killer kills too much with 2.6.32.2, Roman Jarosz, (Mon Jan 25, 1:47 pm)
Re: OOM-Killer kills too much with 2.6.32.2, Roman Jarosz, (Mon Jan 25, 3:12 pm)
Re: OOM-Killer kills too much with 2.6.32.2, KOSAKI Motohiro, (Mon Jan 25, 10:19 pm)
Re: OOM-Killer kills too much with 2.6.32.2, A Rojas, (Tue Jan 26, 12:51 am)
Re: OOM-Killer kills too much with 2.6.32.2, Roman Jarosz, (Tue Jan 26, 2:06 am)
Re: OOM-Killer kills too much with 2.6.32.2, KOSAKI Motohiro, (Tue Jan 26, 4:07 am)
Re: OOM-Killer kills too much with 2.6.32.2, Chris Wilson, (Tue Jan 26, 5:33 am)
Re: OOM-Killer kills too much with 2.6.32.2, KOSAKI Motohiro, (Tue Jan 26, 6:03 am)
Re: OOM-Killer kills too much with 2.6.32.2, Chris Wilson, (Tue Jan 26, 6:18 am)
Re: OOM-Killer kills too much with 2.6.32.2, Roman Jarosz, (Tue Jan 26, 6:41 am)
Re: OOM-Killer kills too much with 2.6.32.2, Pekka Enberg, (Tue Jan 26, 6:57 am)
Re: OOM-Killer kills too much with 2.6.32.2, Michael Reinelt, (Tue Jan 26, 6:59 am)
Re: OOM-Killer kills too much with 2.6.32.2, Michael Reinelt, (Tue Jan 26, 7:07 am)
Re: OOM-Killer kills too much with 2.6.32.2, KOSAKI Motohiro, (Tue Jan 26, 5:14 pm)
Re: OOM-Killer kills too much with 2.6.32.2, KOSAKI Motohiro, (Tue Jan 26, 5:50 pm)
Re: OOM-Killer kills too much with 2.6.32.2, Roman Jarosz, (Wed Jan 27, 2:53 am)
Re: OOM-Killer kills too much with 2.6.32.2, Pekka Enberg, (Wed Jan 27, 2:56 am)
Re: OOM-Killer kills too much with 2.6.32.2, Linus Torvalds, (Wed Jan 27, 3:55 am)
Re: OOM-Killer kills too much with 2.6.32.2, Pekka Enberg, (Wed Jan 27, 4:12 am)
[PATCH] drm/i915: Selectively enable self-reclaim, Chris Wilson, (Wed Jan 27, 4:14 am)
Re: [PATCH] drm/i915: Selectively enable self-reclaim, Pekka Enberg, (Wed Jan 27, 4:20 am)
Re: [PATCH] drm/i915: Selectively enable self-reclaim, Michael Reinelt, (Wed Jan 27, 4:30 am)
Re: [PATCH] drm/i915: Selectively enable self-reclaim, KOSAKI Motohiro, (Wed Jan 27, 4:50 am)
Re: [PATCH] drm/i915: Selectively enable self-reclaim, Linus Torvalds, (Wed Jan 27, 5:16 am)
Re: [PATCH] drm/i915: Selectively enable self-reclaim, Linus Torvalds, (Wed Jan 27, 5:28 am)
[PATCH] drm/i915: Selectively enable self-reclaim, Chris Wilson, (Wed Jan 27, 8:25 am)
Re: [PATCH] drm/i915: Selectively enable self-reclaim, Linus Torvalds, (Wed Jan 27, 9:09 am)
Re: [PATCH] drm/i915: Selectively enable self-reclaim, Chris Wilson, (Wed Jan 27, 10:14 am)
Re: [PATCH] drm/i915: Selectively enable self-reclaim, Linus Torvalds, (Wed Jan 27, 10:19 am)
Re: [PATCH] drm/i915: Selectively enable self-reclaim, Roman Jarosz, (Wed Jan 27, 2:03 pm)
Re: [PATCH] drm/i915: Selectively enable self-reclaim, Michael Reinelt, (Wed Jan 27, 8:15 pm)
Re: [PATCH] drm/i915: Selectively enable self-reclaim, Willy Tarreau, (Wed Jan 27, 11:37 pm)
Re: [PATCH] drm/i915: Selectively enable self-reclaim, Roman Jarosz, (Thu Jan 28, 11:21 am)
Re: [Intel-gfx] [PATCH] drm/i915: Selectively enable self- ..., Linus Torvalds, (Sun Jul 18, 9:59 am)