[PATCH 05/11] tulip: formatting of pointers in printk()

Previous thread: [PATCH 04/11] xtavnet/setup.c: formatting of pointers in printk() by Kulikov Vasiliy on Wednesday, July 14, 2010 - 11:02 am. (1 message)

Next thread: [PATCH 06/11] tulip: formatting of pointers in printk() by Kulikov Vasiliy on Wednesday, July 14, 2010 - 11:03 am. (1 message)
From: Kulikov Vasiliy
Date: Wednesday, July 14, 2010 - 11:02 am

Use %p instead of %08x in printk().

Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
---
 drivers/net/tulip/tulip_core.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/tulip/tulip_core.c b/drivers/net/tulip/tulip_core.c
index 03e96b9..14e5312 100644
--- a/drivers/net/tulip/tulip_core.c
+++ b/drivers/net/tulip/tulip_core.c
@@ -596,10 +596,10 @@ static void tulip_tx_timeout(struct net_device *dev)
 					pr_cont(" %02x", buf[j]);
 			pr_cont(" j=%d\n", j);
 		}
-		printk(KERN_DEBUG "  Rx ring %08x: ", (int)tp->rx_ring);
+		printk(KERN_DEBUG "  Rx ring %p: ", tp->rx_ring);
 		for (i = 0; i < RX_RING_SIZE; i++)
 			pr_cont(" %08x", (unsigned int)tp->rx_ring[i].status);
-		printk(KERN_DEBUG "  Tx ring %08x: ", (int)tp->tx_ring);
+		printk(KERN_DEBUG "  Tx ring %p: ", tp->tx_ring);
 		for (i = 0; i < TX_RING_SIZE; i++)
 			pr_cont(" %08x", (unsigned int)tp->tx_ring[i].status);
 		pr_cont("\n");
-- 
1.7.0.4

--

From: David Miller
Date: Wednesday, July 14, 2010 - 3:07 pm

From: Kulikov Vasiliy <segooon@gmail.com>

Since patch #5 and #6 are doing the same change to different
files in the same driver, I combined them into one commit.

There is no need to split things up with so much granularity.
If it's all in the same driver, doing the same transformation,
keep it all in one patch.

Thanks.
--

From: Kyle McMartin
Date: Thursday, July 15, 2010 - 5:46 pm

Thanks, Dave!

--Kyle
--

Previous thread: [PATCH 04/11] xtavnet/setup.c: formatting of pointers in printk() by Kulikov Vasiliy on Wednesday, July 14, 2010 - 11:02 am. (1 message)

Next thread: [PATCH 06/11] tulip: formatting of pointers in printk() by Kulikov Vasiliy on Wednesday, July 14, 2010 - 11:03 am. (1 message)