Re: [patch 134/149] x86, paravirt: Add a global synchronization point for pvclock

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Jeremy Fitzhardinge
Date: Wednesday, July 14, 2010 - 10:19 am

On 07/13/2010 05:15 PM, Linus Torvalds wrote:

Sure, I completely agree.  At the moment the docs say "asm volatile
guarantees nothing", and we can work with that.  So long as we don't
expect asm volatile to mean anything more (ie, magic semantics involving
reordering), everyone is happy.

BTW, gcc 2.95's docs do mention "asm volatile" having an effect on
ordering, which is probably where the notion came from: "If you write an
`asm' instruction with no outputs, GNU CC [...] not delete the
instruction or move it outside of loops. [...] you should write the
`volatile' keyword to prevent future versions of GNU CC from moving the
instruction around within a core region".  Lucky we never relied on
that, right?  Right?

    J
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [patch 134/149] x86, paravirt: Add a global synchroniz ..., Jeremy Fitzhardinge, (Tue Jul 13, 11:21 am)
Re: [patch 134/149] x86, paravirt: Add a global synchroniz ..., Jeremy Fitzhardinge, (Tue Jul 13, 4:49 pm)
Re: [patch 134/149] x86, paravirt: Add a global synchroniz ..., Jeremy Fitzhardinge, (Wed Jul 14, 10:19 am)
Re: [patch 134/149] x86, paravirt: Add a global synchroniz ..., Jeremy Fitzhardinge, (Wed Jul 14, 10:34 am)
Re: [patch 134/149] x86, paravirt: Add a global synchroniz ..., Jeremy Fitzhardinge, (Wed Jul 14, 10:57 am)
Re: [patch 134/149] x86, paravirt: Add a global synchroniz ..., Jeremy Fitzhardinge, (Wed Jul 14, 11:15 am)
Re: [patch 134/149] x86, paravirt: Add a global synchroniz ..., Jeremy Fitzhardinge, (Wed Jul 14, 1:40 pm)
Re: [patch 134/149] x86, paravirt: Add a global synchroniz ..., Jeremy Fitzhardinge, (Wed Jul 14, 1:58 pm)
Re: [patch 134/149] x86, paravirt: Add a global synchroniz ..., Jeremy Fitzhardinge, (Wed Jul 14, 2:11 pm)
Re: [patch 134/149] x86, paravirt: Add a global synchroniz ..., Jeremy Fitzhardinge, (Wed Jul 14, 2:11 pm)
Re: [patch 134/149] x86, paravirt: Add a global synchroniz ..., Jeremy Fitzhardinge, (Wed Jul 14, 2:11 pm)
Re: [patch 134/149] x86, paravirt: Add a global synchroniz ..., Jeremy Fitzhardinge, (Tue Jul 27, 10:46 am)
xchg() and cmpxchg(), H. Peter Anvin, (Tue Jul 27, 4:57 pm)
[tip:x86/urgent] x86: Add memory modify constraints to xch ..., tip-bot for H. Peter ..., (Tue Jul 27, 10:33 pm)
[tip:x86/asm] x86, asm: Clean up and simplify <asm/cmpxchg.h>, tip-bot for H. Peter ..., (Wed Jul 28, 4:28 pm)
[tip:x86/asm] x86, asm: Move cmpxchg emulation code to arc ..., tip-bot for H. Peter ..., (Thu Jul 29, 1:12 pm)
[tip:x86/asm] x86, asm: Merge cmpxchg_486_u64() and cmpxch ..., tip-bot for H. Peter ..., (Thu Jul 29, 1:13 pm)
Re: [tip:x86/urgent] x86: Add memory modify constraints to ..., Jeremy Fitzhardinge, (Mon Aug 2, 4:51 pm)
Re: [stable] [tip:x86/urgent] x86: Add memory modify const ..., Tomáš Janoušek, (Thu Sep 9, 12:53 pm)
Re: [stable] [tip:x86/urgent] x86: Add memory modify const ..., Tomáš Janoušek, (Thu Sep 9, 2:09 pm)
Re: [stable] [tip:x86/urgent] x86: Add memory modify const ..., Tomáš Janoušek, (Fri Sep 10, 6:10 am)
Re: [stable] [tip:x86/urgent] x86: Add memory modify const ..., Tomáš Janoušek, (Fri Sep 24, 12:17 am)