login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2010
»
July
»
14
Re: sound/oss-msnd-pinnacle: ioctl needs the inode
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Takashi Iwai
Subject:
Re: sound/oss-msnd-pinnacle: ioctl needs the inode
Date: Wednesday, July 14, 2010 - 6:15 am
At Wed, 14 Jul 2010 15:11:39 +0200, Arnd Bergmann wrote:
quoted text
> > This broke in sound/oss: convert to unlocked_ioctl, when I missed one > of the ioctl functions still using the inode pointer. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied now. Thanks. Takashi
quoted text
> --- > On Tuesday 13 July 2010, Randy Dunlap wrote: > > On Tue, 13 Jul 2010 14:40:07 +1000 Stephen Rothwell wrote: > > > > > Hi all, > > > > > > Not unexpectedly, we got some conflicts with the arm defconfig files > > > today ... > > > > > > sound/oss/msnd_pinnacle.c:644:error: 'inode' undeclared (first use in this function) > > > > Sorry about that, my fault. Please apply. > > I checked all the other files I touched in the same patch, they either did > not have this problem, or I had done it correctly. > > --- a/sound/oss/msnd_pinnacle.c > +++ b/sound/oss/msnd_pinnacle.c > @@ -641,7 +641,7 @@ static int mixer_ioctl(unsigned int cmd, unsigned long arg) > > static long dev_ioctl(struct file *file, unsigned int cmd, unsigned long arg) > { > - int minor = iminor(inode); > + int minor = iminor(file->f_path.dentry->d_inode); > int ret; > > if (cmd == OSS_GETVERSION) { >
--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
linux-next: Tree for July 13
, Stephen Rothwell
, (Mon Jul 12, 9:40 pm)
Re: linux-next: Tree for July 13 (sound/oss/msnd_pinnacle)
, Randy Dunlap
, (Tue Jul 13, 10:36 am)
sound/oss-msnd-pinnacle: ioctl needs the inode
, Arnd Bergmann
, (Wed Jul 14, 6:11 am)
Re: sound/oss-msnd-pinnacle: ioctl needs the inode
, Takashi Iwai
, (Wed Jul 14, 6:15 am)
Re: sound/oss-msnd-pinnacle: ioctl needs the inode
, Randy Dunlap
, (Wed Jul 14, 8:54 am)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Pekka Enberg
Re: latest -git: suspend: unable to handle kernel paging request (was Re: no_conso...
Trent Waddington
Re: Gaming Interface
Dan Carpenter
Re: [patch] dma-debug: off by one issue
Adrian McMenamin
time_after - what on earth???
Paul E. McKenney
Re: [PATCH, RFC] v4 scalable classic RCU implementation
git
:
Stephen R. van den Berg
Re: [RFC] origin link for cherry-pick and revert
Christian Stimming
git-gui: Fix broken revert confirmation.
Junio C Hamano
Re: git-svnimport
Mark Burton
Re: [PATCH] builtin-branch: highlight current remote branches with an asterisk
Anuj Gakhar
Git Architecture Question
linux-netdev
:
Nick Piggin
Re: Kernel WARNING: at net/core/dev.c:1330 __netif_schedule+0x2c/0x98()
Daniel Lezcano
getsockopt(TCP_DEFER_ACCEPT) value change
David Miller
Re: 2.6.27.18: bnx2/tg3: BUG: "scheduling while atomic" trying to ifenslave a seco...
Ingo Molnar
Re: [regression] nf_iterate(), BUG: unable to handle kernel NULL pointer dereference
Gerrit Renker
[PATCH 37/37] dccp: Debugging functions for feature negotiation
openbsd-misc
:
Christophe Rioux
Implementation example of snmp
Ryan McBride
Re: Packets Per Second Limit?
Nick Holland
Re: booting openbsd on eee without cd-rom
Jacob Yocom-Piatt
Re: Same shit all over again
Bryan Irvine
Re: OpenBSD 4.7 Released, May 19 2010
git-commits-head
:
Linux Kernel Mailing List
ath9k_htc: Allocate URBs properly
Linux Kernel Mailing List
markup_oops.pl: fix for faulting instruction in the first line of a range
Linux Kernel Mailing List
cpumask: make irq_set_affinity() take a const struct cpumask
Linux Kernel Mailing List
ARM: 5670/1: bcmring: add default configuration for bcmring arch
Linux Kernel Mailing List
ahci: Workaround HW bug for SB600/700 SATA controller PMP support
Colocation donated by:
Syndicate