sound/oss-msnd-pinnacle: ioctl needs the inode

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Arnd Bergmann
Date: Wednesday, July 14, 2010 - 6:11 am

This broke in sound/oss: convert to unlocked_ioctl, when I missed one
of the ioctl functions still using the inode pointer.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
On Tuesday 13 July 2010, Randy Dunlap wrote:

Sorry about that, my fault. Please apply.

I checked all the other files I touched in the same patch, they either did
not have this problem, or I had done it correctly.

--- a/sound/oss/msnd_pinnacle.c
+++ b/sound/oss/msnd_pinnacle.c
@@ -641,7 +641,7 @@ static int mixer_ioctl(unsigned int cmd, unsigned long arg)
 
 static long dev_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
 {
-	int minor = iminor(inode);
+	int minor = iminor(file->f_path.dentry->d_inode);
 	int ret;
 
 	if (cmd == OSS_GETVERSION) {
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
linux-next: Tree for July 13, Stephen Rothwell, (Mon Jul 12, 9:40 pm)
sound/oss-msnd-pinnacle: ioctl needs the inode, Arnd Bergmann, (Wed Jul 14, 6:11 am)
Re: sound/oss-msnd-pinnacle: ioctl needs the inode, Takashi Iwai, (Wed Jul 14, 6:15 am)
Re: sound/oss-msnd-pinnacle: ioctl needs the inode, Randy Dunlap, (Wed Jul 14, 8:54 am)