Re: kmemleak, cpu usage jump out of nowhere

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Catalin Marinas
Date: Wednesday, July 14, 2010 - 2:47 am

On Wed, 2010-07-14 at 09:27 +0100, Zeno Davatz wrote:


It looks like NO_BOOTMEM is enabled. You can try the attached patch (I
need to post it again on the list).


kmemleak: Add support for NO_BOOTMEM configurations

From: Catalin Marinas <catalin.marinas@arm.com>

With commits 08677214 and 59be5a8e, alloc_bootmem()/free_bootmem() and
friends use the early_res functions for memory management when
NO_BOOTMEM is enabled. This patch adds the kmemleak calls in the
corresponding code paths for bootmem allocations.

Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
Cc: Yinghai Lu <yinghai@kernel.org>
Cc: H. Peter Anvin <hpa@zytor.com>
---
 mm/bootmem.c    |    2 ++
 mm/page_alloc.c |    1 +
 2 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/mm/bootmem.c b/mm/bootmem.c
index 58c66cc..0747f68 100644
--- a/mm/bootmem.c
+++ b/mm/bootmem.c
@@ -435,6 +435,7 @@ void __init free_bootmem_node(pg_data_t *pgdat, unsigned long physaddr,
 {
 #ifdef CONFIG_NO_BOOTMEM
 	free_early(physaddr, physaddr + size);
+	kmemleak_free_part(__va(physaddr), size);
 #else
 	unsigned long start, end;
 
@@ -460,6 +461,7 @@ void __init free_bootmem(unsigned long addr, unsigned long size)
 {
 #ifdef CONFIG_NO_BOOTMEM
 	free_early(addr, addr + size);
+	kmemleak_free_part(__va(addr), size);
 #else
 	unsigned long start, end;
 
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 431214b..f29f00b 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -3659,6 +3659,7 @@ void * __init __alloc_memory_core_early(int nid, u64 size, u64 align,
 		ptr = phys_to_virt(addr);
 		memset(ptr, 0, size);
 		reserve_early_without_check(addr, addr + size, "BOOTMEM");
+		kmemleak_alloc(ptr, size, 1, 0);
 		return ptr;
 	}
 


-- 
Catalin

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
kmemleak, cpu usage jump out of nowhere, Zeno Davatz, (Tue Jul 13, 11:12 pm)
Re: kmemleak, cpu usage jump out of nowhere, Pekka Enberg, (Wed Jul 14, 1:05 am)
Re: kmemleak, cpu usage jump out of nowhere, Zeno Davatz, (Wed Jul 14, 1:27 am)
Re: kmemleak, cpu usage jump out of nowhere, Damien Wyart, (Wed Jul 14, 1:31 am)
Re: kmemleak, cpu usage jump out of nowhere, Zeno Davatz, (Wed Jul 14, 1:34 am)
Re: kmemleak, cpu usage jump out of nowhere, Pekka Enberg, (Wed Jul 14, 1:38 am)
Re: kmemleak, cpu usage jump out of nowhere, Zeno Davatz, (Wed Jul 14, 1:54 am)
Re: kmemleak, cpu usage jump out of nowhere, Pekka Enberg, (Wed Jul 14, 1:57 am)
Re: kmemleak, cpu usage jump out of nowhere, Catalin Marinas, (Wed Jul 14, 2:47 am)
Re: kmemleak, cpu usage jump out of nowhere, Pekka Enberg, (Wed Jul 14, 2:55 am)
Re: kmemleak, cpu usage jump out of nowhere, Catalin Marinas, (Wed Jul 14, 2:57 am)
Re: kmemleak, cpu usage jump out of nowhere, Zeno Davatz, (Wed Jul 14, 3:00 am)
Re: kmemleak, cpu usage jump out of nowhere, Zeno Davatz, (Wed Jul 14, 3:04 am)
Re: kmemleak, cpu usage jump out of nowhere, Catalin Marinas, (Wed Jul 14, 4:54 am)
Re: kmemleak, cpu usage jump out of nowhere, Zeno Davatz, (Wed Jul 14, 4:59 am)
Re: kmemleak, cpu usage jump out of nowhere, Catalin Marinas, (Thu Jul 15, 7:58 am)
Re: kmemleak, cpu usage jump out of nowhere, Zeno Davatz, (Thu Jul 15, 8:15 am)
Re: kmemleak, cpu usage jump out of nowhere, Pekka Enberg, (Thu Jul 15, 8:54 am)
Re: kmemleak, cpu usage jump out of nowhere, Damien Wyart, (Thu Jul 15, 9:28 am)
Re: kmemleak, cpu usage jump out of nowhere, Damien Wyart, (Thu Jul 15, 12:16 pm)
Re: kmemleak, cpu usage jump out of nowhere, Pekka Enberg, (Thu Jul 15, 12:50 pm)
Re: kmemleak, cpu usage jump out of nowhere, Damien Wyart, (Thu Jul 15, 1:00 pm)
Re: kmemleak, cpu usage jump out of nowhere, Zeno Davatz, (Thu Jul 15, 1:38 pm)
Re: kmemleak, cpu usage jump out of nowhere, Pekka Enberg, (Thu Jul 15, 1:50 pm)
Re: kmemleak, cpu usage jump out of nowhere, Pekka Enberg, (Thu Jul 15, 1:52 pm)
Re: kmemleak, cpu usage jump out of nowhere, Zeno Davatz, (Thu Jul 15, 1:57 pm)
Re: kmemleak, cpu usage jump out of nowhere, Zeno Davatz, (Fri Jul 16, 12:12 am)
Re: kmemleak, cpu usage jump out of nowhere, Zeno Davatz, (Fri Jul 16, 12:29 am)
Re: kmemleak, cpu usage jump out of nowhere, Zeno Davatz, (Fri Jul 16, 12:37 am)
Re: kmemleak, cpu usage jump out of nowhere, Pekka Enberg, (Fri Jul 16, 12:50 am)
Re: kmemleak, cpu usage jump out of nowhere, Zeno Davatz, (Fri Jul 16, 2:17 am)
Re: kmemleak, cpu usage jump out of nowhere, Pekka Enberg, (Fri Jul 16, 2:32 am)
Re: kmemleak, cpu usage jump out of nowhere, Zeno Davatz, (Fri Jul 16, 2:42 am)
Re: kmemleak, cpu usage jump out of nowhere, Zeno Davatz, (Fri Jul 16, 2:47 am)
Re: kmemleak, cpu usage jump out of nowhere, Yinghai Lu, (Fri Jul 16, 11:27 am)
Re: kmemleak, cpu usage jump out of nowhere, Zeno Davatz, (Fri Jul 16, 1:29 pm)
Re: kmemleak, cpu usage jump out of nowhere, Yinghai Lu, (Fri Jul 16, 1:59 pm)
Re: kmemleak, cpu usage jump out of nowhere, Zeno Davatz, (Sat Jul 17, 1:46 am)
Re: kmemleak, cpu usage jump out of nowhere, Peter Zijlstra, (Tue Aug 3, 2:05 am)
Re: kmemleak, cpu usage jump out of nowhere, Zeno Davatz, (Tue Aug 3, 2:11 am)
Re: kmemleak, cpu usage jump out of nowhere, damien.wyart, (Tue Aug 3, 2:15 am)
Re: kmemleak, cpu usage jump out of nowhere, Zeno Davatz, (Tue Aug 3, 2:18 am)
Re: kmemleak, cpu usage jump out of nowhere, Damien Wyart, (Fri Aug 20, 2:32 am)
Re: kmemleak, cpu usage jump out of nowhere, Peter Zijlstra, (Fri Aug 20, 2:40 am)