linux-kernel mailing list

FromSubjectsort iconDate
Nicolas Kaiser
[PATCH] drm/mga: fixed brace, macro and spacing coding s ...
Fixed brace, macro and spacing coding style issues. Signed-off-by: Nicolas Kaiser <nikai@nikai.net> --- drivers/gpu/drm/mga/mga_dma.c | 99 +++++++++------------ drivers/gpu/drm/mga/mga_drv.c | 4 +- drivers/gpu/drm/mga/mga_drv.h | 187 +++++++++++++++++++-------------------- drivers/gpu/drm/mga/mga_irq.c | 9 +- drivers/gpu/drm/mga/mga_state.c | 47 +++++----- drivers/gpu/drm/mga/mga_warp.c | 4 +- 6 files changed, 165 insertions(+), 185 deletions(-) diff --git ...
Jul 11, 4:46 pm 2010
Peter Crosthwaite
UIO: munmap bug for boot time allocated memory
[Resend of earlier email due to first email bouncing] Hi, I'm currently experiencing a kernel bug when munmap'ing a UIO memory region. The uio memory region is a large (up to 48MB) buffer allocated by a UIO driver at boot time using alloc_bootmem_low_pages(). The idea is once the large buffer is allocated, devices can DMA directly to the buffer which is user space accessible. The system is tested as working, with the DMA device being able to fill the buffer and user space being able to see ...
Jul 11, 4:51 pm 2010
Western Union
(No subject)
Good day, My working partner has helped me to send your first payment of US$7,500 to you as instructed by Mr. David Cameron and will keep sending you US$7,500 twice a week until the payment of (US$360,000) is completed within six months and here is the information below: MONEY TRANSFER CONTROL NUMBER (MTCN): 5229059427 SENDER'S NAME: Mr. Mark Daniel AMOUNT: US$7,500 To track your funds forward Western Union Money Transfer agent your Full Names and Mobile Number via Email ...
Jul 11, 2:42 pm 2010
Noah McNallie
Re:
On Sun, 11 Jul 2010 17:42:42 -0400, Western Union <dmaza@efn.uncor.edu> we're gonna be rich guys! whata ya say we donate it to the linux team.... noah --
Jul 11, 3:23 pm 2010
Yinghai Lu
[PATCH] x86: Setup early console as early as possible
Analyze "console=uart8250,io,0x3f8,115200n8" in i386_start_kernel/x86_64_start_kernel, and call setup_early_serial8250_console() to init early serial console. only can handle io port kind of 8250. because mmio need ioremap. Signed-off-by: Yinghai Lu <yinghai@kernel.org> --- arch/x86/include/asm/setup.h | 1 + arch/x86/kernel/head.c | 32 ++++++++++++++++++++++++++++++++ arch/x86/kernel/head32.c | 2 ++ arch/x86/kernel/head64.c | 11 +++++++++++ kernel/printk.c ...
Jul 11, 2:44 pm 2010
Arnd Bergmann
[PATCH 00/12] autoconvert trivial BKL users to private mutex
This is a repost of an earlier patch to remove those users of the big kernel lock that can be converted to a mutex using a simple script. The only use of the BKL is in file operations that are called without any other lock, so the new mutex is the top-level serialization and cannot introduce any AB-BA deadlock. Please apply to the respective maintainer trees if the patches look good. Arnd Bergmann (12): staging: autoconvert trivial BKL users to private mutex isdn: autoconvert ...
Jul 11, 2:18 pm 2010
Arnd Bergmann
[PATCH 03/12] scsi: autoconvert trivial BKL users to pri ...
All these files use the big kernel lock in a trivial way to serialize their private file operations, typically resulting from an earlier semi-automatic pushdown from VFS. None of these drivers appears to want to lock against other code, and they all use the BKL as the top-level lock in their file operations, meaning that there is no lock-order inversion problem. Consequently, we can remove the BKL completely, replacing it with a per-file mutex in every case. Using a scripted approach means ...
Jul 11, 2:18 pm 2010
Arnd Bergmann
[PATCH 05/12] usb: autoconvert trivial BKL users to priv ...
All these files use the big kernel lock in a trivial way to serialize their private file operations, typically resulting from an earlier semi-automatic pushdown from VFS. None of these drivers appears to want to lock against other code, and they all use the BKL as the top-level lock in their file operations, meaning that there is no lock-order inversion problem. Consequently, we can remove the BKL completely, replacing it with a per-file mutex in every case. Using a scripted approach means ...
Jul 11, 2:18 pm 2010
Arnd Bergmann
[PATCH 06/12] net: autoconvert trivial BKL users to priv ...
All these files use the big kernel lock in a trivial way to serialize their private file operations, typically resulting from an earlier semi-automatic pushdown from VFS. None of these drivers appears to want to lock against other code, and they all use the BKL as the top-level lock in their file operations, meaning that there is no lock-order inversion problem. Consequently, we can remove the BKL completely, replacing it with a per-file mutex in every case. Using a scripted approach means ...
Jul 11, 2:18 pm 2010
Arnd Bergmann
[PATCH 12/12] drivers: autoconvert trivial BKL users to ...
All these files use the big kernel lock in a trivial way to serialize their private file operations, typically resulting from an earlier semi-automatic pushdown from VFS. None of these drivers appears to want to lock against other code, and they all use the BKL as the top-level lock in their file operations, meaning that there is no lock-order inversion problem. Consequently, we can remove the BKL completely, replacing it with a per-file mutex in every case. Using a scripted approach means ...
Jul 11, 2:19 pm 2010
Arnd Bergmann
[PATCH 09/12] mtd: autoconvert trivial BKL users to priv ...
All these files use the big kernel lock in a trivial way to serialize their private file operations, typically resulting from an earlier semi-automatic pushdown from VFS. None of these drivers appears to want to lock against other code, and they all use the BKL as the top-level lock in their file operations, meaning that there is no lock-order inversion problem. Consequently, we can remove the BKL completely, replacing it with a per-file mutex in every case. Using a scripted approach means ...
Jul 11, 2:19 pm 2010
Arnd Bergmann
[PATCH 04/12] media: autoconvert trivial BKL users to pr ...
All these files use the big kernel lock in a trivial way to serialize their private file operations, typically resulting from an earlier semi-automatic pushdown from VFS. None of these drivers appears to want to lock against other code, and they all use the BKL as the top-level lock in their file operations, meaning that there is no lock-order inversion problem. Consequently, we can remove the BKL completely, replacing it with a per-file mutex in every case. Using a scripted approach means ...
Jul 11, 2:18 pm 2010
Arnd Bergmann
[PATCH 10/12] mac: autoconvert trivial BKL users to priv ...
All these files use the big kernel lock in a trivial way to serialize their private file operations, typically resulting from an earlier semi-automatic pushdown from VFS. None of these drivers appears to want to lock against other code, and they all use the BKL as the top-level lock in their file operations, meaning that there is no lock-order inversion problem. Consequently, we can remove the BKL completely, replacing it with a per-file mutex in every case. Using a scripted approach means ...
Jul 11, 2:19 pm 2010
Arnd Bergmann
[PATCH 07/12] cris: autoconvert trivial BKL users to pri ...
All these files use the big kernel lock in a trivial way to serialize their private file operations, typically resulting from an earlier semi-automatic pushdown from VFS. None of these drivers appears to want to lock against other code, and they all use the BKL as the top-level lock in their file operations, meaning that there is no lock-order inversion problem. Consequently, we can remove the BKL completely, replacing it with a per-file mutex in every case. Using a scripted approach means ...
Jul 11, 2:18 pm 2010
Arnd Bergmann
[PATCH 11/12] ipmi: autoconvert trivial BKL users to pri ...
All these files use the big kernel lock in a trivial way to serialize their private file operations, typically resulting from an earlier semi-automatic pushdown from VFS. None of these drivers appears to want to lock against other code, and they all use the BKL as the top-level lock in their file operations, meaning that there is no lock-order inversion problem. Consequently, we can remove the BKL completely, replacing it with a per-file mutex in every case. Using a scripted approach means ...
Jul 11, 2:19 pm 2010
Arnd Bergmann
[PATCH 01/12] staging: autoconvert trivial BKL users to ...
All these files use the big kernel lock in a trivial way to serialize their private file operations, typically resulting from an earlier semi-automatic pushdown from VFS. None of these drivers appears to want to lock against other code, and they all use the BKL as the top-level lock in their file operations, meaning that there is no lock-order inversion problem. Consequently, we can remove the BKL completely, replacing it with a per-file mutex in every case. Using a scripted approach means ...
Jul 11, 2:18 pm 2010
Arnd Bergmann
[PATCH 08/12] sbus: autoconvert trivial BKL users to pri ...
All these files use the big kernel lock in a trivial way to serialize their private file operations, typically resulting from an earlier semi-automatic pushdown from VFS. None of these drivers appears to want to lock against other code, and they all use the BKL as the top-level lock in their file operations, meaning that there is no lock-order inversion problem. Consequently, we can remove the BKL completely, replacing it with a per-file mutex in every case. Using a scripted approach means ...
Jul 11, 2:18 pm 2010
Arnd Bergmann
[PATCH 02/12] isdn: autoconvert trivial BKL users to pri ...
All these files use the big kernel lock in a trivial way to serialize their private file operations, typically resulting from an earlier semi-automatic pushdown from VFS. None of these drivers appears to want to lock against other code, and they all use the BKL as the top-level lock in their file operations, meaning that there is no lock-order inversion problem. Consequently, we can remove the BKL completely, replacing it with a per-file mutex in every case. Using a scripted approach means ...
Jul 11, 2:18 pm 2010
Torsten Kaiser
Regression 2.6.34->2.6.35-rc4: radeaon KMS an RS690 broken
I just tried 2.6.35-rc4 to see, if a different bug is fixed, but noted that this kernel will only boot with radeon.modeset=0. If KMS is active the display turns off and the system is completely dead, not even SysRq+B is working. I build a new kernel with the radeon driver as a module and inserted it by hand via ssh. The ssh session, I was using has this output: ariolc drm # insmod ./drm_kms_helper.ko ariolc drm # insmod ttm/ttm.ko ariolc drm # insmod radeon/radeon.ko Segmentation ...
Jul 11, 12:56 pm 2010
Cyril Jayaprakash
[PATCH] pmcraid : Remove unwanted cast for void * pointers
From: Cyril Jayaprakash <cyril.jayaprakash@gmail.com> Patch to remove unwanted cast for void * pointers. Signed-off-by: Cyril Jayaprakash <cyril.jayaprakash@gmail.com> --- drivers/scsi/pmcraid.c | 7 +++---- 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c index c44e4ab..bd0b5a0 100644 --- a/drivers/scsi/pmcraid.c +++ b/drivers/scsi/pmcraid.c @@ -3324,8 +3324,7 @@ static int pmcraid_chr_open(struct inode *inode, struct file ...
Jul 11, 12:12 pm 2010
Torsten Kaiser
Regression 2.6.33->2.6.34: OOPS at boot, kmalloc corruption?
Trying to upgrade my system from 2.6.33 to 2.6.34, I can't get it to boot. All tries used CONFIG_SLUB=y The gentoo version of 2.6.34 generated an OOPS during network initialization and then came to a stop. (It seemed that all processes got stuck waiting on some locks.) As in this instance the system was able to start the syslog, I was able to capture the complete OOPS: Jul 3 05:51:43 ariolc kernel: [ 32.674367] BUG: unable to handle kernel NULL pointer dereference at 0000000000000003 Jul ...
Jul 11, 11:55 am 2010
Tejun Heo
[RFC PATCH] x86-64: software IRQ masking and handling
Hello, This is something suggested by Rusty Russell a while ago. It makes IRQ masking a software switch like preemption or softirq enable/disable. Hardware interrupt masking (cli/sti) and delivery are decoupled from actual IRQ handling. IRQ disabling is done by single instruction moving 1 to a percpu variable. Enabling is similar but it should check whether there's any pending interrupt to handle. This change greatly reduces the number of hardware IRQ masking manipulations. cli/sti ...
Jul 11, 11:01 am 2010
Ingo Molnar
Re: [RFC PATCH] x86-64: software IRQ masking and handling
Not just Nehalem but on various AMD CPUs it was in the below-10-cycles range for years. Note that we tried this in -rt, but the pain and trouble (and, often, code bloat) was not worth the trouble. The PUSHF/POPF/CLI/STI instructions are really simple and short in the instruction stream - without disturbing other registers. Ingo --
Jul 11, 12:26 pm 2010
Linus Torvalds
Re: [RFC PATCH] x86-64: software IRQ masking and handling
You need to show some real improvement on real hardware. I can't really care less about qemu behavior. If the emulator is bad at emulating cli/sti, that's a qemu problem. But if it actually helps on real hardware (which is possible), that would be interesting. However, quite frankly, I doubt you can really measure it on any bigger load. cli-sti do not tend to be all that expensive any more (on a P4 it's probably noticeable, I doubt it shows up very much anywhere else). --
Jul 11, 1:29 pm 2010
Steven Rostedt
Re: [RFC PATCH] x86-64: software IRQ masking and handling
I have seen some hits with cli-sti. I was considering swapping all preempt_disable() with local_irq_save() in ftrace, but hackbench showed a 30% performance degradation when I did that. The test was simply to switch the stack tracer from disabling preemption to disabling IRQs, and I got this as a result: <This is from my IRC log on OFTC #linux-rt IRC discussing this with Thomas Gleixner> Feb 04 10:02:27 <rostedt> running hackbench 10 times with stack tracer using preempt ...
Jul 11, 3:03 pm 2010
Patrick J. LoPresti
[PATCH 1/2] JBD2: Allow feature checks before journal recovery
Before we start accessing a huge (> 16 TiB) OCFS2 volume, we need to confirm that its journal supports 64-bit offsets. So we need to check the journal's feature bits before recovering the journal. This is not possible with JBD2 at present, because the journal superblock (where the feature bits reside) is not loaded from disk until the journal is recovered. This patch loads the journal superblock in jbd2_journal_check_used_features() if it has not already been loaded, allowing us to check ...
Jul 11, 10:03 am 2010
samwise
[PATCHv1] USB HID DRIVERS: Enable HID_QUIRK_MULTI_INPUT ...
From: Peter Edwards <samwise@bagshot-row.org> Patch for linux-2.6.35-rc4 mainline kernel to enable Paul Qureshi's Retro Adapter [http://keio.dk/retroadapter.html], an open source USB device which allows controllers and joysticks from classic computers and consoles to work on modern PCs, to appear as two separate devices under Linux. Signed-off-by: Peter Edwards <samwise@bagshot-row.org> Acked-by: Paul Qureshi <retro@world3.net> --- This is a first patch submission following ...
Jul 11, 9:45 am 2010
Jiri Kosina
Re: [PATCHv1] USB HID DRIVERS: Enable HID_QUIRK_MULTI_IN ...
Hi Peter, your mail client damaged (whitespaces and line-wrapping) the patch. I have fixed it up and applied the patch to my tree, but please keep that in mind for your further patch submissions. Thanks! -- Jiri Kosina SUSE Labs, Novell Inc. --
Jul 11, 1:12 pm 2010
Kevin Winchester
[PATCH] acpi: Fix warning: 'us_to_pm_timer_ticks' define ...
Using: gcc (GCC) 4.5.0 20100610 (prerelease) The following warning is seen: drivers/acpi/processor_idle.c:83:12: warning: ‘us_to_pm_timer_ticks’ defined but not used This is because us_to_pm_timer_ticks is only used when CONFIG_ACPI_PROCFS is defined. Fix the warning by moving the function definition into the #ifdef CONFIG_ACPI_PROCFS block. Signed-off-by: Kevin Winchester <kjwinchester@gmail.com> --- drivers/acpi/processor_idle.c | 10 ++++++---- 1 files changed, 6 ...
Jul 11, 9:14 am 2010
William Pitcock
Re: stable? quality assurance?
2.6.32.16 (possibly 2.6.32.15) has a regression where it is unusable as a Xen domU. I would say 2.6.32.12 is the best choice since who knows what other regressions there are in .16. William --
Jul 11, 8:58 am 2010
Eric Dumazet
Re: stable? quality assurance?
Yea, strictly speaking, you can be sure no kernel will be bug free, ever. This is why I said "probably more stable" ;) --
Jul 11, 9:34 am 2010
Michael S. Tsirkin
[PATCHv3] extensions: libxt_CHECKSUM extension
This adds a `CHECKSUM' target, which can be used in the iptables mangle table. You can use this target to compute and fill in the checksum in a packet that lacks a checksum. This is particularly useful, if you need to work around old applications such as dhcp clients, that do not work well with checksum offloads, but don't want to disable checksum offload in your device. The problem happens in the field with virtualized applications. For reference, see Red Hat bz 605555, as well ...
Jul 11, 8:14 am 2010
Michael S. Tsirkin
[PATCHv2] netfilter: add CHECKSUM target
This adds a `CHECKSUM' target, which can be used in the iptables mangle table. You can use this target to compute and fill in the checksum in a packet that lacks a checksum. This is particularly useful, if you need to work around old applications such as dhcp clients, that do not work well with checksum offloads, but don't want to disable checksum offload in your device. The problem happens in the field with virtualized applications. For reference, see Red Hat bz 605555, as well ...
Jul 11, 8:06 am 2010
Michael S. Tsirkin
[PATCHv2] extensions: libxt_CHECKSUM extension
This adds a `CHECKSUM' target, which can be used in the iptables mangle table. You can use this target to compute and fill in the checksum in a packet that lacks a checksum. This is particularly useful, if you need to work around old applications such as dhcp clients, that do not work well with checksum offloads, but don't want to disable checksum offload in your device. The problem happens in the field with virtualized applications. For reference, see Red Hat bz 605555, as well ...
Jul 11, 8:08 am 2010
Joe Perches
[PATCH] scripts/checkpatch.pl: Add strict test of logica ...
I don't remember that discussion. Link? Here's a patch that makes it a "--strict" option for those who really want to get all the style checking options. It also corrects a spelling typo. Signed-off-by: Joe Perches <joe@perches.com --- diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index bd88f11..f0a4c25 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2180,6 +2180,11 @@ sub process { ERROR("space required before the open parenthesis '('\n" . ...
Jul 11, 11:57 am 2010
Guenter Roeck
Re: [PATCH] scripts/checkpatch.pl: Add strict test of lo ...
Same issue hit me twice now, so it isn't as if nobody cares. For my part, I don't care where to put the &&. But I would like to have a means to get beyond the basic stuff before submitting my patches, to give reviewers an opportunity to find the _real_ problems in my code. Guenter --
Jul 11, 2:15 pm 2010
Guenter Roeck
[PATCH v2] hwmon: Add support for JEDEC JC 42.4 complian ...
Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com> --- v2 changes: - Added support for MAX6604 - Added support for TSE2002B3 and TS3000B3 (IDT) - Define Manufacturer IDs separately and only once per manufacturer - Rearranged chip defines to alphabetic order --- Documentation/hwmon/jc42 | 97 ++++++++ MAINTAINERS | 7 + drivers/hwmon/Kconfig | 11 + drivers/hwmon/Makefile | 1 + drivers/hwmon/jc42.c | 594 ...
Jul 11, 7:53 am 2010
Joe Perches
Re: [PATCH v2] hwmon: Add support for JEDEC JC 42.4 comp ...
Decidedly trivial: Kernel style seems to prefer having logical tests at end of line rather than start of line. Maybe this bit would be more readable with a temporary: for (i = 0; i < ARRAY_SIZE(jc42_chips); i++) { struct jc42_chips *chip = &jc42_chips[i]; if (manid == chip->manid && (devid & chip->devid_mask) == chip->devid) { strlcpy(info->type, "jc42", I2C_NAME_SIZE); return 0; } } --
Jul 11, 8:31 am 2010
Jean Delvare
Re: [PATCH v2] hwmon: Add support for JEDEC JC 42.4 comp ...
Please, not again. This has been discussed before, with the conclusion that nobody really cares and we don't want to add pointless warnings to checkpatch.pl, which in the end will just dissuade people from running the script and/or contributing to the kernel at all. -- Jean Delvare --
Jul 11, 9:21 am 2010
Guenter Roeck
Re: [PATCH v2] hwmon: Add support for JEDEC JC 42.4 comp ...
Ok. Would be nice to have checkpatch.pl complain about it, though, Agreed. I'll change that. Thanks, Guenter --
Jul 11, 9:16 am 2010
Jean Delvare
Re: [PATCH] scripts/checkpatch.pl: Add strict test of lo ...
http://lkml.org/lkml/2009/12/5/65 It's the wrong way of writing patches. Separate things go to separate As long as it doesn't bug me by default, I don't really care. But I -- Jean Delvare --
Jul 11, 12:34 pm 2010
Joe Perches
Re: [PATCH] scripts/checkpatch.pl: Add strict test of lo ...
Though there are differences in opinion about what's important, I try to forget the trivial. Just ask my sweet wife... --
Jul 11, 12:52 pm 2010
Nicolas Kaiser
[PATCH] drm/via: fixed coding style issues, simplified return
Fixed brace, macro and spacing coding style issues. Simplified -if (ret) return ret; -return 0; +return ret; Signed-off-by: Nicolas Kaiser <nikai@nikai.net> --- drivers/gpu/drm/via/via_dma.c | 120 ++++++++++++++++-------------------- drivers/gpu/drm/via/via_dmablit.c | 71 ++++++++++------------ drivers/gpu/drm/via/via_dmablit.h | 8 +- drivers/gpu/drm/via/via_drv.h | 22 +++--- drivers/gpu/drm/via/via_irq.c | 13 ++-- drivers/gpu/drm/via/via_map.c | ...
Jul 11, 6:32 am 2010
Johannes Hirte
Re: kernel BUG at fs/btrfs/extent-tree.c:1353
It's getting worse. The /home partition is now affected too. I get the Oops on simple unmounting the fs. btrfsck gives me this output on this fs: btrfsck /dev/mapper/sdb3 leaf 123780497408 items 49 free space 271 generation 62207 owner 2 fs uuid 7f013285-88d8-452f-a139-7d44bffd14b6 chunk uuid 365526c9-e209-46a1-8963-3157306d9e05 item 0 key (123780108288 EXTENT_ITEM 4096) itemoff 3944 itemsize 51 extent refs 1 gen 45309 flags 2 tree block key (836797 6c ...
Jul 11, 5:28 am 2010
Alexander Clouter
Re: SNATed connections show as original ip in /proc/net/tcp
SNAT'ing locally sourced traffic? That's pretty nasty. Look into using 'ip rule' and a second routing table. http://lartc.org/howto/lartc.rpdb.html You will still need use iptables/MARK to do L4 (tcp/udp/etc) policy routing though, however now you can dump the ugly SNATing. Cheers -- Alexander Clouter .sigmonster says: Where do your SOCKS go when you lose them in th' WASHER? --
Jul 11, 7:30 am 2010
Noah McNallie
SNATed connections show as original ip in /proc/net/tcp
just as the topic describes. I'm currently doing SNAT to force some destination tcp ports to be routed through a specific route rather than the default route. To accomplish this I mark thoes packets with iptables, use 'ip' to specify marked packets via the specified route, and then use iptables to change their source address. one problem i've noticed is that in netstat (and hence /proc/net/tcp) the connections are shown as their original source. this causes problems with some things ...
Jul 11, 2:10 am 2010
Alexander Clouter
Re: SNATed connections show as original ip in /proc/net/tcp
I read your original post as saying were using iptables and the SNAT action, I am suggesting you use 'ip rule' to say "if x/tcp or y/udp using routing table 'alternative'". Might be easier if you actually put here the ip/iptables rules you are actually using? In the alternative routing table you can say to use a different source IP and/or alternative default gateway address (using something like 'ip route ... src ... via ... dev'). As I mentioned before, as 'ip rule' only knows about IP ...
Jul 11, 10:08 am 2010
Noah McNallie
Re: SNATed connections show as original ip in /proc/net/tcp
On Sun, 11 Jul 2010 10:30:25 -0400, Alexander Clouter <alex@digriz.org.uk> ok i'll stick it there i must have missed that browsing mailing lists last night... uhh as far as ip rule i am using that, that's how i match the packets with the firewall mark that need to go out a specific interface and to a specific route... i don't believe ip rule has any option to match packets based on destination port and change their source address and route them out any specific interface, or i'd be ...
Jul 11, 8:11 am 2010
Simon Horman
[patch v2.6 0/4] IPVS full NAT support + netfilter 'ipvs ...
This is a repost of a patch-series posted by Hannes Eder last September. This is v2 of the patch series and I don't see any outstanding objections to it in the mailing list archives. Series v2.6 fixes the arguments to of %pI4 Series v2.5 fixes some problems introduced in v2.4. Series v2.4 addresses all of the concerns that Patrick McHardy raised witht the v2.3 series. Malcolm Turnbull has offered to test this code so I'd like to get a Reviewed-by from him before the code gets merged. In ...
Jul 11, 2:03 am 2010
Simon Horman
[patch v2.6 1/4] netfilter: xt_ipvs (netfilter matcher f ...
From: Hannes Eder <heder@google.com> This implements the kernel-space side of the netfilter matcher xt_ipvs. [ minor fixes by Simon Horman <horms@verge.net.au> ] Signed-off-by: Hannes Eder <heder@google.com> Signed-off-by: Simon Horman <horms@verge.net.au> --- include/linux/netfilter/xt_ipvs.h | 25 ++++ net/netfilter/Kconfig | 10 + net/netfilter/Makefile | 1 net/netfilter/ipvs/ip_vs_proto.c | 1 net/netfilter/xt_ipvs.c | 189 ...
Jul 11, 2:03 am 2010
Simon Horman
[patch v2.6 2/4] IPVS: make friends with nf_conntrack
From: Hannes Eder <heder@google.com> Update the nf_conntrack tuple in reply direction, as we will see traffic from the real server (RIP) to the client (CIP). Once this is done we can use netfilters SNAT in POSTROUTING, especially with xt_ipvs, to do source NAT, e.g.: [ minor fixes by Simon Horman <horms@verge.net.au> ] Signed-off-by: Hannes Eder <heder@google.com> Signed-off-by: Simon Horman <horms@verge.net.au> --- net/netfilter/ipvs/Kconfig | 2 +- ...
Jul 11, 2:03 am 2010
Simon Horman
[patch v2.6 3/4] IPVS: make FTP work with full NAT support
From: Hannes Eder <heder@google.com> Use nf_conntrack/nf_nat code to do the packet mangling and the TCP sequence adjusting. The function 'ip_vs_skb_replace' is now dead code, so it is removed. To SNAT FTP, use something like: and for the data connections in passive mode: using '-m state --state RELATED' would also works. Make sure the kernel modules ip_vs_ftp, nf_conntrack_ftp, and nf_nat_ftp are loaded. [ up-port and minor fixes by Simon Horman <horms@verge.net.au> ...
Jul 11, 2:03 am 2010
Simon Horman
[patch v2.6 4/4] libxt_ipvs: user-space lib for netfilte ...
From: Hannes Eder <heder@google.com> The user-space library for the netfilter matcher xt_ipvs. [ trivial up-port by Simon Horman <horms@verge.net.au> ] Signed-off-by: Hannes Eder <heder@google.com> Acked-by: Simon Horman <horms@verge.net.au> configure.ac | 10 - extensions/libxt_ipvs.c | 365 +++++++++++++++++++++++++++++++++++++ extensions/libxt_ipvs.man | 24 ++ include/linux/netfilter/xt_ipvs.h | 25 +++ 4 files changed, 422 insertions(+), ...
Jul 11, 2:03 am 2010
Pekka Enberg
[PATCH v3] x86: Early-boot serial I/O support
This patch adds serial I/O support to very early boot printf(). It's useful for debugging boot code when running Linux under KVM, for example. The actual code was lifted from early printk. Cc: Cyrill Gorcunov <gorcunov@gmail.com> Cc: Ingo Molnar <mingo@redhat.com> Cc: Yinghai Lu <yinghai@kernel.org> Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi> --- v2 -> v3: - Remove 'memory' from cpu_relax as suggested by hpa arch/x86/boot/boot.h | 16 +++++++ arch/x86/boot/main.c | ...
Jul 11, 1:06 am 2010
Martin Steigerwald
stable? quality assurance?
Hi! 2.6.34 was a desaster for me: bug #15969 - patch was availble before 2.6.34 already, bug #15788, also reported with 2.6.34-rc2 already, as well as most important two complete lockups - well maybe just X.org and radeon KMS, I didn't start my second laptop to SSH into the locked up one - on my ThinkPad T42. I fixed the first one with the patch, but after the lockups I just downgraded to 2.6.33 again. I still actually *use* my machines for something else than hunting patches for ...
Jul 11, 12:18 am 2010
Heinz Diehl Jul 11, 10:04 am 2010
Martin Steigerwald
Re: stable? quality assurance?
Okay, not some, but one. -- Martin 'Helios' Steigerwald - http://www.Lichtvoll.de GPG: 03B0 0D6C 0040 0710 4AFA B82F 991B EAAC A599 84C7 --
Jul 11, 7:52 am 2010
Anca Emanuel
Re: stable? quality assurance?
Offtopic. I'm using Ubuntu 10.04 and kernel 2.6.35-rc1 from kernel.ubuntu.com Wonking fine (stable, but my webcam still not working). Using this https://wiki.ubuntu.com/KernelTeam/GitKernelBuild tutorial to compile the kernel. But no success (it finish the compile but no deb packages). I have done it from virtualbox some weeks ago, and grub can not mount. Is there any tutorial how to build the kernel for Ubuntu 10.04 ? Please test it yourself in (Ubuntu 10.04): sudo cfdisk result: Bad ...
Jul 11, 11:02 am 2010
Willy Tarreau
Re: stable? quality assurance?
Hi Martin, well, I'll try to do then :-) There were some threads in the past about kernel releases quality, where Linus explained why it could not be completely black or white. Among the things he explained, I remember that one of primary concern was the inability to slow down development. I mean, if he waits 2 more weeks for things to stabilize, then there will be two more weeks of crap^H^H^H^Hdevelopment merged in next merge window, so in fact this will just shift dates and not ...
Jul 11, 10:22 am 2010
Eric Dumazet
Re: stable? quality assurance?
Anybody running latest kernel on a production machine is living dangerously. Dont you already know that ? When 2.6.X is released, everybody knows it contains at least 100 bugs. It was true for all previous values of X, it will be true for all futures values. If you want to be safer, use a one year old kernel, with all stable patches in. Something like 2.6.32.16 : Its probably more stable than all 2.6.X kernels. If 2.6.33 runs OK on your machine, you are lucky, since ...
Jul 11, 1:39 am 2010
Lee Mathers
Re: stable? quality assurance?
Wow! First question what is a "desaster"? Second question, what makes you so important that you feel you can makes demands and comments as you did. If indeed these are production systems and you are an administrator of said production systems. I suggest you need to do a little more home work to expand your knowledge base. I would follow Eric's advice. It's sound advice and better yet it was free. Hope you have better luck in getting your systems running well. -- Sent from my ...
Jul 11, 6:56 am 2010
Martin Steigerwald
Re: stable? quality assurance?
Yes, and I indicated it above. But in my - naturally rather subjective I admit - perception the balance between stable and unstable from about 1 or 2 years ago has been lost. In my personal experience it has gotten much worse in the last time. To the extent that I skipped some major kernels versions completely. For example 2.6.30. Then why its still labeled "stable" on kernel.org? It is not. It is at most beta quality software. Its not more stable than KDE 4.0 wasn't stable, but at ...
Jul 11, 7:22 am 2010
Ted Ts'o
Re: stable? quality assurance?
So I tend to use -rc3, -rc4, and -rc5 kernels on my laptops, and when I find bugs, I report them and I help fix them. If more people did that, then the 2.6.X.0 releases would be more stable. But kernel development is a volunteer effort, so it's up to the volunteers to test and fix bugs during the rc4, -rc5 and -rc6 time frame. But if the work tails off, because the developers are busily working on new features for the new release, then past a certain point, delaying the release reaches a ...
Jul 11, 6:16 am 2010
Martin Steigerwald
Re: stable? quality assurance?
Hi Lee, For me freezing the machine or at least complete desktop randomly for example. And actually I said "for me" as you can reread on the bottom of Since when I do need to be considered to be important by you or anyone else to make comments? Actually I think I do not - this is still an open mailinglist, isn't it? And I won't waste my time with proofs that I contributed to free software here and there - also to kernel testing what for example Ingo Molnar could testify back in ...
Jul 11, 7:51 am 2010
Rafael J. Wysocki
Re: stable? quality assurance?
IMnshO it's not exactly fair to call them "stable" either. I tend to call them "major releases" which basically reflects what they are - events in the development process that each start a new merge window. Nothing more, either way. Rafael --
Jul 11, 2:38 pm 2010
Stefan Richter
Re: stable? quality assurance?
Yes, testing is desired --- in order to shake out bugs that are not manifest on the developer's systems. Remember that the kernel is a special program in which there are many classes of bugs that can only be reproduced on special hardware and/or with special workloads. Alas, there are not only new bugs in new features but also new bugs in existing features, a.k.a. regressions. But like new bugs, many regressions can alas not be found by the developers themselves on their test ...
Jul 11, 12:49 pm 2010
Martin Steigerwald
Fwd: [TuxOnIce-devel] hang on hibernation with kernel 2. ...
Hi! Since I initially guessed this to be more likely a vanilla kernel than a TuxOnIce bug, I might just ask on kernel mailinglist, whether someone can tell me on where to sort this backtrace. I do not really have an exact idea what subsystem this is. Async I/O? Ciao, Martin ---------- Weitergeleitete Nachricht ---------- Subject: [TuxOnIce-devel] hang on hibernation with kernel 2.6.34.1 and TuxOnIce 3.1.1.1 Date: Samstag 10 Juli 2010 From: Martin Steigerwald ...
Jul 10, 11:58 pm 2010
Wu Fengguang
[PATCH 0/6] writeback cleanups and trivial fixes
Andrew, Here are some writeback cleanups to avoid unnecessary calculation overheads, and relative simple bug fixes. The patch applies to latest linux-next tree. The mmotm tree will need rebase to include commit 32422c79 (writeback: Add tracing to balance_dirty_pages) in order to avoid merge conflicts. [PATCH 1/6] writeback: take account of NR_WRITEBACK_TEMP in balance_dirty_pages() [PATCH 2/6] writeback: reduce calls to global_page_state in balance_dirty_pages() [PATCH 3/6] writeback: ...
Jul 10, 7:06 pm 2010
Wu Fengguang
[PATCH 1/6] writeback: take account of NR_WRITEBACK_TEMP ...
Signed-off-by: Richard Kennedy <richard@rsk.demon.co.uk> Signed-off-by: Wu Fengguang <fengguang.wu@intel.com> --- mm/page-writeback.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) --- linux-next.orig/mm/page-writeback.c 2010-07-11 08:41:37.000000000 +0800 +++ linux-next/mm/page-writeback.c 2010-07-11 08:42:14.000000000 +0800 @@ -503,11 +503,12 @@ static void balance_dirty_pages(struct a }; get_dirty_limits(&background_thresh, &dirty_thresh, - &bdi_thresh, ...
Jul 10, 7:06 pm 2010
Wu Fengguang
[PATCH 3/6] writeback: avoid unnecessary calculation of ...
Split get_dirty_limits() into global_dirty_limits()+bdi_dirty_limit(), so that the latter can be avoided when under global dirty background threshold (which is the normal state for most systems). CC: Peter Zijlstra <a.p.zijlstra@chello.nl> Signed-off-by: Wu Fengguang <fengguang.wu@intel.com> --- fs/fs-writeback.c | 2 include/linux/writeback.h | 5 +- mm/backing-dev.c | 3 - mm/page-writeback.c | 74 ++++++++++++++++++------------------ 4 files changed, 43 ...
Jul 10, 7:06 pm 2010
Wu Fengguang
[PATCH 5/6] writeback: fix queue_io() ordering
This was not a bug, since b_io is empty for kupdate writeback. The next patch will do requeue_io() for non-kupdate writeback, so let's fix it. CC: Dave Chinner <david@fromorbit.com> Cc: Martin Bligh <mbligh@google.com> Cc: Michael Rubin <mrubin@google.com> Cc: Peter Zijlstra <peterz@infradead.org> Signed-off-by: Fengguang Wu <wfg@mail.ustc.edu.cn> Signed-off-by: Wu Fengguang <fengguang.wu@intel.com> --- fs/fs-writeback.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 ...
Jul 10, 7:07 pm 2010
Wu Fengguang
[PATCH 2/6] writeback: reduce calls to global_page_state ...
Reducing the number of times balance_dirty_pages calls global_page_state reduces the cache references and so improves write performance on a variety of workloads. 'perf stats' of simple fio write tests shows the reduction in cache access. Where the test is fio 'write,mmap,600Mb,pre_read' on AMD AthlonX2 with 3Gb memory (dirty_threshold approx 600 Mb) running each test 10 times, dropping the fasted & slowest values then taking the average & standard deviation average (s.d.) in millions ...
Jul 10, 7:06 pm 2010
Wu Fengguang Jul 10, 7:50 pm 2010
Wu Fengguang
[PATCH 4/6] writeback: dont redirty tail an inode with d ...
This avoids delaying writeback for an expired (XFS) inode with lots of dirty pages, but no active dirtier at the moment. Previously we only do that for the kupdate case. CC: Dave Chinner <david@fromorbit.com> CC: Christoph Hellwig <hch@infradead.org> Acked-by: Jan Kara <jack@suse.cz> Signed-off-by: Wu Fengguang <fengguang.wu@intel.com> --- fs/fs-writeback.c | 20 +++++++------------- 1 file changed, 7 insertions(+), 13 deletions(-) --- linux-next.orig/fs/fs-writeback.c 2010-07-11 ...
Jul 10, 7:07 pm 2010
Wu Fengguang
[PATCH 6/6] writeback: merge for_kupdate and !for_kupdat ...
Unify the logic for kupdate and non-kupdate cases. There won't be starvation because the inodes requeued into b_more_io will later be spliced _after_ the remaining inodes in b_io, hence won't stand in the way of other inodes in the next run. It avoids unnecessary redirty_tail() calls, hence the update of i_dirtied_when. The timestamp update is undesirable because it could later delay the inode's periodic writeback, or exclude the inode from the data integrity sync operation (which will check ...
Jul 10, 7:07 pm 2010
crosslonelyover
[PATCH & RESEND] avoid NULL deference in ext2_xattr_get
Hi Dan Carpenter, Thanks for your instructions. I regenerated the patch. Please check it. From 3149865e0d118b939c27659a4e4c884eaa6b3a4c Mon Sep 17 00:00:00 2001 From: Wang Sheng-Hui <crosslonelyover@gmail.com> Date: Sat, 10 Jul 2010 22:07:37 -0400 Subject: [PATCH] avoid NULL deference in ext2_xattr_get Signed-off-by: Wang Sheng-Hui <crosslonelyover@gmail.com> --- fs/ext2/xattr.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/ext2/xattr.c ...
Jul 10, 7:16 pm 2010
shenghui
Re: [PATCH & RESEND] avoid NULL deference in ext2_xattr_get
Please ignore this patch. Just for gmail format check. Thanks for David Beal's explanation! -- Thanks and Best Regards, shenghui --
Jul 11, 1:31 am 2010
tkprice
Re:
business proposal I am Mr Vincent Hong Non Executive Director of the Hang Seng Bank Ltd, hong kong. I have a deceased client funds in my bank of $44.5MUSD and i need you to front as beneficiary,your benefit is 50% of the total funds.If you are interested contact me with your name,address and phone number,for more information on vincenthong50@yahoo.com.hk Yours Truly, Mr Vincent Hong. --
Jul 10, 5:49 pm 2010
Lee, Chun-Yi
[PATCH] Add intel drm blacklist to intel_opregion_presen ...
There have some machines not support by i915 drm driver, e.g. MSI U110/U150, there are use poulsbo chip and drm driver not support it because legal issue. Those machines's acpi backlight control actually work fine and don't need apply the intel opregion support. So, add intel drm blacklist to intel_opregion_present, it can enable the acpi brightness interface but not use intel opregion. Signed-off-by: Lee, Chun-Yi <jlee@novell.com> --- drivers/acpi/video.c | 17 ++++++++++++++++- ...
Jul 10, 5:30 pm 2010
Jeff Dike
Re: Calling system call from User-mode Linux?
Add a function in the userspace side of UML (arch/um/os-Linux) which invokes your new system call through syscall(), and then call that from wherever you need to. Jeff --
Jul 10, 7:15 pm 2010
Arnd Bergmann
Re: [PATCH 2/3] Remove BKL from fs/locks.c
Yes, that was the idea. This is the last patch I need to run all of my machines without the BKL, so I spent a few hours looking at how to fix lockd. When I couldn't figure it out, I decided to do an evil hack that happens to work, in order to build pressure. Arnd --
Jul 11, 3:31 am 2010
Jaroslav Kysela
Re: [PATCH 3/3] sound: push BKL into open functions
I don't see any reason (benefit) to add gotos to these two functions. Jaroslav ----- Jaroslav Kysela <perex@perex.cz> Linux Kernel Sound Maintainer ALSA Project; Red Hat, Inc. --
Jul 11, 12:15 am 2010
Arnd Bergmann
Re: [PATCH 3/3] sound: push BKL into open functions
This moves the lock_kernel() call from soundcore_open to the individual OSS device drivers, where we can deal with it one driver at a time if needed, or just kill off the drivers. All core components in ALSA already provide adequate locking in their open()-functions and do not require the big kernel lock, so there is no need to add the BKL there. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- Sorry, I had removed them and then forgot the git-add before creating the emails. Originally, I ...
Jul 11, 3:16 am 2010
Pekka Enberg
Re: [PATCH v2] x86: Early-boot serial I/O support
I did try it but got bunch of compile errors and figured I was not supposed to use it. Pekka --
Jul 11, 12:10 am 2010
Rafael J. Wysocki
Re: [PATCH v2] pm: Add runtime PM statistics
On a second thought, "active_time" and "suspended_time" should be sufficient (ie. the "runtime_" prefix is not really necessary). Rafael --
Jul 11, 2:26 pm 2010
shenghui
Re: [PATCH] avoid NULL deference in ext2_xattr_get
Thanks for your explanation! -- Thanks and Best Regards, shenghui --
Jul 10, 5:32 pm 2010
Simon Horman
Re: [patch v2.5 3/4] IPVS: make FTP work with full NAT support
The argument to the %pI4 needs to be a pointer so (T)->src.u3.ip should be &(T)->src.u3.ip and (C)->caddr should be &(C)->caddr.ip. I'm not sure how this slipped through the cracks so far. I will repost. --
Jul 11, 2:01 am 2010
Randy Dunlap
Re: 2.6.35-rc2,3 -- Problem with PS2 keyboard and mouse driver
Patches have already been posted for a more permanent fix that allows a distro --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** --
Jul 11, 3:21 pm 2010
Robert Hancock
Re: Interrupt Affinity in SMP
That may be chipset dependent, I don't think all chipsets have the ability to distribute the interrupts like that. Round-robin interrupt distribution for a given handler isn't optimal for performance anyway since it causes the relevant cache lines for the interrupt handler to --
Jul 10, 6:20 pm 2010
Mike Galbraith
Re: [PATCH 4/4] futex: convert hash_bucket locks to raw_ ...
Another option: only scratch the itchy spot. futex: non-blocking synchronization point for futex_wait_requeue_pi() and futex_requeue(). Problem analysis by Darren Hart; The requeue_pi mechanism introduced proxy locking of the rtmutex. This creates a scenario where a task can wake-up, not knowing it has been enqueued on an rtmutex. In order to detect this, the task would have to be able to take either task->pi_blocked_on->lock->wait_lock and/or the hb->lock. Unfortunately, without already ...
Jul 11, 6:33 am 2010
Darren Hart
Re: [PATCH 4/4] futex: convert hash_bucket locks to raw_ ...
I like it. I especially like the change is only evident if you are using the code path that introduced the problem in the first place. If you're doing a lot of requeue_pi operations, then the waking waiters have an advantage over new pending waiters or other tasks with futex keyed on the same hash-bucket... but that seems acceptable to me. I'd like to confirm that holding the pendowner->pi-lock across the wakeup in wakeup_next_waiter() isn't feasible first. If it can work, I think the ...
Jul 11, 8:10 am 2010
Sam Ravnborg
Re: [PATCH] tracing: properly align linker defined symbols
Looks good. I especially like how we with this standardize on the alignment. I will make sure a working version hits next merge window. A few comments. +#define SYMBOL_SECTION(name, section) \ + . = ALIGN(32); \ + VMLINUX_SYMBOL(__start_##section) = .; \ + *(name) \ + VMLINUX_SYMBOL(__stop_##section) = .; The arguments to this macro is confusing. Something like this: #define ...
Jul 10, 11:07 pm 2010
Milton Miller
Re: [RT,RFC] Hacks allowing -rt to run on POWER7 / Powerpc.
I looked at the patch and noticed 2 changes: 1) the batch is checked and cleared after local_irq_save 2) enabling the batch is skipped I talked to Will and had him try moving the local_irq_save above the check for the active batch. That alone did not seem to be enough. However, he confirmed that we are setting batch to active when it is already active in lazy_mmu_enter, meaning that batching is being turned on recursively. I suggested debug to check that irqs are off after ...
Jul 11, 12:49 am 2010
Michael S. Tsirkin
Re: [PATCH] netfilter: add CHECKSUM target
If I understand what Dave said correctly, it's up to you ... The arguments for putting this upstream are: Given the track record, I wouldn't hope for quick fix in the majority of guest dhcp clients, unfortunately :(. We are talking years here. Even after that, one of the uses of virtualization is to keep old guests running. So yes, I think we'll keep using work-arounds for this for a very long time. Further, since we have to add the module and we have to teach management to program it, ...
Jul 11, 3:47 am 2010
Bjoern Brandenburg
Re: periods and deadlines in SCHED_DEADLINE
Isn't this basically sched_yield? Don't run me now, give lower-priority work a chance to complete, let me run again when my budget is replenished. Otherwise, what are the semantics of sched_yield under EDF? Cycle through equal-deadline jobs? Given sporadic task activations, this is probably not very useful. - Björn --
Jul 10, 11:15 pm 2010
Harald Gustafsson
Re: periods and deadlines in SCHED_DEADLINE
Yes, I definitely think the step by step approach is best here. So that eventually its possible to use hard deadline RT also for more Yes, this is exactly what I mean. As long as the interface gives the user control to be able to demote a task to soft RT even if the admission control could allow it into the hard RT policy. Then later when we have managed to include more complex admission controls into the kernel, the system designer could when his system setup is handled move over to always use ...
Jul 10, 10:41 pm 2010
Bjoern Brandenburg
Re: periods and deadlines in SCHED_DEADLINE
Trying to infer whether a task is "hard" or "soft" from task parameters is not a good idea, IMO. It's much better to make this an explicit part of the task model that is configured via sched_setparam. By default, tasks should be marked "soft" (this leaves more wiggle room to the kernel); users who care can change the flag to "hard". Taking a step back, I think the problem here is that we are trying to shove too many concepts and properties into a single scheduler. Hard (no tardiness) is different ...
Jul 11, 12:32 am 2010
Bjoern Brandenburg
Re: periods and deadlines in SCHED_DEADLINE
These are two different things. "Bounded tardiness" means "is there a constant x such that _every deadline_ is missed by at most x" and is commonly used in the context of global multiprocessor schedulers. Guaranteed bounded tardiness as long as the system is not over-utilized for the case P_i!=D_i follows from Leontyev & Anderson's work on window-constrained scheduling policies [1]: each priority priority point (i.e., deadline) lies within the window [release, release + max(D_i)] and is thus ...
Jul 10, 11:12 pm 2010
Bjoern Brandenburg
Re: periods and deadlines in SCHED_DEADLINE
I was under the impression that the kernel implementation is a P-EDF implementation. Now it seems to me that it is in fact a "P-EDF with frequent migrations" implementation. I'd be hesitant to just assume that it "approximates G-EDF" sufficiently well to apply any of the published G-EDF tests. - Björn --- Björn B. Brandenburg Ph.D. Student Dept. of Computer Science University of North Carolina at Chapel Hill http://www.cs.unc.edu/~bbb --
Jul 10, 11:46 pm 2010
Bjoern Brandenburg
Re: periods and deadlines in SCHED_DEADLINE
Now I am getting quite confused. In particular, all of the admission test discussion yesterday was P-EDF-specific, but it seems that now the discussion is about G-EDF. Is the kernel implementing G-EDF or P-EDF? These are two different schedulers, with different admissions test. You can't just magically apply a test for P-EDF on each CPU and make claims about schedulability under G-EDF. Tracking per-CPU budgets under G-EDF is also meaningless. Either this is a P-EDF implementation, in which ...
Jul 10, 11:42 pm 2010
Pekka Enberg Jul 11, 2:01 am 2010
Michael S. Tsirkin
Re: [PATCH] netfilter: add CHECKSUM target
I tried moving the module to xt_CHECKSUM but now iptables -A POSTROUTING -t mangle -p udp --dport 68 -j CHECKSUM --checksum-fill does not to load the module. It seems that xt_request_find_target in x_tables uses the prefix 'ip' for a module. --
Jul 11, 5:27 am 2010
Changli Gao
Re: [PATCH] netfilter: add CHECKSUM target
You should add MODULE_ALIAS clause, i.e. MODULE_ALIAS("ipt_CHECKSUM"); -- Regards, Changli Gao(xiaosuo@gmail.com) --
Jul 11, 5:45 am 2010
Jan Engelhardt
Re: [PATCH] netfilter: add CHECKSUM target
MODULE_ALIAS like the others have. --
Jul 11, 5:45 am 2010
Michael S. Tsirkin Jul 11, 6:19 am 2010
Michael S. Tsirkin Jul 11, 2:21 am 2010
Randy Dunlap
Re: linux-next: Tree for July 9 (staging/ti_st)
Can't find this function in the linux-next source tree: ERROR: "st_get_plat_device" [drivers/staging/ti-st/st_drv.ko] undefined! --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** --
Jul 11, 3:33 pm 2010
Randy Dunlap
Re: linux-next: Tree for July 9 (serial/max3107)
when CONFIG_GPIOLIB is not enabled: drivers/serial/max3107.h:372: error: field 'chip' has incomplete type --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** --
Jul 11, 3:27 pm 2010
Randy Dunlap
Re: linux-next: Tree for July 9 (staging/batman-adv and ...
When both batman-adv and dt3155 are enabled as builtin (=y): drivers/staging/dt3155/built-in.o: In function `cleanup_module': (.text+0xc0): multiple definition of `cleanup_module' drivers/staging/batman-adv/built-in.o:(.text+0x330): first defined here drivers/staging/dt3155/built-in.o: In function `init_module': (.text+0x1120): multiple definition of `init_module' drivers/staging/batman-adv/built-in.o:(.text+0x400): first defined here --- ~Randy *** Remember to use ...
Jul 11, 3:29 pm 2010
Greg KH
Re: [PATCH] Staging: dt3155: fix coding style issues in ...
That would be wonderful. thanks, greg k-h --
Jul 11, 7:13 am 2010
Felipe W Damasio
Re: [PATCH] tproxy: nf_tproxy_assign_sock() can handle t ...
I'm sorry, this is not right. The production machine has 16GB of RAM. Don't know if that matters regarding those proc parameters, though. Cheers, Felipe Damasio --
Jul 11, 12:13 am 2010
Avi Kivity
Re: [PATCH] tproxy: nf_tproxy_assign_sock() can handle t ...
Nothing strange about it. You only get page faults and valid cr2 for canonical addresses (17 high order bits all equal). In this case rax+0xb0 is not a canonical address, so you got a general protection fault instead, with cr2 unchanged. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain. --
Jul 10, 10:19 pm 2010
Eric Dumazet
Re: [PATCH] tproxy: nf_tproxy_assign_sock() can handle t ...
OK, thanks Avi for this information, as I was not aware of this. So something overwrote sk->sk_prot pointer (or skb->sk pointer) with some data. tcp sockets are allocated from a dedicated kmem_cache (because of SLAB_DESTROY_RCU attribute). Their sk->sk_prot should never change in normal operation, since underlying memory cannot be reused by another object type in kernel. It should be NULL or &tcp_prot Felipe, please describe your configuration as much as possible. It might be a driver ...
Jul 11, 1:02 am 2010
Felipe W Damasio
Re: [PATCH] tproxy: nf_tproxy_assign_sock() can handle t ...
Hi Mr. Miller, What do you mean "from elsewhere"? You mean elsewhere on the network code? Since the function that had the problem was tcp_recvmsg and we're talking about a squid process, we're either talking about a typical webserver-objet response, or about about an incorrect/faulty http request from the user. Like I told Mr. Dumazet, since on the squid logs I got a: 2010/07/08 14:51:10| clientTryParseRequest: FD 6088 (187.16.240.122:2035) Invalid Request Only a second before the ...
Jul 10, 8:11 pm 2010
Eric Dumazet
Re: [PATCH] tproxy: nf_tproxy_assign_sock() can handle t ...
x86 being litle endian, string is "A]A]" followed by another "XYXY" pattern (non ASCII chars : 0xE8, 0xDC, 0xE8, 0xDC, "èÜèÜ" in ISO8859) --
Jul 11, 1:36 am 2010
Felipe W Damasio
Re: [PATCH] tproxy: nf_tproxy_assign_sock() can handle t ...
Hi, I'm trying to understand the network code to see if I can help track this down... So I looked at the code of tcp_recvmsg, and I saw that the function that calls __kfree_skb is sk_eat_skb, which is called in tcp_recvmsg: if (tcp_hdr(skb)->fin) goto found_fin_ok; if (!(flags & MSG_PEEK)) { sk_eat_skb(sk, skb, copied_early); copied_early = 0; } ...
Jul 11, 12:11 am 2010
Greg KH
Re: NET_NS: unregister_netdevice: waiting for lo to beco ...
Yes, you are correct. Care to resend all of this to the network-namespace developer(s) and the netdev mailing list so that the correct people are notified so they can fix it all? thanks, greg k-h --
Jul 11, 7:16 am 2010
Michael Leun
FW: NET_NS: unregister_netdevice: waiting for lo to beco ...
Hi, On Sat, 10 Jul 2010 16:52:08 +0200 [bug (no sysfs support for net namespaces at all) solved in 2.6.35-rcX - I used 2.6.34.1] Now that we have solved that last one I've another glitch (this time using 2.6.35-rc4): In an network namespace I can use an tun/tap tunnel through ssh and when closing that namespace then eveything is fine. But when using openvpn (also tunnel trough tun/tap) in an network namespace and then closing that namespace I get: unregister_netdevice: waiting for lo ...
Jul 11, 10:29 am 2010
David Miller
Re: oops in tcp_xmit_retransmit_queue() w/ v2.6.32.15
From: Tejun Heo <tj@kernel.org> A long time ago we had a packet scheduler bug that could corrupt the TCP socket queues, but that was fixed in 2.6.27 so would definitely be fixed in your kernel. -------------------- commit 69747650c814a8a79fef412c7416adf823293a3e Author: David S. Miller <davem@davemloft.net> Date: Sun Aug 17 23:55:36 2008 -0700 pkt_sched: Fix return value corruption in HTB and TBF. Based upon a bug report by Josip Rodin. Packet schedulers should ...
Jul 10, 7:36 pm 2010
Ilpo Järvinen
Re: oops in tcp_xmit_retransmit_queue() w/ v2.6.32.15
Once again I've read the unlinkers through, and only thing that could cause this is tcp_send_synack (others do deal with the hints) but I think Eric already proposed a patch to that but we never got anywhere due to some counterargument why it wouldn't take place (too far away for me to remember, see archives about the discussions). ...But if you want be dead sure some WARN_ON there might not hurt. Also the purging of the whole queue was a similar suspect I then came across (but that would ...
Jul 11, 9:09 am 2010
Eric Dumazet
Re: oops in tcp_xmit_retransmit_queue() w/ v2.6.32.15
Hmm. This sounds familiar to me, but I cannot remember the discussion you mention or the patch. Or maybe it was the TCP transaction thing ? (including data in SYN or --
Jul 11, 10:06 am 2010
Eric Dumazet
Re: oops in tcp_xmit_retransmit_queue() w/ v2.6.32.15
Hmm, I cannot find where we reset restransmit_skb_hint in tcp_mtu_probe(), if we call tcp_unlink_write_queue(). if (skb->len <= copy) { /* We've eaten all the data from this skb. * Throw it away. */ TCP_SKB_CB(nskb)->flags |= TCP_SKB_CB(skb)->flags; <<>> tcp_unlink_write_queue(skb, sk); sk_wmem_free_skb(sk, skb); } else { Sorry if this was already discussed. We might add a comment here in anycase ;) --
Jul 11, 10:46 am 2010
Ilpo Järvinen Jul 11, 12:25 pm 2010
Ilpo Järvinen
Re: oops in tcp_xmit_retransmit_queue() w/ v2.6.32.15
Hmm, another idea... It might be useful to try to disable tcp_retrans_try_collapse in tcp_retransmit_skb as a test. I think that it might be possible that tcp_xmit_retransmit_queue might end up holding a stale reference either in hole or skb. Kind of shot into the dark still, no actual theory on how that could happen but that tcp_xmit_retransmit_queue logic is rather tricky because of returning to the first hole if such exists so that I couldn't immediately rule out the ...
Jul 11, 12:44 pm 2010
Ilpo Järvinen
Re: oops in tcp_xmit_retransmit_queue() w/ v2.6.32.15
No. That's another thing. ...I've already found it with google today but cannot seem to find it again. I thought I used tcp_make_synack eric but ...I think we've not sent that skb just yet, so this'll never be true (and the rexmit loop terminates at send_head without setting it so we should be safe, I'll still need to check that no other code can accidently move -- i.
Jul 11, 12:22 pm 2010
Eric Dumazet
Re: oops in tcp_xmit_retransmit_queue() w/ v2.6.32.15
Just in case, here is a patch for this issue, if Tejun wants to try it. Thanks [PATCH] tcp: tcp_mtu_probe() and retransmit hints When removing an skb from tcp write queue, we must take care of various hints that could be kept on this skb. tcp_mtu_probe() misses this cleanup. lkml reference : http://lkml.org/lkml/2010/7/8/63 Reported-by: Tejun Heo <tj@kernel.org> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> --- diff --git a/net/ipv4/tcp_output.c ...
Jul 11, 11:29 am 2010
Minchan Kim
Re: [PATCH] vmscan: stop meaningless loop iteration when ...
On Fri, Jul 9, 2010 at 8:04 PM, KOSAKI Motohiro I can't understand your point. old shrink_slab shrinker->nr += delta; /* Add delta to previous shrinker's remained count */ total_scan = shrinker->nr; while(total_scan >= SHRINK_BATCH) { nr_before = shrink(xxx); total_scan =- this_scan; } shrinker->nr += total_scan; The total_scan can always be the number < SHRINK_BATCH. So, when next shrinker calcuates loop count, the number can affect. new shrink_slab shrinker->nr += delta; ...
Jul 11, 3:28 pm 2010
James Morris
Re: [PATCH 13/18] ima: use generic_file_llseek for securityfs
Applied to git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next -- James Morris <jmorris@namei.org> --
Jul 11, 4:45 pm 2010
James Morris
Re: [PATCH 08/18] selinux: use generic_file_llseek
Applied to git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next -- James Morris <jmorris@namei.org> --
Jul 11, 4:44 pm 2010
Casey Schaufler
Re: [PATCH 06/10] NFSv4: Add label recommended attribute ...
I don't know what system you're talking about, but that notion was pretty well dispelled in the late 1980's, after the SystemV/MLS --
Jul 10, 10:12 pm 2010
Kyle Moffett
Re: [PATCH 06/10] NFSv4: Add label recommended attribute ...
I would argue that if somebody wants to stick a base64-encoded image or an x509 certificate in their security labels then shipping the whole thing across the wire every time somebody does an extended "stat" is just stupid. Think about how much overhead there would be if you did an "ls -Z" of a directory with 100 files (64k * 100 == 6.4MB!!!), where that data would previously have fit in no more than 10-20k TOTAL. A better solution would be something along the lines of putting at most a ...
Jul 10, 10:02 pm 2010
Avi Kivity
Re: [PATCH v5 2/9] KVM: MMU: fix race between 'walk_addr ...
I don't like these two new variables, but no suggestion at the moment. I'll try to simplify this loop later. One idea may be: while (level > walker.level) { handle indirect pages } while (level > hlevel) { handle direct pages } handle last spte I'm worried that this change is too big for backporting, but no Should be __set_spte(), but this already exists, so can be in a later patch. -- error compiling committee.c: too many arguments to ...
Jul 11, 5:52 am 2010
Avi Kivity
Re: [PATCH v5 5/9] KVM: MMU: introduce gfn_to_page_many_ ...
'entry' better be gfn_t. We limit gfns in a slot, but that's artificial, let's use the correct type. s/ ? true : false//; :) -- error compiling committee.c: too many arguments to function --
Jul 11, 5:59 am 2010
David Miller
Re: linux-next: Tree for July 6 (NET_DSA + PHYLIB kconfig)
From: Randy Dunlap <randy.dunlap@oracle.com> The situations seems to suggest NET_DSA depends upon NET_ETHERNET, so adding NET_ETHERNET to NET_DSA's dependencies probably works better. --
Jul 10, 7:09 pm 2010
Jiri Kosina
Re: linux-next: manual merge of the trivial tree with th ...
Hi Stephen, thanks for reporting it, I have reverted the drivers/media/video/ov511.c hunk. -- Jiri Kosina SUSE Labs, Novell Inc. --
Jul 11, 1:41 pm 2010
David Miller
Re: linux-next: build warning after merge of the net tree
From: Joe Perches <joe@perches.com> That might work. The sym53c8xx_2 doesn't even need this, like I said, you could just remove the NULL 'label' argument cases and then have that bit cured. Could you take a stab at this and the other scsi bits that trigger this warning? Thanks Joe! --
Jul 10, 7:52 pm 2010
Joe Perches
[PATCH net-next] drivers/scsi: Remove warnings after vsp ...
Remove warnings introduced by conversions of dev_<level> macros to functions. Compile tested only. Signed-off-by: Joe Perches <joe@perches.com> --- drivers/scsi/constants.c | 63 ++++++++++++++++++++--------------- drivers/scsi/sd.c | 6 ++-- drivers/scsi/sym53c8xx_2/sym_hipd.c | 10 ++--- 3 files changed, 43 insertions(+), 36 deletions(-) diff --git a/drivers/scsi/constants.c b/drivers/scsi/constants.c index cd05e04..f95de51 100644 --- ...
Jul 10, 10:08 pm 2010
Daniel J Blueman
Re: [2.6.35-rc3] select useful number of entries for DMA ...
I have 4GB. Since this change is specific to x86, I guess the only corner case we need to protect from this change is developers on small x86 embedded systems such as MIDs, so lowering the allocated size on <1GB systems makes sense. -- Daniel J Blueman --
Jul 11, 4:54 am 2010
Daniel J Blueman
Re: [2.6.35-rc3] select useful number of entries for DMA ...
How about something like this? If you think ~18800 entries on a 1GB system is better, let me know and I'll quickly respin. The calculation seems reasonable for other arches. When booting 2.6.35-rc3 on some different x86 boxes with DMA debugging enabled, I've seen consistent exhaustion of the allocated entries during boot, giving 'DMA-API: debugging out of memory - disabling'. Increase the default number of entries to allow DMA debugging again, but assign a reasonable lower limit for systems ...
Jul 11, 6:00 am 2010
Justin P. Mattock Jul 11, 1:07 pm 2010
Jiri Kosina
Re: [PATCH]Documentation:Changes update broken web addresses
Makes sense, I have queued the changes. Thanks. -- Jiri Kosina SUSE Labs, Novell Inc. --
Jul 11, 12:56 pm 2010
Jiri Kosina
Re: [PATCH] trivial: fix typos concerning "already"
Applied, thanks. -- Jiri Kosina SUSE Labs, Novell Inc. --
Jul 11, 12:45 pm 2010
Kumar Gala
Re: [PATCH 1/2] edac: mpc85xx: Fix MPC85xx dependency
we should add this to mpc85xx_defconfig so we build by default. - k --
Jul 11, 9:20 am 2010
Justin P. Mattock
Re: [PATCH v3]kernel.h Move preprocessor #warning about ...
cool alright.. was wonder if this was correct or not, from this it seems it is..(if I see anything I'll send it out..) Thanks as well for being patient with me.. Justin P. Mattock --
Jul 11, 1:07 pm 2010
Jiri Kosina
Re: [PATCH v3]kernel.h Move preprocessor #warning about ...
I have applied the patch, thanks Justin for your persistence, and thanks for reviews while I have been offline, Arnd. -- Jiri Kosina SUSE Labs, Novell Inc. --
Jul 11, 12:39 pm 2010
Jiri Kosina
Re: [PATCH 1/2] trivial: fix typos concerning "sequential"
Applied, thank you Uwe. -- Jiri Kosina SUSE Labs, Novell Inc. --
Jul 11, 12:41 pm 2010
Jiri Kosina
Re: [PATCH 1/1] HID: Send Report ID when numbered report ...
We already have a8ab5d58b0238b8199cc699b8dff7c5e1da24138 commit in Linus' -- Jiri Kosina SUSE Labs, Novell Inc. --
Jul 11, 2:14 pm 2010
Eric W. Biederman
Re: [PATCH 01/24] pidns: Remove races by stopping the ca ...
A little code simplicity. But Serge was right there is cost a noticeable cost. About 5%-7% more on lat_proc from lmbench. The real benefit was simplicity. Eric --
Jul 11, 7:25 am 2010
Louis Rilling
Re: [PATCH 01/24] pidns: Remove races by stopping the ca ...
IIUC, the difference between this solution and the first one I proposed is that instead of pinning proc_mnt with mntget() at copy_process()-time, proc_mnt is looked for and, if possible, mntget() at release_task()-time. Could you elaborate on the trade-off, that is accessing proc_mnt at copy_process()-time vs looking up proc_mnt at release_task()-time? Thanks, -- Dr Louis Rilling Kerlabs Skype: louis.rilling Batiment Germanium Phone: (+33|0) 6 80 89 08 23 80 avenue des Buttes de ...
Jul 11, 7:14 am 2010
Jiri Kosina
Re: [PATCH 1/4 - adjusted changelog] HID: picolcd: fix d ...
Applied, thanks Bruno. -- Jiri Kosina SUSE Labs, Novell Inc. --
Jul 11, 1:58 pm 2010
previous daytodaynext day
July 10, 2010July 11, 2010July 12, 2010