Home » Mailing list archives » linux-kernel » 2010 » June » 9

[tip:perf/urgent] tracing: Fix null pointer deref with SEND_SIG_FORCED

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: tip-bot for Oleg Nesterov
Subject: [tip:perf/urgent] tracing: Fix null pointer deref with SEND_SIG_FORCED
Date: Tuesday, June 8, 2010 - 10:24 pm

Commit-ID:  b9b76dfaac6fa2c289ee8a005be637afd2da7e2f
Gitweb:     http://git.kernel.org/tip/b9b76dfaac6fa2c289ee8a005be637afd2da7e2f
Author:     Oleg Nesterov <oleg@redhat.com>
AuthorDate: Thu, 3 Jun 2010 23:34:09 +0200
Committer:  Frederic Weisbecker <fweisbec@gmail.com>
CommitDate: Tue, 8 Jun 2010 23:51:32 +0200

tracing: Fix null pointer deref with SEND_SIG_FORCED

BUG: unable to handle kernel NULL pointer dereference at
	0000000000000006
IP: [<ffffffff8107bd37>] ftrace_raw_event_signal_generate+0x87/0x140

TP_STORE_SIGINFO() forgets about SEND_SIG_FORCED, fix.

We should probably export is_si_special() and change TP_STORE_SIGINFO()
to use it in the longer term.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Roland McGrath <roland@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Jason Baron <jbaron@redhat.com>
Cc: Masami Hiramatsu <mhiramat@redhat.com>
Cc: 2.6.33.x-2.6.34.x <stable@kernel.org>
LKML-Reference: <20100603213409.GA8307@redhat.com>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
---
 include/trace/events/signal.h |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/include/trace/events/signal.h b/include/trace/events/signal.h
index 814566c..17df434 100644
--- a/include/trace/events/signal.h
+++ b/include/trace/events/signal.h
@@ -10,7 +10,8 @@
 
 #define TP_STORE_SIGINFO(__entry, info)				\
 	do {							\
-		if (info == SEND_SIG_NOINFO) {			\
+		if (info == SEND_SIG_NOINFO ||			\
+		    info == SEND_SIG_FORCED) {			\
 			__entry->errno	= 0;			\
 			__entry->code	= SI_USER;		\
 		} else if (info == SEND_SIG_PRIV) {		\
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 2.6.35/stable] TP_STORE_SIGINFO(SEND_SIG_FORCED) == ..., Oleg Nesterov, (Thu Jun 3, 2:34 pm)
Re: [PATCH 2.6.35/stable] TP_STORE_SIGINFO(SEND_SIG_FORCED ..., Roland McGrath, (Thu Jun 3, 3:35 pm)
Re: [PATCH 2.6.35/stable] TP_STORE_SIGINFO(SEND_SIG_FORCED ..., Frederic Weisbecker, (Tue Jun 8, 2:07 pm)
[tip:perf/urgent] tracing: Fix null pointer deref with SEN ..., tip-bot for Oleg Nes ..., (Tue Jun 8, 10:24 pm)