Re: 2.6.35-rc2-git2: Reported regressions from 2.6.34

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linus Torvalds
Date: Tuesday, June 8, 2010 - 6:53 pm

[ Added lots of cc's to direct specific people to look at the regressions 
  that may or may not be theirs... ]

On Wed, 9 Jun 2010, Rafael J. Wysocki wrote:

From a quick look, most of them look unrelated to that unfortunate bug. 
It's hard to tell for sure, of course (memory corruption can do pretty 
much anything), but I'm not seeing the 07200720.. pattern at least.

And some of them do seem to be bisected to likely culprits and/or have 
patches that are claimed to have fixed them.


That has a "reverting the commit fixes it", and a confirmation from Nick 
Bowler.

Eric, Carl: should I just revert that commit? Or do you have a fix?


Hmm. This does seem to be a properly bisected commit, but at the same time 
it looks from the bugzilla like it's just pure luck on that machine that 
the acpi_pad driver happened to mark TSC unstable - so while the commit 
bisected is the real one, it's not the "deeper reason" for the problem.

Venki, any updates?


This seems to have been introduced by

	commit 7cbaef9c83e58bbd4bdd534b09052b6c5ec457d5
	Author: Ingo Molnar <mingo@elte.hu>
	Date:   Sat Nov 8 17:05:38 2008 +0100

	    sched: optimize sched_clock() a bit
    
	    sched_clock() uses cycles_2_ns() needlessly - which is an irq-disabling
	    variant of __cycles_2_ns().
    
	    Most of the time sched_clock() is called with irqs disabled already.
	    The few places that call it with irqs enabled need to be updated.
    
	    Signed-off-by: Ingo Molnar <mingo@elte.hu>

and this seems to be one of those calling cases that need to be updated.

Ingo? The call trace is:

	BUG: using smp_processor_id() in preemptible [00000000] code: jbd2/sda2-8/337
	caller is native_sched_clock+0x3c/0x68
	Pid: 337, comm: jbd2/sda2-8 Not tainted 2.6.35-rc1jan+ #4
	Call Trace:
	[<ffffffff812362c5>] debug_smp_processor_id+0xc9/0xe4
	[<ffffffff8101059d>] native_sched_clock+0x3c/0x68
	[<ffffffff8101043d>] sched_clock+0x9/0xd
	[<ffffffff81212d7a>] blk_rq_init+0x97/0xa3
	[<ffffffff81214d71>] get_request+0x1c4/0x2d0
	[<ffffffff81214ea6>] get_request_wait+0x29/0x1a6
	[<ffffffff81215537>] __make_request+0x338/0x45b
	[<ffffffff812147c2>] generic_make_request+0x2bb/0x330
	[<ffffffff81214909>] submit_bio+0xd2/0xef
	[<ffffffff811413cb>] submit_bh+0xf4/0x116
	[<ffffffff81144853>] block_write_full_page_endio+0x89/0x96
	[<ffffffff81144875>] block_write_full_page+0x15/0x17
	[<ffffffff8119b00a>] ext4_writepage+0x356/0x36b
	[<ffffffff810e1f91>] __writepage+0x1a/0x39
	[<ffffffff810e32a6>] write_cache_pages+0x20d/0x346
	[<ffffffff810e3406>] generic_writepages+0x27/0x29
	[<ffffffff811ca279>] journal_submit_data_buffers+0x110/0x17d
	[<ffffffff811ca986>] jbd2_journal_commit_transaction+0x4cb/0x156d
	[<ffffffff811d0cba>] kjournald2+0x147/0x37a

(from the bugzilla thing)


Jens?


This one seems to have a patch in bugzilla.


This one also has a patch in Bugzilla, I think Airlie is just waiting to 
calm down his queue and already removed the dependency on the temperature 
code. DaveA?


These two look related. Both are related to that "slot" thing in sysfs 
PCI, but only one of them is marked as Jesse's. Jesse?


Perhaps related to commit 13c24497086418010bf4f76378bcae241d7f59cd?

David Härdeman, Mauro Carvalho Chehab added to cc.

				Linus
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
2.6.35-rc2-git2: Reported regressions from 2.6.34, Rafael J. Wysocki, (Tue Jun 8, 3:06 pm)
[Bug #16120] Oops: 0000 [#1] SMP, unable to handle kernel ..., Rafael J. Wysocki, (Tue Jun 8, 3:10 pm)
[Bug #16129] BUG: using smp_processor_id() in preemptible ..., Rafael J. Wysocki, (Tue Jun 8, 3:10 pm)
[Bug #16127] Boot freeze on HP Compaq nx6325 (RS482) with ..., Rafael J. Wysocki, (Tue Jun 8, 3:10 pm)
[Bug #16092] Caught 64-bit read from uninitialized memory ..., Rafael J. Wysocki, (Tue Jun 8, 3:10 pm)
[Bug #16090] sysfs: cannot create duplicate filename, Rafael J. Wysocki, (Tue Jun 8, 3:10 pm)
[Bug #16104] Radeon KMS does not start after merge of the ..., Rafael J. Wysocki, (Tue Jun 8, 3:10 pm)
[Bug #16161] [2.6.35-rc1 regression] sysfs: cannot create ..., Rafael J. Wysocki, (Tue Jun 8, 3:10 pm)
[Bug #16160] 2.6.35 Radeon KMS power management regression?, Rafael J. Wysocki, (Tue Jun 8, 3:10 pm)
Re: 2.6.35-rc2-git2: Reported regressions from 2.6.34, Linus Torvalds, (Tue Jun 8, 6:53 pm)
Re: 2.6.35-rc2-git2: Reported regressions from 2.6.34, Mauro Carvalho Chehab, (Tue Jun 8, 7:26 pm)
Re: 2.6.35-rc2-git2: Reported regressions from 2.6.34, Eric Dumazet, (Tue Jun 8, 11:36 pm)
Re: 2.6.35-rc2-git2: Reported regressions from 2.6.34, Rafael J. Wysocki, (Wed Jun 9, 1:55 am)
Re: 2.6.35-rc2-git2: Reported regressions from 2.6.34, Rafael J. Wysocki, (Wed Jun 9, 2:00 am)
Re: 2.6.35-rc2-git2: Reported regressions from 2.6.34, Rafael J. Wysocki, (Wed Jun 9, 2:06 am)
Re: 2.6.35-rc2-git2: Reported regressions from 2.6.34, Rafael J. Wysocki, (Wed Jun 9, 2:22 am)
Re: 2.6.35-rc2-git2: Reported regressions from 2.6.34, Linus Torvalds, (Wed Jun 9, 7:24 am)
Re: [Bug #16161] [2.6.35-rc1 regression] sysfs: cannot cre ..., Mikael Pettersson, (Thu Jun 10, 3:09 am)
Re: [Bug #16161] [2.6.35-rc1 regression] sysfs: cannot cre ..., Rafael J. Wysocki, (Thu Jun 10, 8:37 am)
Re: 2.6.35-rc2-git2: Reported regressions from 2.6.34, Alex Chiang, (Thu Jun 10, 3:37 pm)
Re: 2.6.35-rc2-git2: Reported regressions from 2.6.34, Ingo Molnar, (Fri Jun 11, 1:55 am)
Re: 2.6.35-rc2-git2: Reported regressions from 2.6.34, Vivek Goyal, (Fri Jun 11, 12:07 pm)
Re: 2.6.35-rc2-git2: Reported regressions from 2.6.34, Jens Axboe, (Fri Jun 11, 12:11 pm)
Re: 2.6.35-rc2-git2: Reported regressions from 2.6.34, Vivek Goyal, (Fri Jun 11, 12:48 pm)
Re: 2.6.35-rc2-git2: Reported regressions from 2.6.34, Jens Axboe, (Fri Jun 11, 12:53 pm)
Re: 2.6.35-rc2-git2: Reported regressions from 2.6.34, Vivek Goyal, (Sat Jun 12, 7:30 am)
Re: [Bug #16161] [2.6.35-rc1 regression] sysfs: cannot cre ..., Mikael Pettersson, (Sat Jun 12, 9:15 am)
Re: [Bug #16161] [2.6.35-rc1 regression] sysfs: cannot cre ..., Rafael J. Wysocki, (Sat Jun 12, 11:52 am)
Re: 2.6.35-rc2-git2: Reported regressions from 2.6.34, Andrew Morton, (Wed Jun 16, 1:42 pm)
Re: 2.6.35-rc2-git2: Reported regressions from 2.6.34, Sedat Dilek, (Wed Jun 16, 2:00 pm)
Re: 2.6.35-rc2-git2: Reported regressions from 2.6.34, Andrew Morton, (Wed Jun 16, 2:34 pm)