kbuild: Fix the breakage caused by "improve version string logic"

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Boaz Harrosh
Date: Tuesday, June 8, 2010 - 1:31 am

The patch: 85a256d8e0116c8f5ad276730830f5d4d473344d
	Author: David Rientjes <rientjes@google.com>
	Title: kbuild: improve version string logic

Broke none Linus trees that supply their own version string and
tag system via a presence of a localversion* file at the Kernel's
root subdirectory.

After This patch. The "+" (plus) is not added if a localversion*
file is present or a CONFIG_LOCALVERSION is configured.

Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
---
 Makefile |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/Makefile b/Makefile
index 654c31a..324a413 100644
--- a/Makefile
+++ b/Makefile
@@ -945,7 +945,9 @@ ifdef CONFIG_LOCALVERSION_AUTO
 else
 	ifneq ($(scm-identifier),)
 		ifeq ($(LOCALVERSION),)
-			localver-extra = +
+			ifeq ($(localver),)
+				localver-extra = +
+			endif
 		endif
 	endif
 endif
-- 
1.6.6.1

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Linux 2.6.32-rc3, Linus Torvalds, (Sun Oct 4, 5:44 pm)
Re: Linux 2.6.32-rc3, James Cloos, (Mon Oct 5, 11:55 am)
Re: Linux 2.6.32-rc3, Len Brown, (Mon Oct 5, 6:57 pm)
Re: Linux 2.6.32-rc3, Dirk Hohndel, (Mon Oct 5, 7:51 pm)
Re: Linux 2.6.32-rc3, Linus Torvalds, (Tue Oct 6, 7:18 am)
Re: Linux 2.6.32-rc3, Dirk Hohndel, (Tue Oct 6, 7:38 am)
Re: Linux 2.6.32-rc3, Ingo Molnar, (Tue Oct 6, 7:44 am)
Re: Linux 2.6.32-rc3, Linus Torvalds, (Tue Oct 6, 8:13 am)
Re: Linux 2.6.32-rc3, Linus Torvalds, (Tue Oct 6, 8:24 am)
Re: Linux 2.6.32-rc3, Stefan Richter, (Tue Oct 6, 8:29 am)
Re: Linux 2.6.32-rc3, Dirk Hohndel, (Tue Oct 6, 8:34 am)
Re: Linux 2.6.32-rc3, Ingo Molnar, (Tue Oct 6, 8:36 am)
Re: Linux 2.6.32-rc3, Linus Torvalds, (Tue Oct 6, 8:42 am)
Re: Linux 2.6.32-rc3, Linus Torvalds, (Tue Oct 6, 8:43 am)
Re: Linux 2.6.32-rc3, Linus Torvalds, (Tue Oct 6, 8:51 am)
Re: Linux 2.6.32-rc3, Ingo Molnar, (Tue Oct 6, 9:29 am)
Re: Linux 2.6.32-rc3, Linus Torvalds, (Tue Oct 6, 9:31 am)
Re: Linux 2.6.32-rc3, Ingo Molnar, (Tue Oct 6, 9:35 am)
Re: Linux 2.6.32-rc3, Frans Pop, (Tue Oct 6, 9:36 am)
Re: Linux 2.6.32-rc3, Ingo Molnar, (Tue Oct 6, 9:40 am)
Re: Linux 2.6.32-rc3, Frans Pop, (Tue Oct 6, 9:40 am)
Re: Linux 2.6.32-rc3, Ingo Molnar, (Tue Oct 6, 10:08 am)
Re: Linux 2.6.32-rc3, Frans Pop, (Tue Oct 6, 10:09 am)
Re: Linux 2.6.32-rc3, Stefan Richter, (Tue Oct 6, 10:15 am)
Re: Linux 2.6.32-rc3, Stefan Richter, (Tue Oct 6, 10:20 am)
Re: Linux 2.6.32-rc3, Frans Pop, (Tue Oct 6, 10:22 am)
Re: Linux 2.6.32-rc3, Linus Torvalds, (Tue Oct 6, 10:32 am)
Re: Linux 2.6.32-rc3, Stefan Richter, (Tue Oct 6, 10:34 am)
[patch] kbuild: Improve version string logic, Ingo Molnar, (Tue Oct 6, 10:35 am)
Re: Linux 2.6.32-rc3, Len Brown, (Tue Oct 6, 10:40 am)
Re: Linux 2.6.32-rc3, Linus Torvalds, (Tue Oct 6, 10:41 am)
Re: Linux 2.6.32-rc3, Theodore Tso, (Tue Oct 6, 10:44 am)
Re: Linux 2.6.32-rc3, Dirk Hohndel, (Tue Oct 6, 10:45 am)
Re: Linux 2.6.32-rc3, Herlin R. Matos Lastres, (Tue Oct 6, 11:00 am)
Re: Linux 2.6.32-rc3, Theodore Tso, (Tue Oct 6, 11:12 am)
Re: Linux 2.6.32-rc3, Theodore Tso, (Tue Oct 6, 11:14 am)
Re: Linux 2.6.32-rc3, Linus Torvalds, (Tue Oct 6, 11:16 am)
Re: Linux 2.6.32-rc3, Ingo Molnar, (Tue Oct 6, 11:16 am)
Re: Linux 2.6.32-rc3, Linus Torvalds, (Tue Oct 6, 11:20 am)
Re: Linux 2.6.32-rc3, Frans Pop, (Tue Oct 6, 11:23 am)
Re: Linux 2.6.32-rc3, Ingo Molnar, (Tue Oct 6, 11:24 am)
Re: Linux 2.6.32-rc3, Frans Pop, (Tue Oct 6, 11:29 am)
Re: Linux 2.6.32-rc3, Linus Torvalds, (Tue Oct 6, 11:35 am)
Re: [patch] kbuild: Improve version string logic, Johannes Berg, (Tue Oct 6, 11:37 am)
Re: [patch] kbuild: Improve version string logic, Ingo Molnar, (Tue Oct 6, 11:49 am)
Re: [patch] kbuild: Improve version string logic, Johannes Berg, (Tue Oct 6, 11:55 am)
Re: Linux 2.6.32-rc3, david, (Tue Oct 6, 11:56 am)
Re: [patch] kbuild: Improve version string logic, Theodore Tso, (Tue Oct 6, 12:03 pm)
Re: Linux 2.6.32-rc3, Joel Becker, (Tue Oct 6, 12:22 pm)
Re: Linux 2.6.32-rc3, Stefan Richter, (Tue Oct 6, 12:23 pm)
Re: Linux 2.6.32-rc3, Frans Pop, (Tue Oct 6, 12:37 pm)
Re: [patch] kbuild: Improve version string logic, Frans Pop, (Tue Oct 6, 12:45 pm)
Re: [patch] kbuild: Improve version string logic, Johannes Berg, (Tue Oct 6, 12:48 pm)
Re: [patch] kbuild: Improve version string logic, Frans Pop, (Tue Oct 6, 1:25 pm)
Re: Linux 2.6.32-rc3, Stefan Richter, (Tue Oct 6, 2:19 pm)
Re: Linux 2.6.32-rc3, Benjamin Herrenschmidt, (Tue Oct 6, 2:33 pm)
Re: Linux 2.6.32-rc3, Linus Torvalds, (Tue Oct 6, 3:13 pm)
Re: Linux 2.6.32-rc3, Linus Torvalds, (Tue Oct 6, 3:19 pm)
Re: Linux 2.6.32-rc3, Florian Mickler, (Tue Oct 6, 5:51 pm)
Re: Linux 2.6.32-rc3, Bryan Donlan, (Tue Oct 6, 6:09 pm)
Re: Linux 2.6.32-rc3, Dave Airlie, (Tue Oct 6, 6:22 pm)
Re: Linux 2.6.32-rc3, Theodore Tso, (Tue Oct 6, 7:31 pm)
Re: [patch] kbuild: Improve version string logic, David Rientjes, (Tue Oct 6, 7:43 pm)
Re: Linux 2.6.32-rc3, Benjamin Herrenschmidt, (Tue Oct 6, 7:45 pm)
Re: Linux 2.6.32-rc3, Linus Torvalds, (Tue Oct 6, 8:23 pm)
Re: Linux 2.6.32-rc3, Linus Torvalds, (Tue Oct 6, 8:31 pm)
Re: Linux 2.6.32-rc3, Justin P. Mattock, (Tue Oct 6, 9:02 pm)
Re: Linux 2.6.32-rc3, Frans Pop, (Tue Oct 6, 10:56 pm)
Re: Linux 2.6.32-rc3, Theodore Tso, (Wed Oct 7, 6:52 am)
Re: Linux 2.6.32-rc3, Mike Galbraith, (Wed Oct 7, 7:52 am)
Re: Linux 2.6.32-rc3, david, (Wed Oct 7, 10:44 am)
Re: Linux 2.6.32-rc3, Mike Galbraith, (Wed Oct 7, 11:13 am)
Re: Linux 2.6.32-rc3, Steven Rostedt, (Wed Oct 7, 2:39 pm)
Re: Linux 2.6.32-rc3, Len Brown, (Wed Oct 7, 3:33 pm)
Re: Linux 2.6.32-rc3, Frans Pop, (Thu Oct 8, 8:20 am)
Re: Linux 2.6.32-rc3, Pavel Machek, (Sat Oct 10, 5:09 am)
Re: Linux 2.6.32-rc3, Felipe Contreras, (Sat Oct 10, 5:18 am)
[PATCH, v2] kbuild: Improve version string logic, Ingo Molnar, (Mon Oct 12, 12:57 pm)
Re: [PATCH, v2] kbuild: Improve version string logic, David Rientjes, (Mon Oct 12, 7:00 pm)
Re: [PATCH, v2] kbuild: Improve version string logic, Ingo Molnar, (Tue Oct 13, 12:05 am)
Re: [PATCH, v2] kbuild: Improve version string logic, Ingo Molnar, (Tue Oct 13, 12:07 am)
Re: [PATCH, v2] kbuild: Improve version string logic, David Rientjes, (Tue Oct 13, 12:59 am)
Re: [PATCH, v2] kbuild: Improve version string logic, Frans Pop, (Tue Oct 13, 10:51 am)
Re: [PATCH, v2] kbuild: Improve version string logic, Linus Torvalds, (Tue Oct 13, 11:01 am)
Re: [PATCH, v2] kbuild: Improve version string logic, David Rientjes, (Tue Oct 13, 4:59 pm)
Re: [PATCH, v2] kbuild: Improve version string logic, Ingo Molnar, (Tue Oct 13, 11:59 pm)
Re: [PATCH, v2] kbuild: Improve version string logic, David Rientjes, (Wed Oct 14, 12:24 am)
Re: [PATCH, v2] kbuild: Improve version string logic, Ingo Molnar, (Wed Oct 14, 12:33 am)
Re: [PATCH, v2] kbuild: Improve version string logic, David Rientjes, (Wed Oct 14, 12:42 am)
Re: [PATCH, v2] kbuild: Improve version string logic, David Rientjes, (Thu Oct 15, 12:37 am)
Re: [PATCH, v2] kbuild: Improve version string logic, David Rientjes, (Thu Oct 15, 1:01 am)
Re: [PATCH, v2] kbuild: Improve version string logic, Ingo Molnar, (Thu Oct 15, 1:59 am)
Re: [PATCH, v2] kbuild: Improve version string logic, Ingo Molnar, (Thu Oct 15, 2:03 am)
Re: Linux 2.6.32-rc3, Frans Pop, (Thu Oct 15, 8:51 am)
Re: [PATCH, v2] kbuild: Improve version string logic, David Rientjes, (Thu Oct 15, 1:38 pm)
Re: [PATCH, v2] kbuild: Improve version string logic, David Rientjes, (Thu Oct 15, 1:45 pm)
kbuild: Fix the breakage caused by "improve version string ..., Boaz Harrosh, (Tue Jun 8, 1:31 am)