Re: [v5 Patch 1/3] netpoll: add generic support for bridge and bonding devices

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: David Miller
Date: Monday, June 7, 2010 - 3:01 am

From: Cong Wang <amwang@redhat.com>
Date: Mon, 07 Jun 2010 17:57:49 +0800


Of course I don't like it. :-)

I suspect the locking scheme will need to be changed.

Besides, if we're going to hack this up and do write lock attempts in
the read locking paths, there is no point in using a rwlock any more.
And I'm personally in disfavor of all rwlock usage anyways (it dirties
the cacheline for readers just as equally for writers, and if the
critically protected code path is short enough, that shared cache
line atomic operation will be the predominant cost).

So I'd say, 1) make this a spinlock and 2) try to use RCU for the
read path.

That would fix everything.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[v5 Patch 2/3] bridge: make bridge support netpoll, Amerigo Wang, (Wed May 5, 1:11 am)
[v5 Patch 3/3] bonding: make bonding support netpoll, Amerigo Wang, (Wed May 5, 1:11 am)
Re: [v5 Patch 1/3] netpoll: add generic support for bridge ..., David Miller, (Mon Jun 7, 3:01 am)
[PATCH] netconsole: queue console messages to send later, Flavio Leitner, (Mon Jun 7, 12:24 pm)
Re: [PATCH] netconsole: queue console messages to send later, Stephen Hemminger, (Mon Jun 7, 1:00 pm)