Re: [RFC PATCH v7 01/19] Add a new structure for skb buffer from external.

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Stephen Hemminger
Date: Sunday, June 6, 2010 - 4:13 pm

Still not sure this is a good idea for a couple of reasons:

1. We already have lots of special cases with skb's (frags and fraglist),
   and skb's travel through a lot of different parts of the kernel.  So any
   new change like this creates lots of exposed points for new bugs. Look
   at cases like MD5 TCP and netfilter, and forwarding these SKB's to ipsec
   and ppp and ...

2. SKB's can have infinite lifetime in the kernel. If these buffers come from
   a fixed size pool in an external device, they can easily all get tied up
   if you have a slow listener. What happens then?
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[RFC PATCH v7 14/19] Add header file for mp device., xiaohui.xin, (Sat Jun 5, 3:14 am)
Re: [RFC PATCH v7 01/19] Add a new structure for skb buffe ..., Stephen Hemminger, (Sun Jun 6, 4:13 pm)
Re: [RFC PATCH v7 01/19] Add a new structure for skb buffe ..., Michael S. Tsirkin, (Sun Jun 20, 3:06 am)
Re: [RFC PATCH v7 01/19] Add a new structure for skb buffe ..., Michael S. Tsirkin, (Sun Jun 20, 3:39 am)
Re: [RFC PATCH v7 01/19] Add a new structure for skb buffe ..., Michael S. Tsirkin, (Sun Jun 20, 4:47 am)
Re: [RFC PATCH v7 01/19] Add a new structure for skb buffe ..., Michael S. Tsirkin, (Sun Jun 20, 5:48 am)
Re: [RFC PATCH v7 01/19] Add a new structure for skb buffe ..., Michael S. Tsirkin, (Fri Jun 25, 4:06 am)