Home » Mailing list archives » linux-kernel » 2010 » June » 20

Re: [PATCH 0/6] Unshare support for the pid namespace.

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Oleg Nesterov
Subject: Re: [PATCH 0/6] Unshare support for the pid namespace.
Date: Sunday, June 20, 2010 - 2:56 pm

On 06/20, Eric W. Biederman wrote:

Sorry, didn't notice this part...

Which races? I am talking about the current problems with pid_ns_release_proc(),
we have at least 3 bugs, from the 2/2 changelog:

	- Nobody does mntput() if copy_process() fails after
	  pid_ns_prepare_proc().

	- proc_flush_task() checks upid->nr == 1 to verify we are init,
	  this is wrong if a multi-threaded init does exec.

	- As Louis pointed out, this namespace can have the detached
	  EXIT_DEAD tasks which can use ns->proc_mnt after this mntput().

Oleg.

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] procfs: Do not release pid_ns->proc_mnt too early, Louis Rilling, (Wed Jun 16, 9:34 am)
Re: [PATCH] procfs: Do not release pid_ns->proc_mnt too early, Pavel Emelyanov, (Thu Jun 17, 2:53 am)
Re: [PATCH] procfs: Do not release pid_ns->proc_mnt too early, Eric W. Biederman, (Thu Jun 17, 6:41 am)
Re: [PATCH] procfs: Do not release pid_ns->proc_mnt too early, Louis Rilling, (Thu Jun 17, 7:20 am)
Re: [PATCH] procfs: Do not release pid_ns->proc_mnt too early, Oleg Nesterov, (Thu Jun 17, 2:20 pm)
Re: [PATCH] procfs: Do not release pid_ns->proc_mnt too early, Oleg Nesterov, (Thu Jun 17, 2:36 pm)
Re: [PATCH] procfs: Do not release pid_ns->proc_mnt too early, Louis Rilling, (Fri Jun 18, 1:20 am)
Re: [PATCH] procfs: Do not release pid_ns->proc_mnt too early, Louis Rilling, (Fri Jun 18, 1:27 am)
Re: [PATCH] procfs: Do not release pid_ns->proc_mnt too early, Oleg Nesterov, (Fri Jun 18, 4:15 am)
Re: [PATCH] procfs: Do not release pid_ns->proc_mnt too early, Oleg Nesterov, (Fri Jun 18, 9:08 am)
Re: [PATCH] procfs: Do not release pid_ns->proc_mnt too early, Oleg Nesterov, (Fri Jun 18, 9:27 am)
Re: [PATCH] procfs: Do not release pid_ns->proc_mnt too early, Louis Rilling, (Fri Jun 18, 10:33 am)
Re: [PATCH] procfs: Do not release pid_ns->proc_mnt too early, Oleg Nesterov, (Fri Jun 18, 10:55 am)
Re: [PATCH] procfs: Do not release pid_ns->proc_mnt too early, Oleg Nesterov, (Fri Jun 18, 2:23 pm)
[PATCH 0/4] pid_ns_prepare_proc/unshare cleanups, Oleg Nesterov, (Sat Jun 19, 12:08 pm)
[PATCH 1/4] procfs: proc_get_sb: consolidate/cleanup root_ ..., Oleg Nesterov, (Sat Jun 19, 12:09 pm)
[PATCH 2/4] procfs: kill the global proc_mnt variable, Oleg Nesterov, (Sat Jun 19, 12:10 pm)
[PATCH 3/4] procfs: move pid_ns_prepare_proc() from copy_p ..., Oleg Nesterov, (Sat Jun 19, 12:10 pm)
[PATCH RESEND 4/4] sys_unshare: simplify the not-really-im ..., Oleg Nesterov, (Sat Jun 19, 12:11 pm)
[PATCH 0/6] Unshare support for the pid namespace., Eric W. Biederman, (Sun Jun 20, 1:42 am)
[PATCH 1/6] pid: Remove the child_reaper special case in ..., Eric W. Biederman, (Sun Jun 20, 1:44 am)
[PATCH 2/6] pidns: Call pid_ns_prepare_proc from create_pi ..., Eric W. Biederman, (Sun Jun 20, 1:45 am)
[PATCH 3/6] procfs: kill the global proc_mnt variable, Eric W. Biederman, (Sun Jun 20, 1:45 am)
[PATCH 4/6] pidns: Don't allow new pids after the namespac ..., Eric W. Biederman, (Sun Jun 20, 1:47 am)
[PATCH 5/6] pidns: Use task_active_pid_ns where appropriate, Eric W. Biederman, (Sun Jun 20, 1:48 am)
[PATCH 6/6] pidns: Support unsharing the pid namespace., Eric W. Biederman, (Sun Jun 20, 1:49 am)
Re: [PATCH 0/6] Unshare support for the pid namespace., Oleg Nesterov, (Sun Jun 20, 11:03 am)
[PATCH 0/2] pid_ns_release_proc() fixes, Oleg Nesterov, (Sun Jun 20, 11:05 am)
[PATCH 1/2] pid_ns: move destroy_pid_namespace() into work ..., Oleg Nesterov, (Sun Jun 20, 11:06 am)
[PATCH 2/2] pid_ns: refactor the buggy pid_ns_release_proc ..., Oleg Nesterov, (Sun Jun 20, 11:06 am)
Re: [PATCH 2/6] pidns: Call pid_ns_prepare_proc from creat ..., Oleg Nesterov, (Sun Jun 20, 11:19 am)
Re: [PATCH 1/6] pid: Remove the child_reaper special case ..., Oleg Nesterov, (Sun Jun 20, 11:29 am)
Re: [PATCH 4/6] pidns: Don't allow new pids after the name ..., Oleg Nesterov, (Sun Jun 20, 11:44 am)
Re: [PATCH 6/6] pidns: Support unsharing the pid namespace., Oleg Nesterov, (Sun Jun 20, 1:14 pm)
Re: [PATCH 1/6] pid: Remove the child_reaper special case ..., Oleg Nesterov, (Sun Jun 20, 1:27 pm)
Re: [PATCH 6/6] pidns: Support unsharing the pid namespace., Oleg Nesterov, (Sun Jun 20, 1:42 pm)
Re: [PATCH 0/6] Unshare support for the pid namespace., Eric W. Biederman, (Sun Jun 20, 2:00 pm)
Re: [PATCH 0/6] Unshare support for the pid namespace., Oleg Nesterov, (Sun Jun 20, 2:48 pm)
Re: [PATCH 0/6] Unshare support for the pid namespace., Oleg Nesterov, (Sun Jun 20, 2:56 pm)
Re: [PATCH 6/6] pidns: Support unsharing the pid namespace., Eric W. Biederman, (Sun Jun 20, 6:53 pm)
Re: [PATCH] procfs: Do not release pid_ns->proc_mnt too early, Louis Rilling, (Mon Jun 21, 4:09 am)
Re: [PATCH] procfs: Do not release pid_ns->proc_mnt too early, Louis Rilling, (Mon Jun 21, 4:11 am)
Re: [PATCH] procfs: Do not release pid_ns->proc_mnt too early, Louis Rilling, (Mon Jun 21, 4:15 am)
Re: [PATCH] procfs: Do not release pid_ns->proc_mnt too early, Eric W. Biederman, (Mon Jun 21, 5:58 am)
Re: [PATCH] procfs: Do not release pid_ns->proc_mnt too early, Louis Rilling, (Mon Jun 21, 7:15 am)
Re: [PATCH] procfs: Do not release pid_ns->proc_mnt too early, Eric W. Biederman, (Mon Jun 21, 7:26 am)
Re: [PATCH] procfs: Do not release pid_ns->proc_mnt too early, Oleg Nesterov, (Mon Jun 21, 7:38 am)
[PATCH 0/1] pid_ns: move pid_ns_release_proc() from proc_f ..., Oleg Nesterov, (Wed Jun 23, 1:36 pm)
[PATCH 1/1] pid_ns: move pid_ns_release_proc() from proc_f ..., Oleg Nesterov, (Wed Jun 23, 1:37 pm)
Re: [PATCH 1/1] pid_ns: move pid_ns_release_proc() from pr ..., Sukadev Bhattiprolu, (Wed Jun 23, 11:36 pm)
Re: [PATCH 1/1] pid_ns: move pid_ns_release_proc() from pr ..., Eric W. Biederman, (Thu Jun 24, 12:06 am)
[PATCH] pid_ns: Fix proc_flush_task() accessing freed proc_mnt, Louis Rilling, (Thu Jun 24, 1:37 am)
Re: [PATCH 1/1] pid_ns: move pid_ns_release_proc() from pr ..., Oleg Nesterov, (Thu Jun 24, 5:59 am)
Re: [PATCH 1/1] pid_ns: move pid_ns_release_proc() from pr ..., Oleg Nesterov, (Thu Jun 24, 6:01 am)
[RESEND PATCH] pid_ns: Fix proc_flush_task() accessing fre ..., Louis Rilling, (Thu Jun 24, 10:08 am)
Re: [RESEND PATCH] pid_ns: Fix proc_flush_task() accessing ..., Oleg Nesterov, (Thu Jun 24, 12:18 pm)
Re: [RESEND PATCH] pid_ns: Fix proc_flush_task() accessing ..., Louis Rilling, (Fri Jun 25, 3:23 am)
Re: [RESEND PATCH] pid_ns: Fix proc_flush_task() accessing ..., Oleg Nesterov, (Fri Jun 25, 5:21 am)
Re: [RESEND PATCH] pid_ns: Fix proc_flush_task() accessing ..., Sukadev Bhattiprolu, (Fri Jun 25, 11:37 am)
Re: [RESEND PATCH] pid_ns: Fix proc_flush_task() accessing ..., Oleg Nesterov, (Fri Jun 25, 12:29 pm)
Re: [RESEND PATCH] pid_ns: Fix proc_flush_task() accessing ..., Sukadev Bhattiprolu, (Fri Jun 25, 2:26 pm)
Re: [RESEND PATCH] pid_ns: Fix proc_flush_task() accessing ..., Oleg Nesterov, (Fri Jun 25, 2:27 pm)
Re: [RESEND PATCH] pid_ns: Fix proc_flush_task() accessing ..., Sukadev Bhattiprolu, (Fri Jun 25, 3:07 pm)
[RFC][PATCH 1/2] pidns: Add a flag to indicate a pid names ..., Eric W. Biederman, (Thu Jul 8, 9:36 pm)
[RFC][PATCH 2/2] pidns: Remove proc flush races when a pid ..., Eric W. Biederman, (Thu Jul 8, 9:39 pm)
Re: [RFC][PATCH 2/2] pidns: Remove proc flush races when a ..., Louis Rilling, (Fri Jul 9, 5:14 am)
Re: [RFC][PATCH 2/2] pidns: Remove proc flush races when a ..., Eric W. Biederman, (Fri Jul 9, 6:05 am)
Re: [RFC][PATCH 2/2] pidns: Remove proc flush races when a ..., Louis Rilling, (Fri Jul 9, 7:13 am)
[PATCH 01/24] pidns: Remove races by stopping the caching ..., Eric W. Biederman, (Fri Jul 9, 8:58 am)
Re: [PATCH 01/24] pidns: Remove races by stopping the cach ..., Serge E. Hallyn, (Fri Jul 9, 3:13 pm)
Re: [PATCH 01/24] pidns: Remove races by stopping the cach ..., Louis Rilling, (Sun Jul 11, 7:14 am)
Re: [PATCH 01/24] pidns: Remove races by stopping the cach ..., Eric W. Biederman, (Sun Jul 11, 7:25 am)
[PATCH] pidns: Fix wait for zombies to be reaped in zap_pi ..., Eric W. Biederman, (Mon Jul 12, 11:09 am)
Re: [PATCH] pidns: Fix wait for zombies to be reaped in za ..., Louis Rilling, (Tue Jul 13, 2:42 pm)
Re: [PATCH] pidns: Fix wait for zombies to be reaped in za ..., Serge E. Hallyn, (Tue Jul 13, 3:34 pm)
Re: [PATCH] pidns: Fix wait for zombies to be reaped in za ..., Eric W. Biederman, (Tue Jul 13, 6:47 pm)
Re: [PATCH] pidns: Fix wait for zombies to be reaped in za ..., Sukadev Bhattiprolu, (Wed Jul 14, 1:53 pm)
Re: [PATCH] pidns: Fix wait for zombies to be reaped in za ..., Eric W. Biederman, (Wed Jul 14, 2:35 pm)
Re: [PATCH] pidns: Fix wait for zombies to be reaped in za ..., Sukadev Bhattiprolu, (Sat Oct 30, 12:07 am)