Re: [RFC PATCH v7 01/19] Add a new structure for skb buffer from external.

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Herbert Xu
Date: Sunday, June 20, 2010 - 4:59 am

On Sun, Jun 20, 2010 at 02:47:19PM +0300, Michael S. Tsirkin wrote:

I think you're mistaken with respect to what is being proposed.
Raising 512 bytes isn't a hard constraint, it is merely an
optimisation for Intel NICs because their PS mode can produce
a head fragment of up to 512 bytes.

If the guest didn't allocate 512 bytes it wouldn't be the end of
the world, it'd just mean that we'd either copy whatever is in
the head fragment, or we waste 4096-X bytes of memory where X
is the number of bytes in the head.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[RFC PATCH v7 14/19] Add header file for mp device., xiaohui.xin, (Sat Jun 5, 3:14 am)
Re: [RFC PATCH v7 01/19] Add a new structure for skb buffe ..., Michael S. Tsirkin, (Sun Jun 20, 3:06 am)
Re: [RFC PATCH v7 01/19] Add a new structure for skb buffe ..., Michael S. Tsirkin, (Sun Jun 20, 3:39 am)
Re: [RFC PATCH v7 01/19] Add a new structure for skb buffe ..., Michael S. Tsirkin, (Sun Jun 20, 4:47 am)
Re: [RFC PATCH v7 01/19] Add a new structure for skb buffe ..., Herbert Xu, (Sun Jun 20, 4:59 am)
Re: [RFC PATCH v7 01/19] Add a new structure for skb buffe ..., Michael S. Tsirkin, (Sun Jun 20, 5:48 am)
Re: [RFC PATCH v7 01/19] Add a new structure for skb buffe ..., Michael S. Tsirkin, (Fri Jun 25, 4:06 am)