Re: [PATCH] serial: revert "Use block_til_ready helper"

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Alan Cox
Date: Saturday, June 19, 2010 - 2:57 pm

O> I could reproduce the problem now and bisected it down to a cleanup

So the init code isn't getting run somewhere for some reason. Almost
certainly a count bug.


I'll take a look. We really don't want to revert this as it fixes some
nasty things the BKL covers over so I'd be worried the races would become
exposed (and it possibly allows NULL->func() calls if it can which would
be bad)

First guess would be something in port->count going astray and the port
not getting re-initialised.

Important question - does it need a getty or will a simple cat < /dev/foo
twice get garbled (or cat > if its garbling the other way)

Which direction matters and whether a hangup is needed matters
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH v3 00/10] BKL conversion in tty layer, Arnd Bergmann, (Sat May 15, 1:59 pm)
[PATCH 06/10] tty: annotate tty_write_lock, Arnd Bergmann, (Sat May 15, 1:59 pm)
Re: [PATCH v3 00/10] BKL conversion in tty layer, Alan Cox, (Mon May 17, 6:41 am)
Re: [PATCH v3 00/10] BKL conversion in tty layer, Greg KH, (Mon May 17, 8:30 am)
Re: [PATCH v3 00/10] BKL conversion in tty layer, Arnd Bergmann, (Mon May 17, 11:30 am)
Re: [PATCH v3 00/10] BKL conversion in tty layer, Arnd Bergmann, (Mon May 17, 11:49 am)
Re: [PATCH v3 00/10] BKL conversion in tty layer, Greg KH, (Mon May 17, 9:27 pm)
Re: [PATCH v3 00/10] BKL conversion in tty layer, Arnd Bergmann, (Tue May 18, 2:52 pm)
Re: [PATCH v3 00/10] BKL conversion in tty layer, Greg KH, (Tue May 18, 6:50 pm)
Re: [PATCH v3 00/10] BKL conversion in tty layer, Arnd Bergmann, (Sat May 22, 6:54 am)
Re: [PATCH v3 00/10] BKL conversion in tty layer, Tony Luck, (Thu Jun 17, 12:13 pm)
Re: [PATCH v3 00/10] BKL conversion in tty layer, Arnd Bergmann, (Thu Jun 17, 12:40 pm)
Re: [PATCH v3 00/10] BKL conversion in tty layer, Tony Luck, (Thu Jun 17, 1:15 pm)
Re: [PATCH v3 00/10] BKL conversion in tty layer, Arnd Bergmann, (Thu Jun 17, 2:48 pm)
Re: [PATCH v3 00/10] BKL conversion in tty layer, Frederic Weisbecker, (Thu Jun 17, 3:09 pm)
[PATCH] tty: avoid recursive BTM in pty_close, Arnd Bergmann, (Fri Jun 18, 5:58 am)
Re: [PATCH] tty: avoid recursive BTM in pty_close, Alan Cox, (Fri Jun 18, 9:21 am)
Re: [PATCH] tty: avoid recursive BTM in pty_close, Tony Luck, (Fri Jun 18, 9:52 am)
Re: [PATCH] tty: avoid recursive BTM in pty_close, Arnd Bergmann, (Fri Jun 18, 11:35 am)
Re: [PATCH] tty: avoid recursive BTM in pty_close, Tony Luck, (Fri Jun 18, 1:25 pm)
Re: [PATCH] tty: avoid recursive BTM in pty_close, Arnd Bergmann, (Sat Jun 19, 5:32 am)
Re: [PATCH] serial: revert "Use block_til_ready helper", Alan Cox, (Sat Jun 19, 2:57 pm)
Re: [PATCH] tty: avoid recursive BTM in pty_close, Tony Luck, (Mon Jun 28, 10:17 am)
Re: [PATCH] tty: avoid recursive BTM in pty_close, Arnd Bergmann, (Mon Jun 28, 12:03 pm)