Re: [PATCH 2/6: v4] lockdep: Make MAX_STACK_TRACE_ENTRIES configurable.

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: John Kacur
Date: Thursday, June 17, 2010 - 1:46 am

On Thu, 17 Jun 2010, Peter Zijlstra wrote:


Well, as I said, I'm testing with Yong Zhang's patch, and it seems to be 
doing the trick, so I am actually not pushing for my patch right now.
 
But please stop characterizing this as "blindly increasing the limit", 
because that is not at all what I or others do. We have a debug build with 
tons of options turned on in which case we increased it to the minimum 
that worked for us, and we have a tracing build in which case we left it 
at the default. Also as I pointed out, in Sven's case it sounds like they may 
have had a build where they even wanted to decrease it.

Your objection in the past was that it was another tunable that nobody understands, and I 
have more sympathy for that argument. My counterargument is that if we're 
all putting a version of this patch in our private builds, then it's a tad 
counterproductive. Let's leave things the way they are for now, unless 
this becomes a problem again.

Thanks.

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/6] Potential rt patches for tip/rt/2.6.33, John Kacur, (Mon Jun 14, 3:21 pm)
Re: [PATCH 2/6: v4] lockdep: Make MAX_STACK_TRACE_ENTRIES ..., John Kacur, (Thu Jun 17, 1:46 am)