Re: [PATCH 5/9] oom: cleanup has_intersects_mems_allowed()

view
thread

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: David Rientjes

Subject: Re: [PATCH 5/9] oom: cleanup has_intersects_mems_allowed()

Date: Wednesday, June 16, 2010 - 9:20 pm

On Thu, 17 Jun 2010, KOSAKI Motohiro wrote:

quoted text> 
> Now has_intersects_mems_allowed() has own thread iterate logic, but
> it should use while_each_thread().
> 
> It slightly improve the code readability.
> 
> Reviewed-by: Minchan Kim <minchan.kim@gmail.com>
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>

I disagree that the renaming of the variables is necessary, please simply 
change the while (tsk != start) to use while_each_thread(tsk, start);
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 1/9] oom: don't try to kill oom_unkillable child, KOSAKI Motohiro, (Wed Jun 16, 6:45 pm)

[PATCH 2/9] oom: oom_kill_process() doesn't select kthread ..., KOSAKI Motohiro, (Wed Jun 16, 6:51 pm)

[PATCH 3/9] oom: make oom_unkillable_task() helper function, KOSAKI Motohiro, (Wed Jun 16, 6:51 pm)

[PATCH 4/9] oom: oom_kill_process() need to check p is unk ..., KOSAKI Motohiro, (Wed Jun 16, 6:51 pm)

[PATCH 5/9] oom: cleanup has_intersects_mems_allowed(), KOSAKI Motohiro, (Wed Jun 16, 6:51 pm)

[PATCH 6/9] oom: unify CAP_SYS_RAWIO check into other supe ..., KOSAKI Motohiro, (Wed Jun 16, 6:51 pm)

[PATCH 8/9] oom: give the dying task a higher priority, KOSAKI Motohiro, (Wed Jun 16, 6:51 pm)

[PATCH 9/9] oom: multi threaded process coredump don't mak ..., KOSAKI Motohiro, (Wed Jun 16, 6:51 pm)

[PATCH 7/9] oom: remove child->mm check from oom_kill_proc ..., KOSAKI Motohiro, (Wed Jun 16, 6:51 pm)

Re: [PATCH 6/9] oom: unify CAP_SYS_RAWIO check into other ..., David Rientjes, (Wed Jun 16, 9:18 pm)

Re: [PATCH 4/9] oom: oom_kill_process() need to check p is ..., David Rientjes, (Wed Jun 16, 9:19 pm)

Re: [PATCH 5/9] oom: cleanup has_intersects_mems_allowed(), David Rientjes, (Wed Jun 16, 9:20 pm)

Re: [PATCH 4/9] oom: oom_kill_process() need to check p is ..., KOSAKI Motohiro, (Mon Jun 21, 4:45 am)

Re: [PATCH 5/9] oom: cleanup has_intersects_mems_allowed(), KOSAKI Motohiro, (Mon Jun 21, 4:45 am)

Re: [PATCH 6/9] oom: unify CAP_SYS_RAWIO check into other ..., KOSAKI Motohiro, (Mon Jun 21, 4:46 am)

Re: [PATCH 4/9] oom: oom_kill_process() need to check p is ..., Minchan Kim, (Mon Jun 21, 7:00 am)

Re: [PATCH 4/9] oom: oom_kill_process() need to check p is ..., David Rientjes, (Mon Jun 21, 1:04 pm)

Re: [PATCH 5/9] oom: cleanup has_intersects_mems_allowed(), David Rientjes, (Mon Jun 21, 1:09 pm)

Re: [PATCH 2/9] oom: oom_kill_process() doesn't select kth ..., David Rientjes, (Mon Jun 21, 1:14 pm)

Re: [PATCH 3/9] oom: make oom_unkillable_task() helper fun ..., David Rientjes, (Mon Jun 21, 1:15 pm)

Re: [PATCH 4/9] oom: oom_kill_process() need to check p is ..., KOSAKI Motohiro, (Wed Jun 30, 2:26 am)

Re: [PATCH 5/9] oom: cleanup has_intersects_mems_allowed(), KOSAKI Motohiro, (Wed Jun 30, 2:26 am)