Home » Mailing list archives » linux-kernel » 2010 » June » 17

Re: [PATCH 9/9] oom: give the dying task a higher priority

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: KOSAKI Motohiro
Subject: Re: [PATCH 9/9] oom: give the dying task a higher priority
Date: Wednesday, June 16, 2010 - 6:51 pm

> > +	struct sched_param param = { .sched_priority = 1 };

if p is SCHED_OTHER, no effective. if my understand is correct, that's
only meaningfull if p is SCHED_RR.  that's the reason why I moved this
check into "if (rt_task())".

but honestly I haven't observed this works effectively. so, I agree
this can be removed as Luis mentioned.



--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 1/9] oom: don't try to kill oom_unkillable child, KOSAKI Motohiro, (Wed Jun 16, 4:29 am)
[PATCH 2/9] oom: rename badness() to oom_badness(), KOSAKI Motohiro, (Wed Jun 16, 4:31 am)
[PATCH 3/9] oom: oom_kill_process() doesn't select kthread ..., KOSAKI Motohiro, (Wed Jun 16, 4:32 am)
[PATCH 4/9] oom: oom_kill_process() need to check p is unk ..., KOSAKI Motohiro, (Wed Jun 16, 4:32 am)
[PATCH 5/9] oom: make oom_unkillable_task() helper function, KOSAKI Motohiro, (Wed Jun 16, 4:33 am)
[PATCH 6/9] oom: use same_thread_group instead comparing ->mm, KOSAKI Motohiro, (Wed Jun 16, 4:34 am)
[PATCH 7/9] oom: unify CAP_SYS_RAWIO check into other supe ..., KOSAKI Motohiro, (Wed Jun 16, 4:34 am)
[PATCH 8/9] oom: cleanup has_intersects_mems_allowed(), KOSAKI Motohiro, (Wed Jun 16, 4:35 am)
[PATCH 9/9] oom: give the dying task a higher priority, KOSAKI Motohiro, (Wed Jun 16, 4:36 am)
Re: [PATCH 6/9] oom: use same_thread_group instead compari ..., Oleg Nesterov, (Wed Jun 16, 5:24 am)
Re: [PATCH 1/9] oom: don't try to kill oom_unkillable child, Minchan Kim, (Wed Jun 16, 7:41 am)
Re: [PATCH 2/9] oom: rename badness() to oom_badness(), Minchan Kim, (Wed Jun 16, 7:46 am)
Re: [PATCH 3/9] oom: oom_kill_process() doesn't select kth ..., Minchan Kim, (Wed Jun 16, 8:02 am)
Re: [PATCH 4/9] oom: oom_kill_process() need to check p is ..., Minchan Kim, (Wed Jun 16, 8:07 am)
Re: [PATCH 5/9] oom: make oom_unkillable_task() helper fun ..., Minchan Kim, (Wed Jun 16, 8:10 am)
Re: [PATCH 6/9] oom: use same_thread_group instead compari ..., Minchan Kim, (Wed Jun 16, 8:15 am)
Re: [PATCH 8/9] oom: cleanup has_intersects_mems_allowed(), Minchan Kim, (Wed Jun 16, 8:22 am)
Re: [PATCH 9/9] oom: give the dying task a higher priority, Minchan Kim, (Wed Jun 16, 8:31 am)
Re: [PATCH 9/9] oom: give the dying task a higher priority, Luis Claudio R. Gonc ..., (Wed Jun 16, 12:54 pm)
Re: [PATCH 2/9] oom: rename badness() to oom_badness(), David Rientjes, (Wed Jun 16, 2:40 pm)
Re: [PATCH 3/9] oom: oom_kill_process() doesn't select kth ..., KOSAKI Motohiro, (Wed Jun 16, 6:51 pm)
Re: [PATCH 6/9] oom: use same_thread_group instead compari ..., KOSAKI Motohiro, (Wed Jun 16, 6:51 pm)
Re: [PATCH 4/9] oom: oom_kill_process() need to check p is ..., KOSAKI Motohiro, (Wed Jun 16, 6:51 pm)
Re: [PATCH 9/9] oom: give the dying task a higher priority, KOSAKI Motohiro, (Wed Jun 16, 6:51 pm)
Re: [PATCH 9/9] oom: give the dying task a higher priority, KOSAKI Motohiro, (Wed Jun 16, 6:51 pm)
Re: [PATCH 1/9] oom: don't try to kill oom_unkillable child, KOSAKI Motohiro, (Wed Jun 16, 6:51 pm)
Re: [PATCH 2/9] oom: rename badness() to oom_badness(), KOSAKI Motohiro, (Wed Jun 16, 6:51 pm)
Re: [PATCH 6/9] oom: use same_thread_group instead compari ..., KOSAKI Motohiro, (Wed Jun 16, 6:51 pm)