Re: [PATCH -v18 00/37] Use lmb with x86

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Benjamin Herrenschmidt
Date: Wednesday, June 16, 2010 - 1:41 am

On Tue, 2010-06-15 at 23:10 -0700, Linus Torvalds wrote:

I -think- the point is that once that's done, you can remove a whole lot
of gunk that was added such as the kernel/range.c caca, etc...
(basically, x86 gunk gratuituously made generic and that should really
just die instead).

However, I do have some issues with some aspects of Yinghai port to x86,
where instead of removing the old crap, it adds a layer that turns the
LMB into that old crap which is then turned back into something else...
not too sure, it's definitely a bit weird.

So using LMB per-se is a good idea, because it replaces whatever other
range management/allocator you have there. But it has to be done "right"
and I think we need Thomas, Ingo and/or Peter to give that a good look
and see whether what we have there is "right" or not as far as x86 is
concerned.

Cheers,
Ben.


--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH -v18 00/37] Use lmb with x86, Yinghai Lu, (Tue Jun 15, 10:42 pm)
[PATCH 04/37] lmb: Export LMB_ERROR again, Yinghai Lu, (Tue Jun 15, 10:42 pm)
[PATCH 07/37] lmb: Add lmb_find_in_range(), Yinghai Lu, (Tue Jun 15, 10:42 pm)
[PATCH 08/37] x86, lmb: Add lmb_find_in_range_size(), Yinghai Lu, (Tue Jun 15, 10:42 pm)
[PATCH 10/37] x86, lmb: Add lmb_to_bootmem(), Yinghai Lu, (Tue Jun 15, 10:42 pm)
[PATCH 14/37] lmb: Add find_memory_core_early(), Yinghai Lu, (Tue Jun 15, 10:42 pm)
[PATCH 15/37] x86, lmb: Add lmb_find_in_range_node(), Yinghai Lu, (Tue Jun 15, 10:42 pm)
[PATCH 16/37] x86, lmb: Add lmb_free_memory_in_range(), Yinghai Lu, (Tue Jun 15, 10:42 pm)
[PATCH 17/37] x86, lmb: Add lmb_memory_in_range(), Yinghai Lu, (Tue Jun 15, 10:42 pm)
[PATCH 20/37] x86: Use lmb to replace early_res, Yinghai Lu, (Tue Jun 15, 10:42 pm)
[PATCH 22/37] x86: Remove not used early_res code, Yinghai Lu, (Tue Jun 15, 10:42 pm)
[PATCH 30/37] x86: Add sanitize_e820_map(), Yinghai Lu, (Tue Jun 15, 10:42 pm)
[PATCH 31/37] x86: Change e820_saved to __initdata, Yinghai Lu, (Tue Jun 15, 10:42 pm)
[PATCH 32/37] x86: Align e820 ram range to page, Yinghai Lu, (Tue Jun 15, 10:42 pm)
[PATCH 34/37] x86: Add get_centaur_ram_top(), Yinghai Lu, (Tue Jun 15, 10:42 pm)
[PATCH 35/37] x86: Change e820_any_mapped() to __init, Yinghai Lu, (Tue Jun 15, 10:42 pm)
[PATCH 37/37] x86: make e820 to be __initdata, Yinghai Lu, (Tue Jun 15, 10:42 pm)
Re: [PATCH -v18 00/37] Use lmb with x86, Linus Torvalds, (Tue Jun 15, 11:10 pm)
Re: [PATCH -v18 00/37] Use lmb with x86, Benjamin Herrenschmidt, (Wed Jun 16, 1:41 am)
Re: [PATCH -v18 00/37] Use lmb with x86, Yinghai Lu, (Wed Jun 16, 8:43 am)