Home » Mailing list archives » linux-kernel » 2010 » June » 15

Re: [PATCH 11/12] vmscan: Write out dirty pages in batch

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Nick Piggin
Subject: Re: [PATCH 11/12] vmscan: Write out dirty pages in batch
Date: Tuesday, June 15, 2010 - 4:13 am

On Tue, Jun 15, 2010 at 06:53:41AM -0400, Christoph Hellwig wrote:

It's just a pretty simple use-after-free. Maybe people forget it because
->writepage is an asynchronous API.



There shouldn't be a problem _holding_ the locks, but there is a problem
waiting for multiple locks out of page->index order.

But there is a problem with holding the lock of a lot of pages while
calling ->writepage on them. So yeah, you can't do that.

Hmm, I should rediff that lockdep page_lock patch and get it merged.
(although I don't know if that can catch these all these problems easily)

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 0/12] Avoid overflowing of stack during page reclaim V2, Mel Gorman, (Mon Jun 14, 4:17 am)
[PATCH 01/12] tracing, vmscan: Add trace events for kswapd ..., Mel Gorman, (Mon Jun 14, 4:17 am)
[PATCH 02/12] tracing, vmscan: Add trace events for LRU pa ..., Mel Gorman, (Mon Jun 14, 4:17 am)
[PATCH 03/12] tracing, vmscan: Add trace event when a page ..., Mel Gorman, (Mon Jun 14, 4:17 am)
[PATCH 04/12] tracing, vmscan: Add a postprocessing script ..., Mel Gorman, (Mon Jun 14, 4:17 am)
[PATCH 05/12] vmscan: kill prev_priority completely, Mel Gorman, (Mon Jun 14, 4:17 am)
[PATCH 06/12] vmscan: simplify shrink_inactive_list(), Mel Gorman, (Mon Jun 14, 4:17 am)
[PATCH 07/12] vmscan: Remove unnecessary temporary vars in ..., Mel Gorman, (Mon Jun 14, 4:17 am)
[PATCH 08/12] vmscan: Setup pagevec as late as possible in ..., Mel Gorman, (Mon Jun 14, 4:17 am)
[PATCH 09/12] vmscan: Setup pagevec as late as possible in ..., Mel Gorman, (Mon Jun 14, 4:17 am)
[PATCH 10/12] vmscan: Update isolated page counters outsid ..., Mel Gorman, (Mon Jun 14, 4:17 am)
[PATCH 11/12] vmscan: Write out dirty pages in batch, Mel Gorman, (Mon Jun 14, 4:17 am)
Re: [PATCH 0/12] Avoid overflowing of stack during page re ..., Christoph Hellwig, (Mon Jun 14, 8:10 am)
Re: [PATCH 01/12] tracing, vmscan: Add trace events for ks ..., Rik van Riel, (Mon Jun 14, 8:45 am)
Re: [PATCH 02/12] tracing, vmscan: Add trace events for LR ..., Rik van Riel, (Mon Jun 14, 9:47 am)
Re: [PATCH 03/12] tracing, vmscan: Add trace event when a ..., Rik van Riel, (Mon Jun 14, 9:48 am)
Re: [PATCH 04/12] tracing, vmscan: Add a postprocessing sc ..., Rik van Riel, (Mon Jun 14, 10:55 am)
Re: [PATCH 05/12] vmscan: kill prev_priority completely, Rik van Riel, (Mon Jun 14, 11:04 am)
Re: [PATCH 06/12] vmscan: simplify shrink_inactive_list(), Rik van Riel, (Mon Jun 14, 11:06 am)
Re: [PATCH 07/12] vmscan: Remove unnecessary temporary var ..., Rik van Riel, (Mon Jun 14, 11:14 am)
Re: [PATCH 09/12] vmscan: Setup pagevec as late as possibl ..., Rik van Riel, (Mon Jun 14, 12:24 pm)
Re: [PATCH 10/12] vmscan: Update isolated page counters ou ..., Rik van Riel, (Mon Jun 14, 12:42 pm)
Re: [PATCH 01/12] tracing, vmscan: Add trace events for ks ..., Larry Woodman, (Mon Jun 14, 2:01 pm)
Re: [PATCH 02/12] tracing, vmscan: Add trace events for LR ..., Larry Woodman, (Mon Jun 14, 2:02 pm)
Re: [PATCH 03/12] tracing, vmscan: Add trace event when a ..., Larry Woodman, (Mon Jun 14, 2:02 pm)
Re: [PATCH 04/12] tracing, vmscan: Add a postprocessing sc ..., Larry Woodman, (Mon Jun 14, 2:03 pm)
Re: [PATCH 11/12] vmscan: Write out dirty pages in batch, Rik van Riel, (Mon Jun 14, 2:13 pm)
Re: [PATCH 11/12] vmscan: Write out dirty pages in batch, Dave Chinner, (Mon Jun 14, 4:11 pm)
Re: [PATCH 11/12] vmscan: Write out dirty pages in batch, Andrew Morton, (Mon Jun 14, 4:21 pm)
Re: [PATCH 0/12] Avoid overflowing of stack during page re ..., KAMEZAWA Hiroyuki, (Mon Jun 14, 5:08 pm)
Re: [PATCH 11/12] vmscan: Write out dirty pages in batch, Dave Chinner, (Mon Jun 14, 5:39 pm)
Re: [PATCH 11/12] vmscan: Write out dirty pages in batch, Rik van Riel, (Mon Jun 14, 6:16 pm)
Re: [PATCH 11/12] vmscan: Write out dirty pages in batch, Andrew Morton, (Mon Jun 14, 6:39 pm)
Re: [PATCH 11/12] vmscan: Write out dirty pages in batch, Andrew Morton, (Mon Jun 14, 6:45 pm)
Re: [PATCH 11/12] vmscan: Write out dirty pages in batch, Dave Chinner, (Mon Jun 14, 8:20 pm)
Re: [PATCH 11/12] vmscan: Write out dirty pages in batch, Rik van Riel, (Mon Jun 14, 9:08 pm)
Re: [PATCH 11/12] vmscan: Write out dirty pages in batch, Andrew Morton, (Mon Jun 14, 9:15 pm)
Re: [PATCH 11/12] vmscan: Write out dirty pages in batch, Andrew Morton, (Mon Jun 14, 9:37 pm)
Re: [PATCH 11/12] vmscan: Write out dirty pages in batch, Nick Piggin, (Mon Jun 14, 10:12 pm)
[patch] mm: vmscan fix mapping use after free, Nick Piggin, (Mon Jun 14, 10:43 pm)
Re: [PATCH 11/12] vmscan: Write out dirty pages in batch, Dave Chinner, (Mon Jun 14, 11:36 pm)
Re: [PATCH 06/12] vmscan: simplify shrink_inactive_list(), Mel Gorman, (Tue Jun 15, 3:13 am)
Re: [PATCH 11/12] vmscan: Write out dirty pages in batch, Mel Gorman, (Tue Jun 15, 3:18 am)
Re: [PATCH 08/12] vmscan: Setup pagevec as late as possibl ..., Christoph Hellwig, (Tue Jun 15, 3:47 am)
Re: [PATCH 11/12] vmscan: Write out dirty pages in batch, Christoph Hellwig, (Tue Jun 15, 3:53 am)
Re: [PATCH 11/12] vmscan: Write out dirty pages in batch, Nick Piggin, (Tue Jun 15, 3:55 am)
Re: [PATCH 11/12] vmscan: Write out dirty pages in batch, Christoph Hellwig, (Tue Jun 15, 3:57 am)
Re: [PATCH 11/12] vmscan: Write out dirty pages in batch, Christoph Hellwig, (Tue Jun 15, 4:01 am)
Re: [PATCH 11/12] vmscan: Write out dirty pages in batch, Christoph Hellwig, (Tue Jun 15, 4:08 am)
Re: [PATCH 11/12] vmscan: Write out dirty pages in batch, Christoph Hellwig, (Tue Jun 15, 4:10 am)
Re: [PATCH 11/12] vmscan: Write out dirty pages in batch, Mel Gorman, (Tue Jun 15, 4:11 am)
Re: [PATCH 11/12] vmscan: Write out dirty pages in batch, Nick Piggin, (Tue Jun 15, 4:13 am)
Re: [PATCH 11/12] vmscan: Write out dirty pages in batch, Nick Piggin, (Tue Jun 15, 4:20 am)
Re: [PATCH 11/12] vmscan: Write out dirty pages in batch, Mel Gorman, (Tue Jun 15, 4:43 am)
Re: [PATCH 0/12] Avoid overflowing of stack during page re ..., Mel Gorman, (Tue Jun 15, 4:45 am)
Re: [PATCH 0/12] Avoid overflowing of stack during page re ..., Mel Gorman, (Tue Jun 15, 4:49 am)
Re: [PATCH 11/12] vmscan: Write out dirty pages in batch, tytso, (Tue Jun 15, 6:07 am)
Re: [patch] mm: vmscan fix mapping use after free, Mel Gorman, (Tue Jun 15, 6:23 am)
Re: [PATCH 11/12] vmscan: Write out dirty pages in batch, Rik van Riel, (Tue Jun 15, 6:32 am)
Re: [PATCH 11/12] vmscan: Write out dirty pages in batch, Mel Gorman, (Tue Jun 15, 8:44 am)
Re: [PATCH 08/12] vmscan: Setup pagevec as late as possibl ..., Mel Gorman, (Tue Jun 15, 8:56 am)
Re: [PATCH 11/12] vmscan: Write out dirty pages in batch, Dave Chinner, (Tue Jun 15, 4:20 pm)
Re: [PATCH 11/12] vmscan: Write out dirty pages in batch, Nick Piggin, (Tue Jun 15, 11:04 pm)
Re: [PATCH 05/12] vmscan: kill prev_priority completely, Andrew Morton, (Wed Jun 16, 4:37 pm)
Re: [PATCH 08/12] vmscan: Setup pagevec as late as possibl ..., Andrew Morton, (Wed Jun 16, 4:43 pm)
Re: [PATCH 05/12] vmscan: kill prev_priority completely, Rik van Riel, (Wed Jun 16, 4:45 pm)
Re: [PATCH 09/12] vmscan: Setup pagevec as late as possibl ..., Andrew Morton, (Wed Jun 16, 4:48 pm)
Re: [PATCH 05/12] vmscan: kill prev_priority completely, Andrew Morton, (Wed Jun 16, 5:18 pm)
Re: [PATCH 05/12] vmscan: kill prev_priority completely, Rik van Riel, (Wed Jun 16, 5:34 pm)
Re: [PATCH 08/12] vmscan: Setup pagevec as late as possibl ..., Mel Gorman, (Thu Jun 17, 3:30 am)
Re: [PATCH 09/12] vmscan: Setup pagevec as late as possibl ..., Mel Gorman, (Thu Jun 17, 3:46 am)
Re: [PATCH 05/12] vmscan: kill prev_priority completely, KOSAKI Motohiro, (Fri Jun 25, 1:29 am)
Re: [PATCH 05/12] vmscan: kill prev_priority completely, Mel Gorman, (Mon Jun 28, 3:35 am)