Re: [PATCH 4/8]drivers:tmp.c Fix warning: variable 'rc' set but not used

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Jean Delvare
Date: Tuesday, June 15, 2010 - 2:19 am

On Tue, 15 Jun 2010 07:29:44 +0200, Peter Stuge wrote:

Justin, I think you're on the wrong track here. You seem to be in a
hurry to fix all these warnings generated by gcc 4.6. There is no hurry
at all. Most warnings are false positives, and actual bugs may take
some thinking and knowledge. So rushing is not needed and not
desirable. Going too fast, you might even introduce new bugs, or
prevent old bugs from being properly fixed.

Warnings are a chance to make the code better. The goal is not to fix
them quickly, but to fix them properly. If this is not your intent,
then please stop immediately and let others deal with these warnings.
If you want to help, this is appreciated, but what we need it quality,
not quantity.


Or just LXR online if you don't want to install anything:

http://lxr.linux.no/linux
http://lxr.linux.no/#linux+v2.6.34/drivers/char/tpm/tpm.c#L451

-- 
Jean Delvare
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/8] Fix gcc 4.6.0 set but not used warning messages. , Justin P. Mattock, (Mon Jun 14, 1:26 pm)
[PATCH 1/8]reiserfs:stree.c Fix variable set but not used., Justin P. Mattock, (Mon Jun 14, 1:26 pm)
[PATCH 2/8]bluetooth/hci_ldisc.c Fix warning: variable 'tt ..., Justin P. Mattock, (Mon Jun 14, 1:26 pm)
[PATCH 3/8]char/hpet.c Fix variable 'hpet' set but not used, Justin P. Mattock, (Mon Jun 14, 1:26 pm)
[PATCH 4/8]drivers:tmp.c Fix warning: variable 'rc' set bu ..., Justin P. Mattock, (Mon Jun 14, 1:26 pm)
[PATCH 5/8]drm:drm_gem Fix warning: variable 'dev' set bu ..., Justin P. Mattock, (Mon Jun 14, 1:26 pm)
[PATCH 6/8]i2c:i2c_core Fix warning: variable 'dummy' set ..., Justin P. Mattock, (Mon Jun 14, 1:26 pm)
[PATCH 7/8]ieee1394/sdp2 Fix warning: variable 'unit_chara ..., Justin P. Mattock, (Mon Jun 14, 1:26 pm)
[PATCH 8/8]tuners:tuner-simple Fix warning: variable 'tun' ..., Justin P. Mattock, (Mon Jun 14, 1:26 pm)
Re: [PATCH 6/8]i2c:i2c_core Fix warning: variable 'dummy' ..., Justin P. Mattock, (Mon Jun 14, 2:06 pm)
Re: [PATCH 1/8]reiserfs:stree.c Fix variable set but not used., Justin P. Mattock, (Mon Jun 14, 2:09 pm)
Re: [PATCH 1/8]reiserfs:stree.c Fix variable set but not used., Justin P. Mattock, (Mon Jun 14, 2:21 pm)
[PATCH] ieee1394: sbp2: remove unused code, Stefan Richter, (Mon Jun 14, 2:44 pm)
Re: [PATCH] ieee1394: sbp2: remove unused code, Justin P. Mattock, (Mon Jun 14, 3:35 pm)
[No subject], Stefan Richter, (Mon Jun 14, 4:22 pm)
Re:, Justin P. Mattock, (Mon Jun 14, 4:58 pm)
[PATCH] ieee1394: remove unused variables, Stefan Richter, (Mon Jun 14, 5:00 pm)
Re: [PATCH] ieee1394: sbp2: remove unused code, Stefan Richter, (Mon Jun 14, 5:05 pm)
Re: (no subject), Stefan Richter, (Mon Jun 14, 5:08 pm)
Re: [PATCH] ieee1394: sbp2: remove unused code, Justin P. Mattock, (Mon Jun 14, 6:59 pm)
Re: [PATCH 4/8]drivers:tmp.c Fix warning: variable 'rc' se ..., Justin P. Mattock, (Mon Jun 14, 7:12 pm)
Re: [PATCH 4/8]drivers:tmp.c Fix warning: variable 'rc' se ..., Justin P. Mattock, (Mon Jun 14, 8:56 pm)
Re: [PATCH 8/8]tuners:tuner-simple Fix warning: variable ' ..., Mauro Carvalho Chehab, (Mon Jun 14, 10:16 pm)
Re: [PATCH 8/8]tuners:tuner-simple Fix warning: variable ' ..., Justin P. Mattock, (Mon Jun 14, 10:37 pm)
Re: [PATCH 8/8]tuners:tuner-simple Fix warning: variable ' ..., Justin P. Mattock, (Mon Jun 14, 10:50 pm)
Re: [PATCH 4/8]drivers:tmp.c Fix warning: variable 'rc' se ..., Justin P. Mattock, (Mon Jun 14, 10:58 pm)
Re: [PATCH 4/8]drivers:tmp.c Fix warning: variable 'rc' se ..., Justin P. Mattock, (Tue Jun 15, 12:27 am)
Re: [PATCH 4/8]drivers:tmp.c Fix warning: variable 'rc' se ..., Justin P. Mattock, (Tue Jun 15, 1:30 am)
Re: [PATCH 4/8]drivers:tmp.c Fix warning: variable 'rc' se ..., Jean Delvare, (Tue Jun 15, 2:19 am)
Re: [PATCH 4/8]drivers:tmp.c Fix warning: variable 'rc' se ..., Justin P. Mattock, (Tue Jun 15, 2:41 am)
Re: [PATCH 6/8]i2c:i2c_core Fix warning: variable 'dummy' ..., Justin P. Mattock, (Tue Jun 15, 9:51 am)
Re: [PATCH 7/8]ieee1394/sdp2 Fix warning: variable 'unit_c ..., Justin P. Mattock, (Tue Jun 15, 9:52 am)
Re: [PATCH 4/8]drivers:tmp.c Fix warning: variable 'rc' se ..., Justin P. Mattock, (Tue Jun 15, 12:36 pm)