Re: [RFC PATCH 0/6] Do not call ->writepage[s] from direct reclaim and use a_ops->writepages() where possible

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

On Tue,  8 Jun 2010 10:02:19 +0100 Mel Gorman <mel@csn.ul.ie> wrote:


No it isn't.  If we have a pile of file-contiguous, disk-contiguous
dirty pages on the tail of the LRU then the single writepage()s will
work just fine due to request merging.



Look.  This is getting very frustrating.  I keep saying the same thing
and keep getting ignored.  Once more:

	WE BROKE IT!

	PLEASE STOP WRITING CODE!

	FIND OUT HOW WE BROKE IT!

Loud enough yet?

It used to be the case that only very small amounts of IO occurred in
page reclaim - the vast majority of writeback happened within
write()->balance_dirty_pages().  Then (and I think it was around 2.6.12)
we broke it, and page reclaim started doing lots of writeout.

So the thing to do is to either find out how we broke it and see if it
can be repaired, or change the VM so that it doesn't do so much
LRU-based writeout.  Rather than fiddling around trying to make the
we-broke-it code run its brokenness faster.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [RFC PATCH 0/6] Do not call ->writepage[s] from direct ..., Andrew Morton, (Thu Jun 10, 10:57 pm)
Re: [PATCH 6/6] vmscan: Do not writeback pages in direct r ..., Christoph Hellwig, (Fri Jun 11, 9:25 am)
Re: [PATCH 5/6] vmscan: Write out ranges of pages contiguo ..., Christoph Hellwig, (Fri Jun 11, 9:27 am)
Re: [PATCH 6/6] vmscan: Do not writeback pages in direct r ..., Christoph Hellwig, (Fri Jun 11, 10:49 am)