Home » Mailing list archives » linux-kernel » 2010 » May » 7

[patch] exofs: confusion between kmap() and kmap_atomic() api

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Dan Carpenter
Subject: [patch] exofs: confusion between kmap() and kmap_atomic() api
Date: Friday, May 7, 2010 - 2:05 am

For kmap_atomic() we call kunmap_atomic() on the returned pointer.
That's different from kmap() and kunmap() and so it's easy to get them
backwards.

Signed-off-by: Dan Carpenter <error27@gmail.com>

diff --git a/fs/exofs/dir.c b/fs/exofs/dir.c
index 4cfab1c..d91e9d8 100644
--- a/fs/exofs/dir.c
+++ b/fs/exofs/dir.c
@@ -608,7 +608,7 @@ int exofs_make_empty(struct inode *inode, struct inode *parent)
 	de->inode_no = cpu_to_le64(parent->i_ino);
 	memcpy(de->name, PARENT_DIR, sizeof(PARENT_DIR));
 	exofs_set_de_type(de, inode);
-	kunmap_atomic(page, KM_USER0);
+	kunmap_atomic(kaddr, KM_USER0);
 	err = exofs_commit_chunk(page, 0, chunk_size);
 fail:
 	page_cache_release(page);
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[patch] exofs: confusion between kmap() and kmap_atomic() api, Dan Carpenter, (Fri May 7, 2:05 am)
Re: [patch] exofs: confusion between kmap() and kmap_atomi ..., Boaz Harrosh, (Sun May 9, 3:16 am)
Re: [patch] exofs: confusion between kmap() and kmap_atomi ..., Dan Carpenter, (Mon May 10, 9:15 am)
Re: [patch] exofs: confusion between kmap() and kmap_atomi ..., Andrew Morton, (Mon May 10, 4:03 pm)
Re: [patch] exofs: confusion between kmap() and kmap_atomi ..., Boaz Harrosh, (Tue May 11, 1:05 am)