Re: [PATCH -next] usb gadget webcam: depends on VIDEO_DEV

Previous thread: [git pull] drm + gpu fixes by Dave Airlie on Tuesday, May 4, 2010 - 7:04 pm. (1 message)

Next thread: [PATCH][RESEND] intel_txt: enable SMX flag for VMXON in KVM by Shane Wang on Wednesday, May 5, 2010 - 3:38 am. (2 messages)
From: Stephen Rothwell
Date: Tuesday, May 4, 2010 - 7:34 pm

Hi all,

Changes since 20100504:

Dropped trees: tmio-mmc (long unresolved conflicts and unable to fetch)
	hwlat (at the maintainer's request)

----------------------------------------------------------------------------

I have created today's linux-next tree at
git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
(patches at http://www.kernel.org/pub/linux/kernel/v2.6/next/ ).  If you
are tracking the linux-next tree using git, you should not use "git pull"
to do so as that will try to merge the new linux-next release with the
old one.  You should use "git fetch" as mentioned in the FAQ on the wiki
(see below).

You can see which trees have been included by looking in the Next/Trees
file in the source.  There are also quilt-import.log and merge.log files
in the Next directory.  Between each merge, the tree was built with
a ppc64_defconfig for powerpc and an allmodconfig for x86_64. After the
final fixups (if any), it is also built with powerpc allnoconfig (32 and
64 bit), ppc44x_defconfig and allyesconfig (minus
CONFIG_PROFILE_ALL_BRANCHES - this fails its final link) and i386, sparc
and sparc64 defconfig. These builds also have
CONFIG_ENABLE_WARN_DEPRECATED, CONFIG_ENABLE_MUST_CHECK and
CONFIG_DEBUG_INFO disabled when necessary.

Below is a summary of the state of the merge.

We are up to 162 trees (counting Linus' and 22 trees of patches pending
for Linus' tree), more are welcome (even if they are currently empty).
Thanks to those who have contributed, and to those who haven't, please do.

Status of my local build tests will be at
http://kisskb.ellerman.id.au/linux-next .  If maintainers want to give
advice about cross compilers/configs that work, we are always open to add
more builds.

Thanks to Jan Dittmer for adding the linux-next tree to his build tests
at http://l4x.org/k/ , the guys at http://test.kernel.org/ and Randy
Dunlap for doing many randconfig builds.

There is a wiki covering stuff to do with linux-next ...
From: Randy Dunlap
Date: Wednesday, May 5, 2010 - 3:46 pm

From: Randy Dunlap <randy.dunlap@oracle.com>

g_webcam uses v4l[2] interfaces, so it should depend on VIDEO_DEV.

ERROR: "v4l2_event_unsubscribe" [drivers/usb/gadget/g_webcam.ko] undefined!
ERROR: "v4l2_event_queue" [drivers/usb/gadget/g_webcam.ko] undefined!
ERROR: "video_device_release" [drivers/usb/gadget/g_webcam.ko] undefined!
ERROR: "video_usercopy" [drivers/usb/gadget/g_webcam.ko] undefined!
ERROR: "v4l2_event_dequeue" [drivers/usb/gadget/g_webcam.ko] undefined!
ERROR: "video_register_device" [drivers/usb/gadget/g_webcam.ko] undefined!
ERROR: "video_device_alloc" [drivers/usb/gadget/g_webcam.ko] undefined!
ERROR: "v4l2_event_subscribe" [drivers/usb/gadget/g_webcam.ko] undefined!
ERROR: "video_unregister_device" [drivers/usb/gadget/g_webcam.ko] ndefined!
ERROR: "v4l2_event_pending" [drivers/usb/gadget/g_webcam.ko] undefined!
ERROR: "v4l2_fh_init" [drivers/usb/gadget/g_webcam.ko] undefined!
ERROR: "v4l2_event_init" [drivers/usb/gadget/g_webcam.ko] undefined!
ERROR: "video_devdata" [drivers/usb/gadget/g_webcam.ko] undefined!
ERROR: "v4l2_event_alloc" [drivers/usb/gadget/g_webcam.ko] undefined!
ERROR: "v4l2_fh_add" [drivers/usb/gadget/g_webcam.ko] undefined!
ERROR: "v4l2_fh_del" [drivers/usb/gadget/g_webcam.ko] undefined!
ERROR: "v4l2_fh_exit" [drivers/usb/gadget/g_webcam.ko] undefined!

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 drivers/usb/gadget/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- linux-next-20100505.orig/drivers/usb/gadget/Kconfig
+++ linux-next-20100505/drivers/usb/gadget/Kconfig
@@ -879,6 +879,7 @@ config USB_G_HID
 # or video class gadget drivers), or specific hardware, here.
 config USB_G_WEBCAM
 	tristate "USB Webcam Gadget"
+	depends on VIDEO_DEV
 	help
 	  The Webcam Gadget acts as a composite USB Audio and Video Class
 	  device. It provides a userspace API to process UVC control requests
--

From: Laurent Pinchart
Date: Thursday, May 6, 2010 - 12:57 am

Hi Randy,



Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

-- 
Regards,

Laurent Pinchart
--

From: Randy Dunlap
Date: Wednesday, May 5, 2010 - 3:44 pm

From: Randy Dunlap <randy.dunlap@oracle.com>

vivi uses find_font(), which is only available when FONTS
is enabled, so make vivi depend on FONTS.

ERROR: "find_font" [drivers/media/video/vivi.ko] undefined!

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 drivers/media/video/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20100505.orig/drivers/media/video/Kconfig
+++ linux-next-20100505/drivers/media/video/Kconfig
@@ -559,7 +559,7 @@ config VIDEO_DAVINCI_VPIF
 
 config VIDEO_VIVI
 	tristate "Virtual Video Driver"
-	depends on VIDEO_DEV && VIDEO_V4L2 && !SPARC32 && !SPARC64
+	depends on VIDEO_DEV && VIDEO_V4L2 && !SPARC32 && !SPARC64 && FONTS
 	select FONT_8x16
 	select VIDEOBUF_VMALLOC
 	default n
--

From: Randy Dunlap
Date: Wednesday, May 5, 2010 - 3:45 pm

From: Randy Dunlap <randy.dunlap@oracle.com>

rar_register driver uses PCI interfaces and PCI devices, so it
should depend on PCI.

Also format the Kconfig help text as normally done.

drivers/staging/rar_register/rar_register.c:623: error: implicit declaration of function 'pci_dev_get'
drivers/staging/rar_register/rar_register.c:623: warning: assignment makes pointer from integer without a cast

Note:  The memrar driver selects this driver's Kconfig symbol, even when
PCI is not enabled.  That select could be changed to
	select RAR_REGISTER if PCI
but that would still result in build errors when PCI is not enabled, namely:
drivers/built-in.o: In function `memrar_fini_rar_resources':
memrar_handler.c:(.text+0x2391b7): undefined reference to `unregister_rar'
drivers/built-in.o: In function `memrar_registration_callback':
memrar_handler.c:(.text+0x23925a): undefined reference to `rar_get_address'
drivers/built-in.o: In function `memrar_init':
memrar_handler.c:(.init.text+0x12c7b): undefined reference to `register_rar'
memrar_handler.c:(.init.text+0x12c97): undefined reference to `register_rar'

Does anyone have suggestions for this?

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 drivers/staging/rar_register/Kconfig |   28 ++++++++++++-------------
 1 file changed, 14 insertions(+), 14 deletions(-)

--- linux-next-20100505.orig/drivers/staging/rar_register/Kconfig
+++ linux-next-20100505/drivers/staging/rar_register/Kconfig
@@ -8,23 +8,23 @@ menu "RAR Register Driver"
 #
 config RAR_REGISTER
 	tristate "Restricted Access Region Register Driver"
+	depends on PCI
 	default n
 	---help---
-		This driver allows other kernel drivers access to the
-		contents of the restricted access region control
-		registers.
+	  This driver allows other kernel drivers access to the
+	  contents of the restricted access region control registers.
 
-		The restricted access region control registers
-		(rar_registers) are used to pass address and
-		locking information on ...
From: Randy Dunlap
Date: Wednesday, May 5, 2010 - 7:32 pm

memrar currently selects RAR_REGISTER, but I'll be happy to change
that to depends on...

-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--

Previous thread: [git pull] drm + gpu fixes by Dave Airlie on Tuesday, May 4, 2010 - 7:04 pm. (1 message)

Next thread: [PATCH][RESEND] intel_txt: enable SMX flag for VMXON in KVM by Shane Wang on Wednesday, May 5, 2010 - 3:38 am. (2 messages)