Home » Mailing list archives » linux-kernel » 2010 » May » 5

[PATCH linux-next] irq: Clear CPU mask in affinity_hint when none is provided

Previous thread: [PATCH] perf: Fix static strings treated like dynamic ones by Frederic Weisbecker on Wednesday, May 5, 2010 - 1:27 pm. (1 message)

Next thread: [PATCH RFC] virtio: put last seen used index into ring itself by Michael S. Tsirkin on Wednesday, May 5, 2010 - 1:58 pm. (31 messages)
[view original message]
From: Peter P Waskiewicz Jr
Subject: [PATCH linux-next] irq: Clear CPU mask in affinity_hint when none is provided
Date: Wednesday, May 5, 2010 - 1:56 pm

When an interrupt is disabled and torn down, the CPU mask
returned through affinity_hint right now is all CPUs.  Also, for
drivers that don't provide an affinity_hint mask, this can be
misleading.  There should be no hint at all, meaning an empty
CPU mask.

Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
---

 kernel/irq/proc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/irq/proc.c b/kernel/irq/proc.c
index e1e7408..9ffa24d 100644
--- a/kernel/irq/proc.c
+++ b/kernel/irq/proc.c
@@ -45,7 +45,7 @@ static int irq_affinity_hint_proc_show(struct seq_file *m, void *v)
 	if (desc->affinity_hint)
 		cpumask_copy(mask, desc->affinity_hint);
 	else
-		cpumask_setall(mask);
+		cpumask_clear(mask);
 	raw_spin_unlock_irqrestore(&desc->lock, flags);
 
 	seq_cpumask(m, mask);

--


[ message continues ]
[view original message]
From: tip-bot for Peter P Waskiewicz Jr
Subject: [tip:irq/core] genirq: Clear CPU mask in affinity_hint when none is provided
Date: Wednesday, May 12, 2010 - 2:27 am

Commit-ID:  4308ad801193f14ff42cb746da37cf07e35f0d08
Gitweb:     http://git.kernel.org/tip/4308ad801193f14ff42cb746da37cf07e35f0d08
Author:     Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
AuthorDate: Wed, 5 May 2010 13:56:42 -0700
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Wed, 12 May 2010 11:23:34 +0200

genirq: Clear CPU mask in affinity_hint when none is provided

When an interrupt is disabled and torn down, the CPU mask returned
through affinity_hint right now is all CPUs. Also, for drivers that
don't provide an affinity_hint mask, this can be misleading. There
should be no hint at all, meaning an empty CPU mask.

[ tglx: use zalloc_cpumask_var instead of clearing it under the lock ]

Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Cc: davem@davemloft.net
Cc: arjan@linux.jf.intel.com
Cc: bhutchings@solarflare.com
LKML-Reference: <20100505205638.5426.87189.stgit@ppwaskie-hc2.jf.intel.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 kernel/irq/proc.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/kernel/irq/proc.c b/kernel/irq/proc.c
index 4f9427a..09a2ee5 100644
--- a/kernel/irq/proc.c
+++ b/kernel/irq/proc.c
@@ -38,14 +38,12 @@ static int irq_affinity_hint_proc_show(struct seq_file *m, void *v)
 	unsigned long flags;
 	cpumask_var_t mask;
 
-	if (!alloc_cpumask_var(&mask, GFP_KERNEL))
+	if (!zalloc_cpumask_var(&mask, GFP_KERNEL))
 		return -ENOMEM;
 
 	raw_spin_lock_irqsave(&desc->lock, flags);
 	if (desc->affinity_hint)
 		cpumask_copy(mask, desc->affinity_hint);
-	else
-		cpumask_setall(mask);
 	raw_spin_unlock_irqrestore(&desc->lock, flags);
 
 	seq_cpumask(m, mask);
--


[ message continues ]
Previous thread: [PATCH] perf: Fix static strings treated like dynamic ones by Frederic Weisbecker on Wednesday, May 5, 2010 - 1:27 pm. (1 message)

Next thread: [PATCH RFC] virtio: put last seen used index into ring itself by Michael S. Tsirkin on Wednesday, May 5, 2010 - 1:58 pm. (31 messages)