Home » Mailing list archives » linux-kernel » 2010 » May » 5

[PATCH 1/4] perf report: Make dso__calc_col_width agree with hist_entry__dso_snprintf

Previous thread: [PATCH 2/4] perf/record: simplify TRACE_INFO tracepoint check by Arnaldo Carvalho de Melo on Wednesday, May 5, 2010 - 7:30 am. (1 message)

Next thread: [PATCH 3/4] perf list: Add explanation about raw hardware event descriptors by Arnaldo Carvalho de Melo on Wednesday, May 5, 2010 - 7:30 am. (1 message)
[view original message]
From: Arnaldo Carvalho de Melo
Subject: [PATCH 1/4] perf report: Make dso__calc_col_width agree with hist_entry__dso_snprintf
Date: Wednesday, May 5, 2010 - 7:30 am

From: Arnaldo Carvalho de Melo <acme@redhat.com>

The first was always using the ->long_name, while the later used
->short_name if verbose was not set, resulting in the dso column to be
much wider than needed most of the time.

Cc: Frédéric Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Tom Zanussi <tzanussi@gmail.com>
LKML-Reference: <new-submission>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/event.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/tools/perf/util/event.c b/tools/perf/util/event.c
index 2477270..23d5dfd 100644
--- a/tools/perf/util/event.c
+++ b/tools/perf/util/event.c
@@ -626,8 +626,10 @@ static void dso__calc_col_width(struct dso *self)
 	if (!symbol_conf.col_width_list_str && !symbol_conf.field_sep &&
 	    (!symbol_conf.dso_list ||
 	     strlist__has_entry(symbol_conf.dso_list, self->name))) {
-		unsigned int slen = strlen(self->name);
-		if (slen > dsos__col_width)
+		u16 slen = self->short_name_len;
+		if (verbose)
+			slen = self->long_name_len;
+		if (dsos__col_width < slen)
 			dsos__col_width = slen;
 	}
 
-- 
1.6.2.5

--


[ message continues ]
Previous thread: [PATCH 2/4] perf/record: simplify TRACE_INFO tracepoint check by Arnaldo Carvalho de Melo on Wednesday, May 5, 2010 - 7:30 am. (1 message)

Next thread: [PATCH 3/4] perf list: Add explanation about raw hardware event descriptors by Arnaldo Carvalho de Melo on Wednesday, May 5, 2010 - 7:30 am. (1 message)