[PATCH] x86 acpi/irq: Fix harmless typo.

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Eric W. Biederman
Date: Wednesday, May 5, 2010 - 1:53 am

YH noticed that the function irq_to_gsi has an off by one error
when translating high irq numbers to gsis.  Today this bug is harmless
because all of the callers restrict their input to the first 16 irqs
so this bug does not matter, but we should fix it to avoid confusion
and later.

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
---
 arch/x86/kernel/acpi/boot.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c
index c9a5d3f..78222c8 100644
--- a/arch/x86/kernel/acpi/boot.c
+++ b/arch/x86/kernel/acpi/boot.c
@@ -132,7 +132,7 @@ static u32 irq_to_gsi(int irq)
 	else if (irq <= gsi_end)
 		gsi = irq;
 	else if (irq <= (gsi_end + NR_IRQS_LEGACY))
-		gsi = irq - gsi_end;
+		gsi = irq - (gsi_end + 1);
 	else
 		gsi = 0xffffffff;
 
-- 
1.6.5.2.143.g8cc62

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 00/10] x86/irq, Yinghai Lu, (Sun Mar 21, 6:36 pm)
[PATCH 02/10] x86: fix out of order of gsi - full, Yinghai Lu, (Sun Mar 21, 6:36 pm)
[PATCH 10/10] x86: remove arch_probe_nr_irqs, Yinghai Lu, (Sun Mar 21, 6:36 pm)
Re: [PATCH 02/10] x86: fix out of order of gsi - full, Thomas Gleixner, (Mon Mar 22, 4:14 am)
Re: [PATCH 05/10] x86: use vector_desc instead of vector_irq, Thomas Gleixner, (Mon Mar 22, 6:58 am)
Re: [PATCH 05/10] x86: use vector_desc instead of vector_irq, Eric W. Biederman, (Mon Mar 22, 7:04 am)
Re: [PATCH 05/10] x86: use vector_desc instead of vector_irq, Thomas Gleixner, (Mon Mar 22, 7:16 am)
Re: [PATCH 02/10] x86: fix out of order of gsi - full, Yinghai Lu, (Mon Mar 22, 12:45 pm)
Re: [PATCH 02/10] x86: fix out of order of gsi - full, Eric W. Biederman, (Mon Mar 29, 6:40 am)
Re: [PATCH 02/10] x86: fix out of order of gsi - full, H. Peter Anvin, (Mon Mar 29, 10:57 am)
[PATCH 0/14] Start coping gsis &lt; 16 that are not isa irqs., Eric W. Biederman, (Mon Mar 29, 4:19 pm)
[PATCH 01/14] x86 acpi/irq: Introduce apci_isa_irq_to_gsi, Eric W. Biederman, (Mon Mar 29, 4:20 pm)
[PATCH 02/14] x86 acpi/irq: Teach acpi_get_override_irq to ..., Eric W. Biederman, (Mon Mar 29, 4:20 pm)
[PATCH 04/14] x86 acpi/irq: Fix acpi_sci_ioapic_setup so i ..., Eric W. Biederman, (Mon Mar 29, 4:20 pm)
[PATCH 05/14] x86 acpi/irq: Generalize mp_config_acpi_lega ..., Eric W. Biederman, (Mon Mar 29, 4:20 pm)
[PATCH 06/14] x86 ioapic: Only export mp_find_ioapic and m ..., Eric W. Biederman, (Mon Mar 29, 4:20 pm)
[PATCH 07/14] x86 ioapic: Fix the types of gsi values, Eric W. Biederman, (Mon Mar 29, 4:20 pm)
[PATCH 08/14] x86 ioapic: Teach mp_register_ioapic to comp ..., Eric W. Biederman, (Mon Mar 29, 4:20 pm)
[PATCH 09/14] x86 ioapic: In mpparse use mp_register_ioapic, Eric W. Biederman, (Mon Mar 29, 4:20 pm)
[PATCH 10/14] x86 ioapic: Move nr_ioapic_registers calcula ..., Eric W. Biederman, (Mon Mar 29, 4:20 pm)
[PATCH 11/14] x86 ioapic: Optimize pin_2_irq, Eric W. Biederman, (Mon Mar 29, 4:20 pm)
[PATCH 12/14] x86 ioapic: Simplify probe_nr_irqs_gsi., Eric W. Biederman, (Mon Mar 29, 4:20 pm)
[PATCH 13/14] x86 acpi/irq: Handle isa irqs that are not i ..., Eric W. Biederman, (Mon Mar 29, 4:20 pm)
[PATCH 14/14] x86 irq: Kill io_apic_renumber_irq, Eric W. Biederman, (Mon Mar 29, 4:20 pm)
Re: [PATCH 12/14] x86 ioapic: Simplify probe_nr_irqs_gsi., Eric W. Biederman, (Mon Mar 29, 9:43 pm)
Re: [PATCH 12/14] x86 ioapic: Simplify probe_nr_irqs_gsi., Eric W. Biederman, (Mon Mar 29, 10:41 pm)
[PATCH 01/15] x86 acpi/irq: Introduce apci_isa_irq_to_gsi, Eric W. Biederman, (Tue Mar 30, 1:07 am)
[PATCH 02/15] x86 acpi/irq: Teach acpi_get_override_irq to ..., Eric W. Biederman, (Tue Mar 30, 1:07 am)
[PATCH 04/15] x86 acpi/irq: Fix acpi_sci_ioapic_setup so i ..., Eric W. Biederman, (Tue Mar 30, 1:07 am)
[PATCH 05/15] x86 acpi/irq: Generalize mp_config_acpi_lega ..., Eric W. Biederman, (Tue Mar 30, 1:07 am)
[PATCH 06/15] x86 ioapic: Only export mp_find_ioapic and m ..., Eric W. Biederman, (Tue Mar 30, 1:07 am)
[PATCH 07/15] x86 ioapic: Fix io_apic_redir_entries to ret ..., Eric W. Biederman, (Tue Mar 30, 1:07 am)
[PATCH 08/15] x86 ioapic: Fix the types of gsi values, Eric W. Biederman, (Tue Mar 30, 1:07 am)
[PATCH 09/15] x86 ioapic: Teach mp_register_ioapic to comp ..., Eric W. Biederman, (Tue Mar 30, 1:07 am)
[PATCH 10/15] x86 ioapic: In mpparse use mp_register_ioapic, Eric W. Biederman, (Tue Mar 30, 1:07 am)
[PATCH 11/15] x86 ioapic: Move nr_ioapic_registers calcula ..., Eric W. Biederman, (Tue Mar 30, 1:07 am)
[PATCH 12/15] x86 ioapic: Optimize pin_2_irq, Eric W. Biederman, (Tue Mar 30, 1:07 am)
[PATCH 13/15] x86 ioapic: Simplify probe_nr_irqs_gsi., Eric W. Biederman, (Tue Mar 30, 1:07 am)
[PATCH 14/15] x86 acpi/irq: Handle isa irqs that are not i ..., Eric W. Biederman, (Tue Mar 30, 1:07 am)
[PATCH 15/15] x86 irq: Kill io_apic_renumber_irq, Eric W. Biederman, (Tue Mar 30, 1:07 am)
[tip:x86/irq] x86, acpi/irq: Introduce apci_isa_irq_to_gsi, tip-bot for Eric W. ..., (Tue May 4, 7:06 pm)
[tip:x86/irq] x86, acpi/irq: Teach acpi_get_override_irq t ..., tip-bot for Eric W. ..., (Tue May 4, 7:07 pm)
[tip:x86/irq] x86, acpi/irq: pci device dev-&gt;irq is an isa ..., tip-bot for Eric W. ..., (Tue May 4, 7:07 pm)
[tip:x86/irq] x86, acpi/irq: Fix acpi_sci_ioapic_setup so ..., tip-bot for Eric W. ..., (Tue May 4, 7:07 pm)
[tip:x86/irq] x86, acpi/irq: Generalize mp_config_acpi_leg ..., tip-bot for Eric W. ..., (Tue May 4, 7:07 pm)
[tip:x86/irq] x86, ioapic: Only export mp_find_ioapic and ..., tip-bot for Eric W. ..., (Tue May 4, 7:08 pm)
[tip:x86/irq] x86, ioapic: Fix io_apic_redir_entries to re ..., tip-bot for Eric W. ..., (Tue May 4, 7:08 pm)
[tip:x86/irq] x86, ioapic: Fix the types of gsi values, tip-bot for Eric W. ..., (Tue May 4, 7:08 pm)
[tip:x86/irq] x86, ioapic: Teach mp_register_ioapic to com ..., tip-bot for Eric W. ..., (Tue May 4, 7:09 pm)
[tip:x86/irq] x86, ioapic: In mpparse use mp_register_ioapic, tip-bot for Eric W. ..., (Tue May 4, 7:09 pm)
[tip:x86/irq] x86, ioapic: Move nr_ioapic_registers calcul ..., tip-bot for Eric W. ..., (Tue May 4, 7:09 pm)
[tip:x86/irq] x86, ioapic: Optimize pin_2_irq, tip-bot for Eric W. ..., (Tue May 4, 7:09 pm)
[tip:x86/irq] x86, ioapic: Simplify probe_nr_irqs_gsi., tip-bot for Eric W. ..., (Tue May 4, 7:10 pm)
[tip:x86/irq] x86, acpi/irq: Handle isa irqs that are not ..., tip-bot for Eric W. ..., (Tue May 4, 7:10 pm)
[tip:x86/irq] x86, irq: Kill io_apic_renumber_irq, tip-bot for Eric W. ..., (Tue May 4, 7:10 pm)
[PATCH] x86 acpi/irq: Fix harmless typo., Eric W. Biederman, (Wed May 5, 1:53 am)
Re: [PATCH] x86 acpi/irq: Fix harmless typo., Ingo Molnar, (Wed May 5, 1:58 am)
Re: [tip:x86/irq] x86, acpi/irq: Handle isa irqs that are ..., Eric W. Biederman, (Wed May 5, 2:32 am)
[PATCH] x86 acpi/irq: Define gsi_end when X86_IO_APIC is ..., Eric W. Biederman, (Wed May 5, 1:22 pm)
[tip:x86/irq] x86, acpi/irq: Define gsi_end when X86_IO_AP ..., tip-bot for Eric W. ..., (Thu May 6, 3:07 am)