Hi Greg,

After merging the staging tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: "uart_console_device" [drivers/serial/altera_uart.ko] undefined!
ERROR: "uart_console_device" [drivers/serial/altera_jtaguart.ko] undefined!

Introduced by commits 76bdbd933febe791fee114e7bb6c42bbd1a3f4f3 ("serial:
Add driver for the Altera UART") and
11c59b34b299d7214b466cf799410a9a540476e3 ("serial: Add driver for the
Altera JTAG UART").

I have reverted those commits for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[ message continues ]

Those came in through the tty quilt tree, not the staging tree, right?

Tobias, care to send me a patch to resolve this?  I already fixed one
Kconfig issue in these patches (forcing the driver to always be built
in.)  Is that what caused this symbol issue?

thanks,

greg k-h
--

[ message continues ]

Hi Greg,



I have reverted those commits again today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[ message continues ]

I think I'll go drop these patches now.  Tobias, care to resend them
when you have them working properly?

thanks,

greg k-h
--

[ message continues ]

Yepp, I'll have a look at it and will send the updated patches as soon
as I resolved it.

Thanks
Tobias
--

[ message continues ]

I just built the current linux-next (20100503) with the patches applied
(including Greg's Kconfig change) on x86_64 with allmodconfig and wasn't
able to reproduce the build failure.

Any pointers on how to reproduce and/or fix this would be appreciated.

Thanks,
Tobias
--

[ message continues ]

Hi Tobias,


Of course, if you force this driver to be built in (as Greg's Kconfig
change presumably did), then you won't get these errors.

The real solution is that SERIAL_ALTERA_JTAGUART_CONSOLE needs to depend
on SERIAL_ALTERA_JTAGUART=y (instead of just SERIAL_ALTERA_JTAGUART) and
similarly for the other.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[ message continues ]

Hi Stephen,


Thanks for your help! I resubmitted an updated version of the patches
([1], [2]) including the changes pointed out above (compile tested
against linux-next as of 20100505 with allmodconfig on x86_64).

[1] Message-Id:
095aab012b2a6b3bbf4c7bc04294bb9c19316318.1273048151.git.tklauser@distanz.ch
[2] Message-Id:
e83e74abd82079284d5c8f62b78f2417ebc9ee27.1273048151.git.tklauser@distanz.ch

Cheers,
Tobias
--

[ message continues ]