Home » Mailing list archives » linux-kernel » 2010 » May » 5

Re: [PATCH] sst25l.c: remove unnecessary MTD_DEBUG_LEVEL2 messages

Previous thread: RE: kernel BUG in iwl-agn-rs.c:2076,was: iwlagn + some accesspoint = hardlock by lkml on Thursday, April 29, 2010 - 11:26 am. (1 message)

Next thread: [PATCH] compat_ioctl: add compat handler for PPPIOCGL2TPSTATS ioctl by Florian Westphal on Thursday, April 29, 2010 - 1:03 am. (1 message)
[view original message]
From: H Hartley Sweeten
Subject: [PATCH] sst25l.c: remove unnecessary MTD_DEBUG_LEVEL2 messages
Date: Thursday, April 29, 2010 - 3:52 pm

All the SST25L series flash parts have uniform erase sectors.  Remove
the extra MTD_DEBUG_LEVEL2 messages showing the eraseregions info
since they could never be shown.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Andre Renaud <andre@bluewatersys.com>
Cc: Ryan Mallon <ryan@bluewatersys.com>

---

diff --git a/drivers/mtd/devices/sst25l.c b/drivers/mtd/devices/sst25l.c
index fe17054..bcf040b 100644
--- a/drivers/mtd/devices/sst25l.c
+++ b/drivers/mtd/devices/sst25l.c
@@ -411,17 +411,6 @@ static int __init sst25l_probe(struct spi_device *spi)
 	      flash->mtd.erasesize, flash->mtd.erasesize / 1024,
 	      flash->mtd.numeraseregions);
 
-	if (flash->mtd.numeraseregions)
-		for (i = 0; i < flash->mtd.numeraseregions; i++)
-			DEBUG(MTD_DEBUG_LEVEL2,
-			      "mtd.eraseregions[%d] = { .offset = 0x%llx, "
-			      ".erasesize = 0x%.8x (%uKiB), "
-			      ".numblocks = %d }\n",
-			      i, (long long)flash->mtd.eraseregions[i].offset,
-			      flash->mtd.eraseregions[i].erasesize,
-			      flash->mtd.eraseregions[i].erasesize / 1024,
-			      flash->mtd.eraseregions[i].numblocks);
-
 	if (mtd_has_partitions()) {
 		struct mtd_partition *parts = NULL;
 		int nr_parts = 0;

[ message continues ]
[view original message]
From: Artem Bityutskiy
Subject: Re: [PATCH] sst25l.c: remove unnecessary MTD_DEBUG_LEVEL2 messages
Date: Tuesday, May 4, 2010 - 10:51 pm

Pushed to l2-mtd-2.6 / master

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

--


[ message continues ]
Previous thread: RE: kernel BUG in iwl-agn-rs.c:2076,was: iwlagn + some accesspoint = hardlock by lkml on Thursday, April 29, 2010 - 11:26 am. (1 message)

Next thread: [PATCH] compat_ioctl: add compat handler for PPPIOCGL2TPSTATS ioctl by Florian Westphal on Thursday, April 29, 2010 - 1:03 am. (1 message)