[PATCH 4/6] kobj: Send hotplug events in the proper namespace.

Previous thread: [PATCH 3/6] netlink: Implment netlink_broadcast_filtered by Eric W. Biederman on Tuesday, May 4, 2010 - 5:36 pm. (1 message)

Next thread: [PATCH 1/6] kobject: Send hotplug events in all network namespaces by Eric W. Biederman on Tuesday, May 4, 2010 - 5:36 pm. (1 message)
From: Eric W. Biederman
Date: Tuesday, May 4, 2010 - 5:36 pm

From: Eric W. Biederman <ebiederm@xmission.com>

Utilize netlink_broacast_filtered to allow sending hotplug events
in the proper namespace.

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
---
 lib/kobject_uevent.c |   22 ++++++++++++++++++++--
 1 files changed, 20 insertions(+), 2 deletions(-)

diff --git a/lib/kobject_uevent.c b/lib/kobject_uevent.c
index 3f5f17b..9057ec1 100644
--- a/lib/kobject_uevent.c
+++ b/lib/kobject_uevent.c
@@ -82,6 +82,22 @@ out:
 	return ret;
 }
 
+static int kobj_bcast_filter(struct sock *dsk, struct sk_buff *skb, void *data)
+{
+	struct kobject *kobj = data;
+	const struct kobj_ns_type_operations *ops;
+
+	ops = kobj_ns_ops(kobj);
+	if (ops) {
+		const void *sock_ns, *ns;
+		ns = kobj->ktype->namespace(kobj);
+		sock_ns = ops->netlink_ns(dsk);
+		return sock_ns != ns;
+	}
+
+	return 0;
+}
+
 /**
  * kobject_uevent_env - send an uevent with environmental data
  *
@@ -243,8 +259,10 @@ int kobject_uevent_env(struct kobject *kobj, enum kobject_action action,
 			}
 
 			NETLINK_CB(skb).dst_group = 1;
-			retval = netlink_broadcast(uevent_sock, skb, 0, 1,
-						   GFP_KERNEL);
+			retval = netlink_broadcast_filtered(uevent_sock, skb,
+							    0, 1, GFP_KERNEL,
+							    kobj_bcast_filter,
+							    kobj);
 			/* ENOBUFS should be handled in userspace */
 			if (retval == -ENOBUFS)
 				retval = 0;
-- 
1.6.5.2.143.g8cc62

--

Previous thread: [PATCH 3/6] netlink: Implment netlink_broadcast_filtered by Eric W. Biederman on Tuesday, May 4, 2010 - 5:36 pm. (1 message)

Next thread: [PATCH 1/6] kobject: Send hotplug events in all network namespaces by Eric W. Biederman on Tuesday, May 4, 2010 - 5:36 pm. (1 message)