Hi, Some more kernel NULL ptr deref, a lot of scheduling while atomic (probably due to first bug occurred) and again this "last sysfs file" from wireless. ath5k is a real source of trouble here: - resume from suspend fails 7 times out of 10 and always seems the ath driver being the culprit. - ath5k: when starting a blob transfer eg. ssh summer.jpg to the notebook with the ath5k driver running, the wNIC freezes almost immediately! Dead device. This is unfortunately too ...

Hi Venki -- In some offlist discussion, a similar solution was suggested: If /sys/devices/system/clocksource/clocksource*/current_clocksource is "tsc" AND the "Invariant TSC" CPUID bit is set, then "reliable TSC" can be assumed. BUT, exposing the information explicitly from the kernel would be more comforting rather than requiring some reverse-engineering some combination of kernel tests that might change over time. If the kernel determines TSC is reliable, that seems like it should ...

Device passthrough technology allows a guest to bypass the hypervisor and drive the underlying physical device. VMware has been exploring various ways to deliver this technology to users in a manner which is easy to adopt. In this process we have prepared an architecture along with Intel - NPA (Network Plugin Architecture). NPA allows the guest to use the virtualized NIC vmxnet3 to passthrough to a number of physical NICs which support it. The document below provides an overview of NPA. We ...

This is the second attempt to get the BKL out of the TTY code. I've updated the patches to be based on top of Alan's series and improved a number of things. This series still introduces a new Big TTY Mutex that is based on the earlier implementation of the Big Kernel Semaphore, but comes with a number of changes: - based on the mutex code instead of a semaphore, so we can use all the mutex debugging. - no autorelease on sleep, which is what most of the series is about. - limited ...

tty_port->mutex has a lock order problem with tty_lock. By using mutex_lock_tty to drop tty_lock while waiting for tty_port->mutex we can work around this. Make sure that we document for each mutex_lock(port->mutex) whether we hold the BTM or not, in the hope that this helps us eliminate the BTM eventually. All users of tty_port_hangup call that with the BTM held, except for stl_cleanup_panels. Take the BTM explicitly there to make the locking more consistent. Signed-off-by: Arnd ...

This changes all remaining users of tty_lock_nested to be non-recursive, which lets us kill this function. As a consequence, we won't need to keep the lock count any more, which allows more simplifications later. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/char/pty.c | 2 +- drivers/char/selection.c | 4 ++-- drivers/char/tty_io.c | 41 ++++++++++++++++++++--------------------- drivers/char/tty_ldisc.c | 3 +-- drivers/char/tty_mutex.c | 15 ...

atomic_write_lock never nests below BTM as far as I can tell, so this can eventually get reverted again unless it triggers bugs. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/char/tty_io.c | 9 +++++++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/char/tty_io.c b/drivers/char/tty_io.c index 3bf2c75..8331dd3 100644 --- a/drivers/char/tty_io.c +++ b/drivers/char/tty_io.c @@ -912,10 +912,15 @@ void tty_write_unlock(struct tty_struct *tty) int ...

Some wait_until_sent versions require the big tty mutex, others don't and some callers of wait_until_sent already hold it while other don't. That leads to recursive use of the BTM in these functions, which we're trying to get rid of. This patch changes both the implementations and the users of wait_until_sent so that the device driver implementations are always called with the lock held so they don't need to get it themselves. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- ...

The TTY layer now has its own ways to deal with recursive locking and release-on-sleep for the tty_lock() calls, meaning that it's safe to replace the Big Kernel Lock with a subsystem specific Big TTY Mutex (BTM). This patch for now makes the new behaviour an optional experimental feature that can be enabled for testing purposes. Using a regular mutex here will change the behaviour when blocked on the BTM from spinning to sleeping, but that should be visible to the user. Using the mutex ...

This was not caught in the initial sweep through the TTY layer, nor by lockdep, which does not know about classic semaphores. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- kernel/printk.c | 11 ++++++++++- 1 files changed, 10 insertions(+), 1 deletions(-) diff --git a/kernel/printk.c b/kernel/printk.c index 75077ad..30669a3 100644 --- a/kernel/printk.c +++ b/kernel/printk.c @@ -970,7 +970,16 @@ void resume_console(void) void acquire_console_sem(void) { ...

On Mon, 3 May 2010 03:02:00 +0800 Seems a reasonable thing to do. It might also be reasonable to make And these should be uninlined - they're too large to be inlined. My version of gcc seems to just uninline them anyway, but forcing them to be inlined with __always_inline indeed causes 70-80 bytes more text, and we figure that larger text generally causes a slower kernel due to cache eviction effects. --

The ACPI dependency moved to the TPM, where it belongs. Although IMA per-se does not require access to the bios measurement log, verifying the IMA boot aggregate does, which requires ACPI. This patch prereq's 'TPM: ACPI/PNP dependency removal' http://lkml.org/lkml/2010/5/4/378. Signed-off-by: Mimi Zohar <zohar@us.ibm.com> Reported-by: Jean-Christophe Dubois <jcd@tribudubois.net> Acked-by: Serge Hallyn <serue@us.ibm.com> Tested-by: Serge Hallyn <serue@us.ibm.com> --- ...

Just posted a patch removing the ACPI dependency from IMA, as IMA can run with/without ACPI or TPM enabled. However, without ACPI enabled, the Mimi --

Hello folks! I've now seen that sometimes (!) if I startup the system with latest linux-2.6 series kernels that my systems shuts down (i.e. no halt, directly to power off) when I startx. With this kernel I've seen it some minutes ago. The shutdown situation happened after the suspend issues (i.e. rebooted after suspend, forced power off via power button, restart, startx; see thread "2.6.33-2.6.34-rc5 suspend issues" for more information), not sure whether this is related. Not sure how to ...

Yes, leave it as open until the patch is merged, please. -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** --

This message has been generated automatically as a part of a summary report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.33. Please verify if it still should be listed and let the tracking team know (either way). Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15601 Subject : [BUG] SLOB breaks Crypto Submitter : michael-dev@fami-braun.de Date : 2010-03-15 13:39 (51 days old) Message-ID : ...

This message has been generated automatically as a part of a summary report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.33. Please verify if it still should be listed and let the tracking team know (either way). Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15862 Subject : 2.6.34-rc4/5: iwlagn unusable until reload Submitter : Nico Schottelius <nico-linux-20100427@schottelius.org> Date : 2010-04-27 7:49 (8 days ...

This message has been generated automatically as a part of a summary report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.33. Please verify if it still should be listed and let the tracking team know (either way). Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15893 Subject : Alps: No edge-scrolling since 2.6.34-rc5 Submitter : Felix Zweig <f.zweig@yahoo.de> Date : 2010-05-01 16:23 (4 days old) Handled-By : Dan Carpenter ...

[Empty message]

This message has been generated automatically as a part of a summary report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.33. Please verify if it still should be listed and let the tracking team know (either way). Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15589 Subject : 2.6.34-rc1: Badness at fs/proc/generic.c:316 Submitter : Christian Kujau <lists@nerdbynature.de> Date : 2010-03-13 23:53 (53 days old) Message-ID : ...

This message has been generated automatically as a part of a summary report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.33. Please verify if it still should be listed and let the tracking team know (either way). Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15671 Subject : intel graphic card hanging (Hangcheck timer elapsed... GPU hung) Submitter : Norbert Preining <preining@logic.at> Date : 2010-03-27 16:11 (39 days ...

This message has been generated automatically as a part of a summary report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.33. Please verify if it still should be listed and let the tracking team know (either way). Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15717 Subject : bluetooth oops Submitter : Pavel Machek <pavel@ucw.cz> Date : 2010-03-14 20:14 (52 days old) Message-ID : ...

This message has been generated automatically as a part of a summary report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.33. Please verify if it still should be listed and let the tracking team know (either way). Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15712 Subject : [regression] 2.6.34-rc1 to -rc3 on zaurus: no longer boots Submitter : Pavel Machek <pavel@ucw.cz> Date : 2010-04-01 6:06 (34 days old) Message-ID : ...

This message has been generated automatically as a part of a summary report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.33. Please verify if it still should be listed and let the tracking team know (either way). Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15713 Subject : hackbench regression due to commit 9dfc6e68bfe6e Submitter : Alex Shi <alex.shi@intel.com> Date : 2010-03-25 8:40 (41 days old) First-Bad-Commit: ...

This message has been generated automatically as a part of a summary report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.33. Please verify if it still should be listed and let the tracking team know (either way). Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15729 Subject : BUG: physmap modprobe & rmmod Submitter : Randy Dunlap <randy.dunlap@oracle.com> Date : 2010-04-02 20:40 (33 days old) Message-ID : ...

This message has been generated automatically as a part of a summary report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.33. Please verify if it still should be listed and let the tracking team know (either way). Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15659 Subject : [Regresion] [2.6.34-rc1] [drm:i915_hangcheck_elapsed] *ERROR* Hangcheck timer elapsed... GPU hung Submitter : Maciej Rutecki ...

This message has been generated automatically as a part of a summary report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.33. Please verify if it still should be listed and let the tracking team know (either way). Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15610 Subject : fsck leads to swapper - BUG: unable to handle kernel NULL pointer dereference & panic Submitter : Ozgur Yuksel <ozgur.yuksel@oracle.com> Date : ...

This message has been generated automatically as a part of a summary report of recent regressions. The following bug entry is on the current list of known regressions from 2.6.33. Please verify if it still should be listed and let the tracking team know (either way). Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15590 Subject : 2.6.34-rc1: regression: ^Z no longer stops sound Submitter : Pavel Machek <pavel@ucw.cz> Date : 2010-03-14 7:58 (52 days old) Message-ID : ...

This message contains a list of some regressions from 2.6.33, for which there are no fixes in the mainline known to the tracking team. If any of them have been fixed already, please let us know. If you know of any other unresolved regressions from 2.6.33, please let us know either and we'll add them to the list. Also, please let us know if any of the entries below are invalid. Each entry from the list will be sent additionally in an automatic reply to this message with CCs to the people ...

Is it a regression? People have been configuring their kernel stupidly and then acting surprised when it didn't work for _ages_... what's new? -- dwmw2 --

Add a #include for mutex.h to allow SRCU to be more easily used in kernel modules. Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> --- include/linux/srcu.h | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/linux/srcu.h b/include/linux/srcu.h index 9c01f10..4d5d2f5 100644 --- a/include/linux/srcu.h +++ b/include/linux/srcu.h @@ -27,6 +27,8 @@ #ifndef _LINUX_SRCU_H #define _LINUX_SRCU_H ...

Hello! RFC preview of RCU patches queued for 2.6.35, take 4. Take 3 is at http://lkml.org/lkml/2010/4/20/321. New patches flagged with "New". 1. New: optionally leave lockdep enabled after RCU lockdep splat This patch, based on one from Lai Jiangshan, allows multiple RCU-lockdep splats per boot. This was proposed for 2.6.34, but it does not qualify as a regression, so it is now at the head of the 2.6.35 queue. 2. substitute set_need_resched for sending resched IPIs This reduces ...

The CPU_STALL_VERBOSE kernel configuration parameter was added to 2.6.34 to identify any preempted/blocked tasks that were preventing the current grace period from completing when running preemptible RCU. As is conventional for new configurations parameters, this defaulted disabled. It is now time to enable it by default. Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> --- lib/Kconfig.debug | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git ...

The sparse RCU-pointer checking relies on type magic that dereferences the pointer in question. This does not work if the pointer is in fact an array index. This commit therefore supplies a new RCU API that omits the sparse checking to continue to support rcu_dereference() on integers. Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> --- include/linux/rcupdate.h | 33 +++++++++++++++++++++++++++++++++ 1 files changed, 33 insertions(+), 0 deletions(-) diff --git ...

TREE_RCU assumes that CPU numbering is contiguous, but some users need large holes in the numbering to better map to hardware layout. This patch makes TREE_RCU (and TREE_PREEMPT_RCU) tolerate large holes in the CPU numbering. However, NR_CPUS must still be greater than the largest CPU number. Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> --- kernel/rcutree.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/kernel/rcutree.c b/kernel/rcutree.c index ...

From: Arnd Bergmann <arnd@relay.de.ibm.com> Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Cc: Patrick McHardy <kaber@trash.net> Cc: "David S. Miller" <davem@davemloft.net> Cc: Eric Dumazet <eric.dumazet@gmail.com> --- include/net/netfilter/nf_conntrack.h | 2 +- net/ipv4/netfilter/nf_nat_core.c | 2 +- net/netfilter/core.c | 2 +- net/netfilter/nf_conntrack_ecache.c | 4 ++-- ...

From: Lai Jiangshan <laijs@cn.fujitsu.com> Shrink the RCU_INIT_FLAVOR() macro by moving all but the initialization of the ->rda[] array to rcu_init_one(). The call to rcu_init_one() can then be moved to the end of the RCU_INIT_FLAVOR() macro, which is required because rcu_boot_init_percpu_data(), which is now called from rcu_init_one(), depends on the initialization of the ->rda[] array. Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com> Signed-off-by: Paul E. McKenney ...

The existing Documentation/RCU/stallwarn.txt has proven unhelpful, so rework it a bit. In particular, show how to interpret the stall-warning messages. Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> --- Documentation/RCU/stallwarn.txt | 94 +++++++++++++++++++++++++++++--------- 1 files changed, 71 insertions(+), 23 deletions(-) diff --git a/Documentation/RCU/stallwarn.txt b/Documentation/RCU/stallwarn.txt index 1423d25..44c6dcc 100644 --- ...

The new versions of the rcu_dereference() APIs requires that any pointers passed to one of these APIs be fully defined. The ->br_port field in struct net_device points to a struct net_bridge_port, which is an incomplete type. This commit therefore changes ->br_port to be a void*, and introduces a br_port() helper function to convert the type to struct net_bridge_port, and applies this new helper function where required. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Paul E. ...

From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Remove all rcu head inits. We don't care about the RCU head state before passing it to call_rcu() anyway. Only leave the "on_stack" variants so debugobjects can keep track of objects on stack. This patch applies to current -tip based on 2.6.34-rc2. Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> CC: David S. Miller <davem@davemloft.net> CC: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> CC: mingo@elte.hu CC: ...

The addition of preemptible RCU to treercu resulted in a bit of confusion and inefficiency surrounding the handling of context switches for RCU-sched and for RCU-preempt. For RCU-sched, a context switch is a quiescent state, pure and simple, just like it always has been. For RCU-preempt, a context switch is in no way a quiescent state, but special handling is required when a task blocks in an RCU read-side critical section. However, the callout from the scheduler and the outer loop in ...

TINY_RCU does not need rcu_scheduler_active unless CONFIG_DEBUG_LOCK_ALLOC. So conditionally compile rcu_scheduler_active in order to slim down rcutiny a bit more. Also gets rid of an EXPORT_SYMBOL_GPL, which is responsible for most of the slimming. Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> --- include/linux/rcupdate.h | 4 +--- include/linux/rcutiny.h | 13 +++++++++++++ include/linux/rcutree.h | 3 +++ kernel/rcupdate.c | 19 ------------------- ...

Print boot-time messages if tracing is enabled, if fanout is set to non-default values, if exact fanout is specified, if accelerated dyntick-idle grace periods have been enabled, if RCU-lockdep is enabled, if rcutorture has been boot-time enabled, if the CPU stall detector has been disabled, or if four-level hierarchy has been enabled. This is all for TREE_RCU and TREE_PREEMPT_RCU. TINY_RCU will be handled separately, if at all. Suggested-by: Josh Triplett ...

From: Arnd Bergmann <arnd@arndb.de> This adds annotations for RCU operations in core kernel components Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Cc: Al Viro <viro@ZenIV.linux.org.uk> Cc: Jens Axboe <jens.axboe@oracle.com> Cc: Andrew Morton <akpm@linux-foundation.org> --- include/linux/fdtable.h | 6 +++--- include/linux/fs.h | 2 +- include/linux/genhd.h | 6 +++--- include/linux/init_task.h | 4 ...

Because synchronize_rcu_bh() is identical to synchronize_sched(), make the former a static inline invoking the latter, saving the overhead of an EXPORT_SYMBOL_GPL() and the duplicate code. Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> --- include/linux/rcupdate.h | 2 -- include/linux/rcutiny.h | 12 +++++++++++- include/linux/rcutree.h | 2 ++ kernel/rcutiny.c | 9 ++------- 4 files changed, 15 insertions(+), 10 deletions(-) diff --git ...

The mce processing applies rcu_dereference_check() to integers used as array indices. This patch therefore moves mce to the new RCU API rcu_dereference_index_check() that avoids the sparse processing that would otherwise result in compiler errors. Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Cc: Andi Kleen <andi@firstfloor.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Ingo Molnar <mingo@redhat.com> Cc: "H. Peter Anvin" <hpa@zytor.com> --- ...

It is CONFIG_DEBUG_LOCK_ALLOC rather than CONFIG_PROVE_LOCKING, so fix it. Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> --- include/linux/rcupdate.h | 15 ++++++++------- include/linux/srcu.h | 4 ++-- 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/include/linux/rcupdate.h b/include/linux/rcupdate.h index 4dca275..a150af0 100644 --- a/include/linux/rcupdate.h +++ b/include/linux/rcupdate.h @@ -106,8 +106,8 @@ extern int ...

To add more background, I was thinking that it might make sense to always leave the address space attribute in place but to make part part of the checking optional. The idea would be that we always make sure that an __rcu annotated pointer cannot be dereferenced or cast directly, while we would only complain about non-annotated pointers being passed to rcu_dereference and rcu_assign_pointer if CONFIG_SPARSE_RCU_POINTER is set. Most of the work I had spent on my tree was about fixing all ...

Not sure if you were confused by the comment in the same way that I was. The bridge hook is not impacted by this at all, since we can either pass a void* or a struct net_bridge_port* to it. The br_port() helper is used for all the places where we actually want to dereference dev->br_port and access its contents. Arnd --

No specific plans at the moment. But having the underlying plumbing all Thank -you- for making this happen!!! Thanx, Paul --

How about the following? struct socket *sock; sock = rcu_dereference_protected(vq->private_data, lockdep_is_held(&vq->mutex)); This could be used for some (though not all) of these situations. And just so you know... The fact that this is here in the first place is actually my mistake -- my intention was to include the __rcu annotations and nothing else, then follow up with bug fixes. In fact, the alert reader will have noted that there is in fact no such thing as ...

From: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Cc: "David S. Miller" <davem@davemloft.net> Cc: Eric Dumazet <eric.dumazet@gmail.com> --- drivers/net/bnx2.h | 2 +- drivers/net/bnx2x.h | 2 +- drivers/net/cnic.h | 2 +- drivers/net/macvtap.c | 2 +- include/linux/if_macvlan.h | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git ...

From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Testing resulted in the following debugobjects splat [...] ODEBUG: object is on stack, but not annotated ------------[ cut here ]------------ Badness at lib/debugobjects.c:294 NIP: c0000000002c76f0 LR: c0000000002c76ec CTR: c00000000041ecd8 REGS: c0000001de71b280 TRAP: 0700 Tainted: G W (2.6.34-rc3-autokern1) MSR: 8000000000029032 <EE,ME,CE,IR,DR> CR: 24000424 XER: 0000000f TASK = c0000001de7dca00[3695] 'arping' THREAD: ...

The sparse RCU-pointer annotations require definition of the underlying type of any pointer passed to rcu_dereference() and friends. So fcheck_files() needs "struct file" to be defined, so include fs.h. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Cc: Al Viro <viro@ZenIV.linux.org.uk> --- include/linux/fdtable.h | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/linux/fdtable.h ...

From: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Paul Mackerras <paulus@samba.org> Cc: Ingo Molnar <mingo@elte.hu> Cc: Arnaldo Carvalho de Melo <acme@redhat.com> --- include/linux/perf_event.h | 6 +++--- include/linux/sched.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/linux/perf_event.h ...

From: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> Cc: Dmitry Torokhov <dtor@mail.ru> --- drivers/input/evdev.c | 2 +- include/linux/input.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/evdev.c b/drivers/input/evdev.c index 2ee6c7a..73b1208 100644 --- a/drivers/input/evdev.c +++ ...

Hello, Matt, RCU_HEAD_INIT() is no more. Or will be no more after this patchset. However, now that you mention it, we do need docbook comments for init_rcu_head_on_stack() and friends. I will fix that. Thanx, Paul --

Please document that distinction at the definition of INIT_RCU_HEADS, otherwise we're sure to see creep. -- Mathematics is the supreme nostalgia of our time. --

From: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Cc: Trond Myklebust <Trond.Myklebust@netapp.com> --- fs/nfs/delegation.h | 2 +- include/linux/nfs_fs.h | 2 +- include/linux/sunrpc/auth_gss.h | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/nfs/delegation.h b/fs/nfs/delegation.h index 69e7b81..2978814 100644 --- a/fs/nfs/delegation.h +++ ...

From: Lai Jiangshan <laijs@cn.fujitsu.com> Offline CPUs are not in nohz_cpu_mask, but can be ignored when checking for the last non-dyntick-idle CPU. This patch therefore only checks online CPUs for not being dyntick idle, allowing fast entry into full-system dyntick-idle state even when there are some offline CPUs. Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> --- kernel/rcutree_plugin.h | 2 +- 1 files changed, 1 ...

commit 1cb0e4339ecd39c62840c74b53546bd28c1ea1a9 Author: Alan Cox <alan@linux.intel.com> Date: Tue May 4 20:38:47 2010 +0100 rar: perform a clean up pass - Move to a registration model where each RAR is claimed/unclaimed - Use that to fix the client stuff (one client per RAR so no need to queue stuff) - Support unregister so drivers can rmmod themselves safely - Fix locking hang on calling rar lock from rar callback - Clean up - Kerneldoc Folded ...

Signed-off-by: Kevin Cernekee <cernekee@gmail.com> --- include/linux/mtd/map.h | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/linux/mtd/map.h b/include/linux/mtd/map.h index b981b87..01703d4 100644 --- a/include/linux/mtd/map.h +++ b/include/linux/mtd/map.h @@ -7,6 +7,7 @@ #include <linux/types.h> #include <linux/list.h> #include <linux/string.h> +#include <linux/bug.h> #include <linux/mtd/compatmac.h> -- 1.6.3.1 --

Set the IORESOURCE_TYPE based on the parent. Without this, the type is never set, which is slightly confusing if we ever print the resource later. Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com> --- kernel/resource.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/kernel/resource.c b/kernel/resource.c index aa63746..f0d83a4 100644 --- a/kernel/resource.c +++ b/kernel/resource.c @@ -699,8 +699,9 @@ struct resource * __request_region(struct resource ...

Hmm. I don't object, but unless there is some crazy regression, there's no way I will take something like this outside the merge window. Who knows what odd frame buffer driver is out there that just depended on the fact that it could also register that VGA area? Probably no such thing exists, but it's why I want these kinds of things during the merge window. And obviously preferably through something like the PCI merge tree, but that's a different issue. Linus --

On Tue, 04 May 2010 13:14:11 -0700 I'm happy to stuff it in my -next tree. Bjorn can you resend? Thanks, Jesse --

You can use "trace_printk()". I think that is what you are looking for. -- Steve --

Thanks for the info. One other question - when I write only mmiotrace to the current_tracer, the trace_printk() stuff does not end up in the buffer. I can get it by using the "sysprof" tracer, but that has a lot of stuff I do not want. Did I miss some configuration? My list of available tracers is "blk kmemtrace mmiotrace wakeup_rt wakeup function sysprof sched_switch nop". Thanks, Larry --

Guy, sorry to drop this just after your kind letter yesterday. This change has been in the works for a little while, and would have been sent in last week if I hadn't found an error in my model. Sorry to send these patches as such large chunks. In the current version of hid-ntrig, contacts are rejected based on a simple size threshold to filter out randomly generated activity. Unfortunately I was too aggressive in the selection of that threshold. As Micki may have pointed out we can ...

The old rejection size thresholds were too high for the 12" devices. Larger surfaces like the Dell Studio17 exacerbated the problem since contact size is reported on the same logical scale, making a contact look smaller to the larger screen. Since we have observed erroneous ghost events from these devices we still need to filter the incoming stream. The prior size threshold filter is still in place, though with defaults set to leave it off. This patch adds the two new classes of filters, ...

Linus, Please pull the latest perf-fixes-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git perf-fixes-for-linus Thanks, Ingo ------------------> Tejun Heo (1): perf: Fix resource leak in failure path of perf_event_open() kernel/perf_event.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/kernel/perf_event.c b/kernel/perf_event.c index 2f3fbf8..3d1552d 100644 --- a/kernel/perf_event.c +++ ...

As those computers never had any i8042 controllers, and the current lookup code could potentially lock up/hang/wait for timeout for long periods of time. Fixes intermittent hangs on boot on a MacbookAir1,1 Signed-off-by: Bastien Nocera <hadess@hadess.net> --- drivers/input/serio/i8042.c | 18 ++++++++++++++++++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/drivers/input/serio/i8042.c b/drivers/input/serio/i8042.c index d84a36e..2be7207 100644 --- ...

This should go into i8042-x86ia64io.h and used to create PNP whitelist. Thanks. -- Dmitry --

Ingo, Oops, I forgot to add this one too. I just pushed it after you did your last pull. Please pull the latest tip/tracing/core tree, which can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-2.6-trace.git tip/tracing/core Borislav Petkov (1): ring-buffer: Wrap open-coded WARN_ONCE ---- kernel/trace/ring_buffer.c | 14 +++++--------- 1 files changed, 5 insertions(+), 9 deletions(-) --------------------------- commit ...

Hey, did you get my patch concerning those hash changes? Havent gotten any reply. Best wishes Kristoffer --

Ingo, Please pull the latest tip/tracing/core tree, which can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-2.6-trace.git tip/tracing/core Steven Rostedt (1): tracing: Convert nop macros to static inlines ---- include/linux/ftrace.h | 30 ++++++++++++++++++------------ 1 files changed, 18 insertions(+), 12 deletions(-) --------------------------- commit 4dbf6bc239c169b032777616806ecc648058f6b2 Author: Steven Rostedt ...

Well, do like x86 does in entry.S call into lockdep right before returning to userspace. --

CC: ARM -- Lei Ming --

From: Ming Lei <tom.leiming@gmail.com> The defination of hardirqs_enabled and softirqs_enabled in task_struct depends on CONFIG_TRACE_IRQFLAGS instead of CONFIG_PROVE_LOCKING. Signed-off-by: Ming Lei <tom.leiming@gmail.com> --- kernel/fork.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/kernel/fork.c b/kernel/fork.c index 44b0791..038a8fd 100644 --- a/kernel/fork.c +++ b/kernel/fork.c @@ -1004,7 +1004,7 @@ static struct task_struct *copy_process(unsigned long ...

Yes, code now has warnings, I have something like, const struct firmware *fw_entry; declared in my header file, and use it as, request_firmware(&kim_gdata->fw_entry, bts_scr_name, &kim_gdata->kim_pdev->dev); and then I get warnings at, release_firmware(kim_gdata->fw_entry); You want me to have a pointer to &kw_gdata->fw_entry which is const ? as in const struct firmware **fw_const_ptr; --

Neither is that. Also, you "signed-off" on a patch twice, not good. Other than that, which I fixed up by hand, it looks good, and I've applied it and added some clean-up patches on top of it to resolve some issues. thanks, greg k-h --

With commits 08677214 and 59be5a8e, alloc_bootmem()/free_bootmem() and friends use the early_res functions for memory management when NO_BOOTMEM is enabled. This patch adds the kmemleak calls in the corresponding code paths for bootmem allocations. Signed-off-by: Catalin Marinas <catalin.marinas@arm.com> Cc: Yinghai Lu <yinghai@kernel.org> Cc: H. Peter Anvin <hpa@zytor.com> --- mm/bootmem.c | 2 ++ mm/page_alloc.c | 1 + 2 files changed, 3 insertions(+), 0 deletions(-) diff ...

Does your code now complain about a warning? If so, do you have a pointer to it? thanks, greg k-h --

Ok. Please submit to the patch system, thanks. --

One way is, before *each* compilation after a 'git bisect good/bad', to do a 'git cherry-pick 10fd883ce3847'. This means you don't actually move it after the commit that causes the problem, but you do add it on top for your compilation. But that means that after testing the build you can no longer do a simple 'git bisect good/bad' as that would tag the cherry-picked commit instead of the one you tested. So instead you have to do 'git bisect good/bad HEAD^' (assuming you did a single ...

I don't have the -rt tree at hand; can you copy a few lines of code around line 648 of fs/namespace.c, please? --

Hi Ingo, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux-2.6 perf Regards, - Arnaldo Anton Blanchard (1): perf: Fix performance issue with perf report Arnaldo Carvalho de Melo (1): perf inject: Add missing bits Tom Zanussi (1): perf: record TRACE_INFO only if using tracepoints and SAMPLE_RAW tools/perf/Documentation/perf-buildid-cache.txt | 4 +- tools/perf/Documentation/perf-inject.txt | 35 +++++++++++++++++++++++ ...

From: Anton Blanchard <anton@samba.org> On a large machine we spend a lot of time in perf_header__find_attr when running perf report. If we are parsing a file without PERF_SAMPLE_ID then for each sample we call perf_header__find_attr and loop through all counter IDs, never finding a match. As the machine gets larger there are more per cpu counters and we spend an awful lot of time in there. The patch below initialises each sample id to -1ULL and checks for this in perf_header__find_attr. ...

Using get_tracepoints_path() is a bit costly just to check if we use Now get_tracepoints_path() may be called three times. You are leaking some --

From: Arnaldo Carvalho de Melo <acme@redhat.com> New commands need to have Documentation and be added to command-list.txt so that they can appear when 'perf' is called withouth any subcommand: [root@doppio linux-2.6-tip]# perf usage: perf [--version] [--help] COMMAND [ARGS] The most commonly used perf commands are: annotate Read perf.data (created by perf record) and display annotated code archive Create archive with object files with build-ids found in perf.data ...

This won't work right if a second IRQ arrives while the first is being processed. Suppose the kernel driver for the second IRQ doesn't activate a suspend blocker, and suppose all the userspace handlers for the first IRQ end (and the opportunistic policy is re-enabled) before the userspace handler for the second IRQ can start. Then the system will go back to sleep before userspace can handle the second IRQ. Alan Stern --

In an embedded system I'd expect that these other system devices would fall naturally out through the management of the CPUs and devices - for example, the drivers for the individual devices could use the regulator API to manage their supplies and runtime PM is being used to manage CPU core stuff - or could at least readily be handled in a similar fashion. This isn't to say that we're there yet from an implementation point of view, of course. --

Somewhat true - machines with C1E support will put the RAM into self refresh when the cpu is idle, but you're right that there are various components that we simply don't have control over in the desktop world at present. -- Matthew Garrett | mjg59@srcf.ucam.org --

Currently migration_thread is serving three purposes - migration pusher, context to execute active_load_balance() and forced context switcher for expedited RCU synchronize_sched. All three roles are hardcoded into migration_thread() and determining which job is scheduled is slightly messy. This patch kills migration_thread and replaces all three uses with cpu_stop. The three different roles of migration_thread() are splitted into three separate cpu_stop callbacks - migration_cpu_stop(), ...

The paranoid check which verifies that the cpu_stop callback is actually called on all online cpus is completely superflous. It's guaranteed by cpu_stop facility and if it didn't work as advertised other things would go horribly wrong and trying to recover using synchronize_sched() wouldn't be very meaningful. Kill the paranoid check. Removal of this feature is done as a separate step so that it can serve as a bisection point if something actually goes wrong. Signed-off-by: Tejun Heo ...

Implement a simplistic per-cpu maximum priority cpu monopolization mechanism. A non-sleeping callback can be scheduled to run on one or multiple cpus with maximum priority monopolozing those cpus. This is primarily to replace and unify RT workqueue usage in stop_machine and scheduler migration_thread which currently is serving multiple purposes. Four functions are provided - stop_one_cpu(), stop_one_cpu_nowait(), stop_cpus() and try_stop_cpus(). This is to allow clean sharing of resources ...

The current code will not remove the sysfs files for fan numbers three and up. Also, upon exit, fans one and two are removed regardless of their existence. This patch cleans up the sysfs error handling for the fans. Signed-off-by: Henrik Rydberg <rydberg@euromail.se> --- drivers/hwmon/applesmc.c | 61 +++++++++++++++++++--------------------------- 1 files changed, 25 insertions(+), 36 deletions(-) diff --git a/drivers/hwmon/applesmc.c b/drivers/hwmon/applesmc.c index 36a0d62..57c0331 ...

From: Alex Murray <murray.alex@gmail.com> The Apple SMC uses a systematic labeling scheme for the hardware temperature sensors. This scheme is currently hidden from userland. Since the sensor set, and consequently the numbering, differs between models, an extensive database of configurations is required for an application such as fan control. This patch adds the SMC labels to the hwmon sysfs interface, allowing applications to use the sensors more intelligibly. [rydberg@euromail.se: fixed ...

key_gc_keyring() needs to either hold the RCU read lock or hold the keyring semaphore if it's going to scan the keyring's list. Given that it only needs to read the key list, and it's doing so under a spinlock, the RCU read lock is the thing to use. Furthermore, the RCU check added in e7b0a61b7929632d36cf052d9e2820ef0a9c1bfe is incorrect as holding the spinlock on key_serial_lock is not grounds for assuming a keyring's pointer list can be read safely. Instead, a simple rcu_dereference() ...

Hi, sorry for sending from my personal account. The following series are all from me: From: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp> The 3rd version of "moving dirty bitmaps to user space". From this version, we add x86 and ppc and asm-generic people to CC lists. [To KVM people] Sorry for being late to reply your comments. Avi, - I've wrote an answer to your question in patch 5/12: drivers/vhost/vhost.c . - I've considered to change the set_bit_user_non_atomic to ...

We will change the vmalloc() and vfree() to do_mmap() and do_munmap() later. This patch makes it easy and cleanup the code. Signed-off-by: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp> Signed-off-by: Fernando Luis Vazquez Cao <fernando@oss.ntt.co.jp> --- virt/kvm/kvm_main.c | 27 ++++++++++++++++++++------- 1 files changed, 20 insertions(+), 7 deletions(-) diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index 7ab6312..3e3acad 100644 --- a/virt/kvm/kvm_main.c +++ ...

During the work of KVM's dirty page logging optimization, we encountered the need of manipulating bitmaps in user space efficiantly. To achive this, we introduce a uaccess function for setting a bit in user space following Avi's suggestion. KVM is now using dirty bitmaps for live-migration and VGA. Although we need to update them from kernel side, copying them every time for updating the dirty log is a big bottleneck. Especially, we tested that zero-copy bitmap manipulation improves ...

During the work of KVM's dirty page logging optimization, we encountered the need of manipulating bitmaps in user space efficiantly. To achive this, we introduce a uaccess function for setting a bit in user space following Avi's suggestion. KVM is now using dirty bitmaps for live-migration and VGA. Although we need to update them from kernel side, copying them every time for updating the dirty log is a big bottleneck. Especially, we tested that zero-copy bitmap manipulation improves ...

Now that dirty bitmaps are accessible from user space, we export the addresses of these to achieve zero-copy dirty log check: KVM_GET_USER_DIRTY_LOG_ADDR We also need an API for triggering dirty bitmap switch to take the full advantage of double buffered bitmaps. KVM_SWITCH_DIRTY_LOG See the documentation in this patch for precise explanations. About performance improvement: the most important feature of switch API is the lightness. In our test, this appeared in the form of ...

Does this work correctly if your user space is 32 bits (i.e. unsigned long is different size in user space and kernel) in both big- and little-endian systems? I'm not sure about all the details, but I think you cannot in general share bitmaps between user space and kernel because of this. Arnd --

Hi, I'm copying 6GB of data onto an NBD device using a simple tool which differs from dd/cat in that it measures how long it takes to write each block and does a sync after each block. Now during that run I get: [45480.665074] INFO: task measurecopy:13780 blocked for more than 120 seconds. [45480.665086] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. [45480.665090] measurecopy D 0000000000000000 0 13780 30341 0x00000000 [45480.665102] ffff8801bf06d4c0 ...

The x86_64 call_rwsem_wait() treats the active state counter part of the R/W semaphore state as being 16-bit when it's actually 32-bit (it's half of the 64-bit state). It should do "decl %edx" not "decw %dx". Signed-off-by: David Howells <dhowells@redhat.com> --- arch/x86/lib/rwsem_64.S | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/x86/lib/rwsem_64.S b/arch/x86/lib/rwsem_64.S index 15acecf..41fcf00 100644 --- a/arch/x86/lib/rwsem_64.S +++ ...

Hello, all. This patchset does the following two things. * 0001-0007: Unify the three tracers (tracepoints, perf_events and preempt/sched notifiers) in scheduler. * 0008-0012: Move perf hooks in sched on top of tracepoints if TPs are enabled. It probably should be two separate patchsets with the first part on top of sched/core which then gets pulled into perf branch, on top of which the second part is applied but in the spirit of RFC I'm posting it as a single chunk on top of ...

@cpu parameter is superflous. Drop it. This will help unifying notifiers in sched. Signed-off-by: Tejun Heo <tj@kernel.org> Cc: Avi Kivity <avi@redhat.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Mike Galbraith <efault@gmx.de> Cc: Ingo Molnar <mingo@elte.hu> --- include/linux/preempt.h | 3 +-- kernel/sched.c | 2 +- virt/kvm/kvm_main.c | 4 ++-- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/include/linux/preempt.h ...

Instead of calling perf_sw_event() directly from set_task_cpu(), implement perf_event_task_migrate() which takes the same arguments as trace_sched_migrate_task() and invokes perf_sw_event() is the task is really migrating (cur_cpu != new_cpu). This will help unifying notifiers in sched. Signed-off-by: Tejun Heo <tj@kernel.org> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Paul Mackerras <paulus@samba.org> Cc: Ingo Molnar <mingo@elte.hu> Cc: Arnaldo Carvalho de Melo <acme@redhat.com> --- ...

Acked-by: Steven Rostedt <rostedt@goodmis.org> -- Steve --

Add @rq to perf_event_task_sched_out() so that its argument matches those of trace_sched_switch(). This will help unifying notifiers in sched. Signed-off-by: Tejun Heo <tj@kernel.org> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Paul Mackerras <paulus@samba.org> Cc: Ingo Molnar <mingo@elte.hu> Cc: Arnaldo Carvalho de Melo <acme@redhat.com> --- include/linux/perf_event.h | 5 +++-- kernel/perf_event.c | 4 ++-- kernel/sched.c | 2 +- 3 files changed, 6 ...

I'm building the below, so far so good... ;-) --- include/trace/events/sched.h | 32 ++++++++++---------------------- kernel/sched.c | 8 ++++---- kernel/trace/trace_sched_wakeup.c | 5 ++--- 3 files changed, 16 insertions(+), 29 deletions(-) diff --git a/include/trace/events/sched.h b/include/trace/events/sched.h index cfceb0b..4f733ec 100644 --- a/include/trace/events/sched.h +++ b/include/trace/events/sched.h @@ -51,15 +51,12 @@ ...

Rename preempt_notifiers to sched_notifiers and move it to sched.h. Also, refactor implementation in sched.c such that adding new callbacks is easier. This patch does not introduce any functional change and in fact generates the same binary at least with my configuration (x86_64 SMP, kvm and some debug options). Signed-off-by: Tejun Heo <tj@kernel.org> Cc: Avi Kivity <avi@redhat.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Mike Galbraith <efault@gmx.de> Cc: Ingo Molnar ...

Factor out perf_event_switch_clones() from perf_event_task_sched_out(). This is to ease future changes and doesn't cause any functional difference. Signed-off-by: Tejun Heo <tj@kernel.org> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Paul Mackerras <paulus@samba.org> Cc: Ingo Molnar <mingo@elte.hu> Cc: Arnaldo Carvalho de Melo <acme@redhat.com> --- kernel/perf_event.c | 62 +++++++++++++++++++++++++++++--------------------- 1 files changed, 36 insertions(+), 26 deletions(-) diff ...

Define and add sched_switch_in and sched_tick tracepoints. Both are colocated with perf event functions. These will be used to make perf use tracepoints. Signed-off-by: Tejun Heo <tj@kernel.org> --- include/trace/events/sched.h | 14 ++++++++++++++ kernel/sched.c | 4 ++-- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/include/trace/events/sched.h b/include/trace/events/sched.h index cfceb0b..2bed8de 100644 --- a/include/trace/events/sched.h +++ ...

sched currently hosts three different event notification mechanisms - tracepoints, perf_event functions and sched_notifiers. The previous patches modified and moved them around so that they are colocated where applicable and share most of the arguments. This patch introduces and uses SCHED_EVENT() and SCHED_EVENT_RQ() to coalesce calls to different mechanisms. Signed-off-by: Tejun Heo <tj@kernel.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Mike Galbraith <efault@gmx.de> Cc: Ingo ...

f300bab "nfsd41: sunrpc: add new xprt class for nfsv4.1 backchannel" introduced an error case branch that lacks an actual `return' keyword before the return value. Add it. Signed-off-by: Johannes Weiner <jw@emlix.com> Cc: Alexandros Batsakis <batsakis@netapp.com> --- net/sunrpc/xprtsock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/net/sunrpc/xprtsock.c +++ b/net/sunrpc/xprtsock.c @@ -2444,7 +2444,7 @@ static struct rpc_xprt *xs_setup_bc_tcp( struct svc_sock ...

For security people, removing if (!args->bc_xprt) ERR_PTR(-EINVAL); is worse and changing to BUG_ON(!args->bc_xprt); is better. --

Wrong. Removing NULL check is _right_ because calling this function without setting up a back channel first is a major BUG. Returning an error value to the user is pointless, since the user has no control over this. It is entirely under control of the sunrpc developers... Trond --

Acked-by: Eric B Munson <ebmunson@us.ibm.com>

Commit-ID: 02bf60aad7d5912dfcdbe0154f1bd67ea7a8301e Gitweb: http://git.kernel.org/tip/02bf60aad7d5912dfcdbe0154f1bd67ea7a8301e Author: Anton Blanchard <anton@samba.org> AuthorDate: Tue, 4 May 2010 21:19:15 +1000 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitDate: Tue, 4 May 2010 10:54:09 -0300 perf: Fix performance issue with perf report On a large machine we spend a lot of time in perf_header__find_attr when running perf report. If we are parsing a file without ...

Nick Piggin reported that the allocator may see an empty nodemask when changing cpuset's mems[1]. It happens only on the kernel that do not do atomic nodemask_t stores. (MAX_NUMNODES > BITS_PER_LONG) But I found that there is also a problem on the kernel that can do atomic nodemask_t stores. The problem is that the allocator can't find a node to alloc page when changing cpuset's mems though there is a lot of free memory. The reason is like this: (mpol: mempolicy) task1 task1's ...

The check is already done in ibs_exit(). Signed-off-by: Robert Richter <robert.richter@amd.com> --- arch/x86/oprofile/op_model_amd.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/arch/x86/oprofile/op_model_amd.c b/arch/x86/oprofile/op_model_amd.c index e159254..384c524 100644 --- a/arch/x86/oprofile/op_model_amd.c +++ b/arch/x86/oprofile/op_model_amd.c @@ -490,8 +490,7 @@ static int init_ibs_nmi(void) /* uninitialize the APIC for the IBS interrupts if needed ...

In case a counter is already reserved by the watchdog or perf_event subsystem, oprofile ignored this counters silently. This case is handled now and oprofile_setup() now reports an error. Signed-off-by: Robert Richter <robert.richter@amd.com> --- arch/x86/oprofile/nmi_int.c | 5 ++++- arch/x86/oprofile/op_model_amd.c | 24 +++++++++++++----------- arch/x86/oprofile/op_model_p4.c | 14 +++++++++++++- arch/x86/oprofile/op_model_ppro.c | 24 +++++++++++++----------- ...

This patch improves the error handler in nmi_setup(). Most parts of the code are moved to allocate_msrs(). In case of an error allocate_msrs() also frees already allocated memory. nmi_setup() becomes easier and better extendable. Signed-off-by: Robert Richter <robert.richter@amd.com> --- arch/x86/oprofile/nmi_int.c | 33 +++++++++++++++++++-------------- 1 files changed, 19 insertions(+), 14 deletions(-) diff --git a/arch/x86/oprofile/nmi_int.c b/arch/x86/oprofile/nmi_int.c index ...

Moving some code in preparation of the next patch. Signed-off-by: Robert Richter <robert.richter@amd.com> --- arch/x86/oprofile/op_model_amd.c | 24 +++++++++++----------- arch/x86/oprofile/op_model_p4.c | 38 +++++++++++++++++------------------- arch/x86/oprofile/op_model_ppro.c | 33 +++++++++++++++---------------- 3 files changed, 46 insertions(+), 49 deletions(-) diff --git a/arch/x86/oprofile/op_model_amd.c b/arch/x86/oprofile/op_model_amd.c index 2e2bc90..7e5886d 100644 --- ...

Yeah I'll cat them together and resend them tomorrow 8) --

On Tue, 4 May 2010 08:51:12 -0700 Expected - its a staging driver so I thought a patch that broke the API of another staging driver was fine (the second patch will fix it up) --

I get the following build errors with this patch: CC [M] drivers/staging/memrar/memrar_handler.o drivers/staging/memrar/memrar_handler.c: In function ‘memrar_init’: drivers/staging/memrar/memrar_handler.c:910: warning: passing argument 1 of ‘register_rar’ makes integer from pointer without a cast drivers/staging/memrar/../rar_register/rar_register.h:37: note: expected ‘int’ but argument is of type ‘int (*)(void *)’ drivers/staging/memrar/memrar_handler.c:910: error: too few arguments to ...

memrar: rework to match the RAR API changes From: Alan Cox <alan@linux.intel.com> Fix various unload related bugs Use the per RAR allocator/deallocator Add kerneldoc Signed-off-by: Alan Cox <alan@linux.intel.com> --- drivers/staging/memrar/memrar_handler.c | 469 +++++++++++++++++-------------- 1 files changed, 264 insertions(+), 205 deletions(-) diff --git a/drivers/staging/memrar/memrar_handler.c b/drivers/staging/memrar/memrar_handler.c index 4bbf66f..281d8d7 100644 --- ...

Yes please. As a bugfix, that would even be a candidate for 2.6.34. I have another patch (for asc7621) pending already. -- Jean Delvare --

Hi Henrik, Other than that, the patch looks good. -- Jean Delvare --

Hi Linus, Please pull i2c subsystem fixes for Linux 2.6.34 from: git://git.kernel.org/pub/scm/linux/kernel/git/jdelvare/staging.git i2c-for-linus Documentation/i2c/writing-clients | 5 +++ drivers/i2c/i2c-core.c | 63 +++++++++++++++++++++++------------- include/linux/i2c.h | 2 + 3 files changed, 47 insertions(+), 23 deletions(-) --------------- Jean Delvare (2): i2c: Fix probing of FSC hardware monitoring chips i2c-core: Use per-adapter ...

Hi! -rc5 compiled ok with similar config. Now I get: CHK include/linux/version.h CHK include/generated/utsrelease.h make[1]: `include/generated/mach-types.h' is up to date. CALL scripts/checksyscalls.sh CHK include/generated/compile.h CC drivers/pcmcia/pcmcia_ioctl.o drivers/pcmcia/pcmcia_ioctl.c: In function 'ds_open': drivers/pcmcia/pcmcia_ioctl.c:714: error: 'struct <anonymous>' has no member named 'present' drivers/pcmcia/pcmcia_ioctl.c: In function ...

> Does the attached patch fix it (compile-tested only)? Yes, it looks good -- many thanks! Applied your patch to pcmcia-urgent. Best, Dominik --

Hi all, Changes since 20100503: Dropped trees: tmio-mmc (long unresolved conflicts and unable to fetch) hwlat (at the maintainer's request) The mem tree gained a conflict against the arm tree. The v4l-dvb tree lost its build failure and conflicts. The net tree lost its build failure. The crypto tree lost its conflict but gained another against the arm tree. The pcmcia tree gained a conflict against the wireless tree. The usb tree lost its build ...

drivers/staging/dt3155v4l/dt3155v4l.c:73: error: implicit declaration of function 'udelay' drivers/staging/dt3155v4l/dt3155v4l.c:616: warning: assignment from incompatible pointer type drivers/staging/dt3155v4l/dt3155v4l.c:1270: error: implicit declaration of function 'msleep' --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** --

That is on x86_64. The config is attached. -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***

But the nfsd code has and now doesn't call lookup from the filldir callback anymore. --

Ah..I just noticed the changes in the nfsd code. But in 2.6.27.10, can it be fixed by removing the lock_super in the vfat_lookup.? Because I saw some discussions long back of regressions due to replacing lock_kernel by lock_super in FAT code. Or should the sb mutex be unlocked before calling the callback filldir in the __fat_readdir? Thanks, Fredrick --

Yes. Current way is ultra safer side to convert BKL. Another side was just to remove BKL. However, at least for now, we are using current way. So, if current way had a problem, just remove it instead of trying to fix (then, review). Thanks. -- OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> --

Hi, while booting an initrd image built off of BusyBox on a thousand nodes, we hit a race on a couple of nodes. They hang during the boot process with the stack traces listed below. The really simple init script in the initrd does a 'udevd --daemon' and then modprobe of a device. The device needs to assign an mtrr to the pci resource, and instead the whole node hangs. Putting a 'sleep 1' in between these two calls prevents any hangs. mtrr_add_page and the buddy allocator code don't appear to ...

NAND_MAX_OOBSIZE needs to be increased to support newer parts with 218 or 224 byte spare areas. Tested with Samsung K9GAG08U0D. Signed-off-by: Kevin Cernekee <cernekee@gmail.com> --- include/linux/mtd/nand.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h index 8bdacb8..50f3aa0 100644 --- a/include/linux/mtd/nand.h +++ b/include/linux/mtd/nand.h @@ -53,7 +53,7 @@ extern int nand_unlock(struct mtd_info *mtd, ...

On Mon, May 3, 2010 at 10:52 PM, Trenton D. Adams I have a similar experience (posted to this list a few months ago) with mounting a flash device (mobile phone) in USB mass storage mode. When I/O scheduler for that device is CFQ, write performance is really terrible. When I change the scheduler to deadline, performance is several times better. In 2.6.32 pdflush was replaced and CFQ performance saw a 4x increase but still far too slow. CFQ in <=2.6.31: 450KB/sec CFQ in >=2.6.32: ...

Very interesting. How much memory do you have? (The core tuning parameter is dirty_ratio, which defaults to 20): dirty_bytes: Contains the amount of dirty memory at which a process generating disk writes will itself start writeback. If dirty_bytes is written, dirty_ratio becomes a function of its value (dirty_bytes / the amount of dirtyable system memory). dirty_ratio: Contains, as a percentage of total system memory, the number of pages at which a process which is generating disk writes ...

Ahh, this one didn't get to LKML either, oops. I don't use gmail often. :P dirty_ratio goes to 0 whenever I set dirty_bytes to anything, and dirty_bytes goes to 0 when I set dirty_ratio. I even tried setting tdanotebook linux # zcat /proc/config.gz | grep DEBUG_FS CONFIG_DEBUG_FS=y tdanotebook linux # mount | grep debug none on /sys/kernel/debug type debugfs (rw) tdanotebook linux # blktrace -d /dev/mmcblk0p1 BLKTRACESETUP: Inappropriate ioctl for device Usually hundreds of ...

Pulled, thanks! Ingo --

Fix a silly copy-paste mistake that was making debug_atomic_dec use this_cpu_inc instead of this_cpu_dec. Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com> Cc: Peter Zijlstra <peterz@infradead.org> --- kernel/lockdep_internals.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/kernel/lockdep_internals.h b/kernel/lockdep_internals.h index 7de27a8..8d929c7 100644 --- a/kernel/lockdep_internals.h +++ b/kernel/lockdep_internals.h @@ -149,7 +149,7 @@ ...

[Version 2] This is an RFC patch set that also affects kprobes and perf. At the Linux Collaboration Summit, I talked with Mathieu and others about lowering the footprint of trace events. I spent all of last week trying to get the size as small as I could. Currently, each TRACE_EVENT() macro adds 1 - 5K per tracepoint. I got various results by adding a TRACE_EVENT() with the compiler, depending on config options that did not seem related. The new tracepoint I added would add between 1 and ...

From: Steven Rostedt <srostedt@redhat.com> This patch creates a ftrace_event_class struct that event structs point to. This class struct will be made to hold information to modify the events. Currently the class struct only holds the events system name. This patch slightly increases the size of the text as well as decreases the data size. The overall change is still a slight increase, but this change lays the ground work of other changes to make the footprint of tracepoints smaller. With ...

From: Steven Rostedt <srostedt@redhat.com> Currently, every event has its own trace_event structure. This is fine since the structure is needed anyway. But the print function structure (trace_event_functions) is now separate. Since the output of the trace event is done by the class (with the exception of events defined by DEFINE_EVENT_PRINT), it makes sense to have the class define the print functions that all events in the class can use. This makes a bigger deal with the syscall events since ...

From: Steven Rostedt <srostedt@redhat.com> This patch removes the register functions of TRACE_EVENT() to enable and disable tracepoints. The registering of a event is now down directly in the trace_events.c file. The tracepoint_probe_register() is now called directly. The prototypes are no longer type checked, but this should not be an issue since the tracepoints are created automatically by the macros. If a prototype is incorrect in the TRACE_EVENT() macro, then other macros will catch ...

From: Steven Rostedt <srostedt@redhat.com> Multiple events may use the same method to print their data. Instead of having all events have a pointer to their print funtions, the trace_event structure now points to a trace_event_functions structure that will hold the way to print ouf the event. The event itself is now passed to the print function to let the print function know what kind of event it should print. This opens the door to consolidating the way several events print their ...

Pulled, thanks a lot Paul!! Ingo --

1. Remove the AER section of Areca driver in kconfig file of scsi folder Signed-off-by: Nick Cheng< nick.cheng@areca.com.tw > ---

1. To support 4M/1024 scatter-gather list entry, reorganize struct ARCMSR_CDB and struct CommandControlBlock 2. To modify arcmsr_probe 3. In order to help fix F/W issue, add the driver mode for type B card 4. To improve AP's behavior while F/W resets 5. To unify struct MessageUnit_B's members' naming in all OS drivers' 6. To improve error handlers, arcmsr_bus_reset(), arcmsr_abort() 7. To fix the arcmsr_queue_command() in bus reset stage, just let the commands pass down to FW, don't ...

Hi all, Thanks for the confirmation. -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/

It looks good to me too. Thanks! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt --

Hi Stephen, Thanks for fixing this. Looks fine to me. Will --

Ok .. I'll merge the changes in Russell tree into my tree, that should fix it I think. Daniel --

Hi Daniel, OK, thanks. For simple things like this, I have no problem carrying fixes until they are repaired in the normal course of events. "git rerere" does all the work for me. -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/

Following "genirq: always build resend_irqs" and previous changes, this commit updates the genirq DocBook. Signed-off-by: Guillaume Knispel <gknispel@proformatique.com> CC: linux-kernel@vger.kernel.org CC: Linuxppc-dev@lists.ozlabs.org CC: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> CC: Benjamin Herrenschmidt <benh@kernel.crashing.org> CC: Haavard Skinnemoen <hskinnemoen@atmel.com> CC: Ingo Molnar <mingo@elte.hu> CC: Lars-Peter Clausen <lars@metafoo.de> CC: Linus Torvalds ...

The following can happen: CPU 1 CPU 2 disable_irq(): handle_edge_irq(): LOCK desc->lock (irqsave) desc->status |= IRQ_DISABLED; desc->chip->disable(irq);/*1*/ UNLOCK desc->lock (irqrestore) LOCK desc->lock desc->status |= (IRQ_PENDING | IRQ_MASKED); mask_ack_irq(desc, irq); ...

Can copyup be interrupted? E.g. if I chmod an 80GB file, will the Does it apply the same permission checks that a program doing copy+rename would have to pass? I guess that is just write access to the directory. Does it effectively "rename" all hard links referring to the file, to point to the new version, or does it only affect the path that was used by the writer/modifier, leaving the other links continue to refer Why is O_DIRECT relevant? O_DIRECT doesn't imply writing, ...

Look in call_rwsem_wake(), which is implemented in assembly in two places in the x86 arch: arch/x86/lib/rwsem_64.S arch/x86/lib/semaphore_32.S Note that the x86_64 version contains a bug, a patch for which is attached. David --- From: David Howells <dhowells@redhat.com> Subject: [PATCH] Fix the x86_64 implementation of call_rwsem_wait() The x86_64 call_rwsem_wait() treats the active state counter part of the R/W semaphore state as being 16-bit when it's actually 32-bit (it's half ...

The patch now looks correct to me. Acked-by: Jan Kara <jack@suse.cz> -- Jan Kara <jack@suse.cz> SUSE Labs, CR --

But for that you use perf record -a, right? So you record all cpus allways -- otherwise there is no telling what was happening to make it Right, it would be very nice if we can avoid growing the default sample size. Also, your changelog needs work, please explain the full usecase that goes with this feature. Explain the thing you're wanting to measure, explain the implementation and maybe give a short example. --

Hmmm ... seems to me that in this case, the problem might be that there is a device hanging in the air, for which the parsing of report descriptor failed (interface .0002), but it's still somehow there on the bus. It's a bit strange that we are not seeing dev_err(&intf->dev, "can't add hid device: %d\n", ret); message from usbhid_probe(), are we? That would mean, that we are returning ENODEV from the usb_driver->probe routine properly. Bruno, could you, for testing purposes, check, ...

Well, it's said to return 0: [ 286.872739] generic-usb 0003:058F:9462.0003: input: USB HID v1.10 Keyboard [Multimedia USB Keyboard Multimedia USB Keyboard] on usb-0000:00:13.0-2.1/input0 [ 286.890136] HID: device_add() returned 0 [ 286.919698] generic-usb: probe of 0003:058F:9462.0004 failed with error -22 [ 286.929363] HID: device_add() returned 0 or with debug=1 for HID: [ 559.982958] /usr/src/linux-2.6-git/drivers/hid/usbhid/hid-core.c: HID probe called for ifnum 1 [ 560.011698] ...

Agreed, don't worry about too-long lines in print statements. thanks, greg k-h --

Signed-off-by: Wim Van Sebroeck <wim@iguana.be> I will add this to the linux-2.6-watchdog-next tree. Kind regards, Wim. --

Won't this mean that any direct IO read that spans EOF (i.e. get a short read) now attempt a buffered IO (that will fail) before returning? Cheers, Dave. -- Dave Chinner david@fromorbit.com --

The wording could have been better. The problem is that once a migration PTE is established, it is expected that rmap can find it. In the specific case of exec, this can fail because of how the temporary stack is moved. As migration colliding with exec is rare, the approach taken by the patch was to not create migration PTEs that rmap could not find. On the plus side, exec (the common case) is unaffected. On the negative side, it's avoiding the exec vs migration problem instead of fixing ...

I already have three IPMI patches queued: http://userweb.kernel.org/~akpm/mmotm/broken-out/ipmi-raise-precedence-of-pnp-based-di... http://userweb.kernel.org/~akpm/mmotm/broken-out/ipmi-convert-tracking-of-the-acpi-dev... http://userweb.kernel.org/~akpm/mmotm/broken-out/ipmi-update-driver-to-use-dev_printk-... The first two were repairable. The third is now thoroughly trashed and needs redoing. I have no ...

Yes please. -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html --

Acked-by: Arnd Bergmann <arnd@arndb.de> --

On Sun, 2 May 2010 22:47:33 +0200 I think all we need is probably this tty: Fix unbalanced BKL handling in error path Arnd noted: After the "retry_open:" label, we first get the tty_mutex and then the BKL. However a the end of tty_open, we jump back to retry_open with the BKL still held. If we run into this case, the tty_open function will be left with the BKL still held. Signed-off-by: Alan Cox <alan@linux.intel.com> diff --git a/drivers/char/tty_io.c ...

Yes, this has the drawback to need 'size' in kvfree(), but it should not be a problem for users of this code. alloc_pages_exact() also fragments high order page, but I guess it's not worse than kmalloc() in this context. --

Ok, so you're happy with the patch as is? -- error compiling committee.c: too many arguments to function --

Acked-by: Suresh Siddha <suresh.b.siddha@intel.com> --

Commit-ID: 956097912c40a03bf22603a3be73503fd9ea9e44 Gitweb: http://git.kernel.org/tip/956097912c40a03bf22603a3be73503fd9ea9e44 Author: Borislav Petkov <bp@alien8.de> AuthorDate: Sun, 2 May 2010 08:03:54 +0200 Committer: Steven Rostedt <rostedt@goodmis.org> CommitDate: Tue, 4 May 2010 12:23:47 -0400 ring-buffer: Wrap open-coded WARN_ONCE Wrap open-coded WARN_ONCE functionality into the equivalent macro. Signed-off-by: Borislav Petkov <bp@alien8.de> LKML-Reference: ...

We could certainly move bits of this initialization earlier. Also we could add the notion of 'persistent' events that dont have a user-space process attached to them - and which would buffer to a certain degree. Such persistent events could be initialized during bootup and the daemon could pick up the events later on. In-kernel actions/policy could work off the callback mechanism. (See for example how the new NMI watchdog code in tip:perf/nmi makes use of it - or how the ...

Henrik, I disagree with the patch. I can not guarantee that we will be able to maintain continuous range of ABS_MT_* events and thus current scheme is more flexible. Thanks. -- Dmitry --

Hi Petr, There are other code in the kernel makes similar assumption of accessing pci cfg above 0x100. (but they do not hang in a loop) e.g. in drivers/pci/probe.c * accesses, or the device is behind a reverse Express bridge. So we try * reading the dword at 0x100 which must either be 0 or a valid extended * capability header. */ int pci_cfg_space_size_ext(struct pci_dev *dev) { u32 status; int pos = PCI_CFG_SPACE_SIZE; if (pci_read_config_dword(dev, pos, &status) != ...

Commit-ID: 777d0411cd1e384115985dac5ccd42031e3eee2b Gitweb: http://git.kernel.org/tip/777d0411cd1e384115985dac5ccd42031e3eee2b Author: Frederic Weisbecker <fweisbec@gmail.com> AuthorDate: Mon, 3 May 2010 15:39:45 +0200 Committer: Ingo Molnar <mingo@elte.hu> CommitDate: Tue, 4 May 2010 08:39:36 +0200 hw_breakpoints: Fix percpu build failure Fix this build error: kernel/hw_breakpoint.c:58:1: error: pasting "__pcpu_scope_" and "*" does not give a valid preprocessing token It ...

Alternatively you could pick up Paul's patch on top of Tejun's if you have already pushed the commit ID out and want to avoid a rebase. Thanks, Ingo --

Ah, whoops. "Block cache" - it uses one block device to cache another, it's intended for SSDs. It's summarized decently in the documentation patch, which if I'd thought harder would've been the first email... http://thread.gmane.org/gmane.linux.kernel/979977 Second patch also has relevant commentary: http://thread.gmane.org/gmane.linux.kernel/979978 http://thread.gmane.org/gmane.linux.kernel/979979 Currently all the necessary functionality for read only is close to done, I'm now doing ...

On Mon, May 3, 2010 at 4:37 PM, Kevin Hilman I'm not that familiar with ACPI either, but I think the S-states entered by suspend are much lower power than the C-states entered by No, suspend blockers are mostly used to ensure wakeup events are not ignored, and to ensure tasks triggered by these wakeup events Why? If a device is not in use it should be off regardless of what -- Arve Hjønnevåg --

You know things would be so much easier if the policy was a one-shot styled thing. i.e. when enabled it does what it does, but upon resume the policy must be re-enabled by user mode to get the opportunistic behavior. That way we don't need to grab the suspend blocker from the wake up irq handler all the way up to user mode as the example below calls out. I suppose doing this would put a burden on the user mode code to keep track of if it has no pending blockers registered after a wake up ...

OK, that's a major difference with embedded SoCs where the kernel must directly manage the power state of all devices using runtime PM. So basically, on ACPI systems, runtime PM doesn't get you any power savings for most devices. Kevin --

OK, but my point was that their *usage* is at the level of inidividual Not necessarily. If a device is not in use, what power state it goes into depends on many device/subsystem specific things. For example, recent activity (timeouts), whether it will be busy soon (pending transfers), latency/throughput constraints, dependency on other devices, or any other device/subsystem specific reason. All of these can be handled with runtime PM. None of which are taken into consideration with ...

Well, half the problem I have is that unfortunately it's not a case of doing that period. The prime example I'm familiar with is that for understandable reasons users become irate when you power down the audio CODEC while they're in the middle of a call so if opportunistic PM is in use then the audio subsystem needs some additional help interpreting a suspend request so that it can figure out how to handle it. Similar issues apply to PMICs, though less pressingly for various reasons. Just ...

Making it one shot does not change where kernel code needs to block suspend, but it does force user space to poll trying to suspend while suspend is blocked by a driver. -- Arve Hjønnevåg --

Currently all the names set by android user-space are unique but the pids are not. We can add columns, or extend the name of user space suspend blockers in the ioctl interface, later if needed. -- Arve Hjønnevåg --

I agree, but "working on towards a world where ..." need not mean "be there from day one" IMO. Also, I guess you'll agree that using the same _binary_ kernel with Android and non-Android user spaces doesn't necessarily make sense (regardless of the fact that Android kernels have hardware-specific board files included), so probably you'll still disable opportunistic suspend building the kernel for non-Android systems (at least for the time being). It looks like you're thinking the ...

I'll echo Arve here -- all drivers should seek to be in the lowest power state possible at all times. We've never suggested that suspend_block is a substitute for that. Suspend blockers give us some flexibility on systems where runtime pm will not get us all the way there. If you can meet your power needs without needing suspend blockers, awesome, you don't need them on that platform. The patchset Arve sent out makes this feature an off-by-default kernel configuration option that compiles ...

Well, adding such an api to cpuidle could do this for you. "shallow" is hard to define, but one could do what google did and define a cpu_wake_lock type of API to block entry into any low power halt/mwait type of state. i.e. shallow would be C0, or just halt in idle. If such a thing fits a "hotpath" API extention to pm_qos basically implementing a low overhead disable lowpower behavior without having to walk the pm_qos lists to get an agrigate value. But, if such an api belongs in ...

Sorry I'm late, From: markgross <mark.gross@intel.com> Date: Mon, 3 May 2010 12:46:42 -0700 Subject: [PATCH] PM_QOS to use handle based list implementation and exported function name changes to be more descriptive of what is actually happening. --- Documentation/power/pm_qos_interface.txt | 48 ++++--- drivers/acpi/processor_idle.c | 2 +- drivers/cpuidle/governors/ladder.c | 2 +- drivers/cpuidle/governors/menu.c | 2 +- drivers/net/e1000e/netdev.c ...

That's fine with me. Cheers, Jeff --

Checking per inode is actually incorrect - we do not want to short cut the need to flush the target storage device's write cache just because a specific file has no dirty pages. If a power hit occurs, having sent the pages from to the storage device is not sufficient. I was thinking that it could actually be more general, specifically we could track the status of the write cache on the entire storage device. That way, any command (write, etc) to the target device would set the cache ...

Just wondering is this per filesystem flag? Thought it is nicer to make this per -inode flag, when there is no dirty data in fly for this inode (instead of the whole fs), there is no need to call barrier in ext4_sync_file(). --

The patch's intention is to not migrate pages within the temporary stack. What are you suggesting that is different? -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab --

Ok so this seems the ordering dependency on the anon_vma list that strikes again, I didn't realize the ordering would matter here, but it does as shown above, great catch! The destination vma of the move_page_tables has to be at the tail of the anon_vma list like the child vma have to be at the end to avoid the equivalent race in fork. This has to be a requirement for mremap too. We just want to enforce the same invariants that mremap already enforces, to avoid adding new special cases to the ...

I'll take your changelog for aa.git thanks! And the non trivial stuff was documented in the code too. So now in aa.git I've two branches, master -> old-anon_vma, anon_vma_chain -> new-anon_vma. anon_vma_chain starts with Rik's patch 1/2 and then this patch. old-anon_vma starts with backout-anon-vma and then this patch 2 backported to old anon-vma code. After the removal of all vma->anon_vma->lock usages from THP code, and switching to a slower get_page() spin_unlock(page_table_lock) ...

Give or take the banner comment on user_read() where it states this explicitly: /* * read the key data * - the key's semaphore is read-locked */ long user_read(const struct key *key, char __user *buffer, size_t buflen) and Documentation/keys.txt where it also states this explicitly: (*) long (*read)(const struct key *key, char __user *buffer, size_t buflen); ... This method will be called with the key's semaphore read-locked. This will prevent the key's ...

[One I never answered] On Sat, 01 May 2010 16:01:30 +0200 That is wrong, yes. As it happens, this gets fixed later in the series when things move into via-core.c. I'd like to say that it's because I noticed the problem and dealt with it, but you're smarter than that, alas... Thanks, jon --

The macros ReadMReg and WriteMReg are really just private versions of the kernel's readl and writel functions. Use the kernel's functions instead. And since ioremap returns a (void __iomem *) not a (u8 *), change all the uses of dt3155_lbase to reflect this. While here, make dt3155_lbase static since it is only used in the dt3155_drv.c file. Also, remove the global variable dt3155_bbase since it is not used anywhere in the code. Where is makes sense, create a local 'mmio' variable ...

Yup, sorry, my mistake. staging-next is the name of your repository as well as a branch within your repository and git after git clone doesn't by default show all remote branches. $ git clone --reference=linux-2.6 \ git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging-next-2.6.git $ git branch -r origin/HEAD -> origin/master origin/master origin/staging-next I needed to add a git checkout origin/staging-next --

I may be seeing the correct stuff now in your staging-next tree just not Am I _sure_... No... Do I _think_ so... Yes... ;-) Would you like me to rebase the patch to staging-next to see? But, will this run into a similar problem with the two commits already in Linus' tree? If so I can just hold off again until everything catches up. Regards, Hartley--

OK. I cloned your tree a different way this time. This time I did: $ git clone --reference ../linux-2.6 staging-2.6 Initialized empty Git repository in /home/bigguiness/src/git/z/staging-2.6/.git/ warning: You appear to have cloned an empty repository. $ cd staging-2.6 $ git remote add staging-2.6 git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging-next-2.6.git $ git fetch staging-2.6 remote: Counting objects: 1541325, done. remote: Compressing objects: 100% (249801/249801), ...

user_buf doesn't need preclearing. It's just a waste of time. This occurs three times. David --

Hm, yeah, the first doesn't need it at all, and the latter two should just kmalloc and set user_buf[count] = '\0'. thanks, -serge --

Rebuilding everything from scratch did it. I am seeing a similar failure where xenctx reports: Call Trace: [<ffffffff8107f780>] stop_cpu+0xc6 <-- [<ffffffff8105520e>] worker_thread+0x15d [<ffffffff8107f6ba>] __stop_machine+0x106 [<ffffffff81058afb>] wake_up_bit+0x25 [<ffffffff81038720>] spin_unlock_irqrestore+0x9 [<ffffffff810550b1>] spin_lock_irq+0xb [<ffffffff810586cb>] kthread+0x7a [<ffffffff8100a964>] kernel_thread_helper+0x4 [<ffffffff81009d61>] ...

TBH I'm not entirely sure it's worth it - I'd be somewhat surprised to see users outside of tosa for the more complex functionality. --

I guess this was not reported because most svm machines have npt, and this requires npt=0 to trigger. Nonpae paging disables npt, so you were hit. Interestingly, nsvm makes it more likely to appear, since npt on i386+pae will need the pdptrs. -- error compiling committee.c: too many arguments to function --

No, apart from the poor users. I'll try to set something up using nsvm. -- error compiling committee.c: too many arguments to function --

This is the lockdep warning I get when I start booting a Linux kernel. It is with the nested-npt patchset but the warning occurs without it too (slightly different backtraces then). [60390.953424] ======================================================= [60390.954324] [ INFO: possible circular locking dependency detected ] [60390.954324] 2.6.34-rc5 #7 [60390.954324] ------------------------------------------------------- [60390.954324] qemu-system-x86/2506 is trying to acquire ...

Hmm, actually it happened on 32 bit with npt enabled. I think this can trigger when mmu_alloc_roots is called for an pae guest because it accidentially tries read the root_gfn from the guest before it figures out that it runs with tdp and omits the gfn read from the guest. I need to touch this for nested-npt and will look into a way improving this. Joerg --

There's one bit that needs to be set to stay in the acpi mode, and there's blacklist somewhere...? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html --

Hmm, I see the problem now. Lockdep chose a wrong target to blame. There is a circular locking between writing to cpufreq sysfs files and suspend, the cpu offline notifier of cpufreq, i.e. cpufreq_cpu_callback() also tries to remove an sysfs file while the cpufreq daemon is writing an sysfs file. Dave, any ideas about how to fix this? Thanks. --

Is there an easy way to determine there's just a single sched_domain? Best, Dominik --

Right, this looks like it ought to do as intended. I added the below snipped because I know I'll fail to remember and that 'static' qualifier is fairly easy to miss. Thanks! --- Index: linux-2.6/kernel/lockdep.c =================================================================== --- linux-2.6.orig/kernel/lockdep.c +++ linux-2.6/kernel/lockdep.c @@ -1627,6 +1627,13 @@ check_prev_add(struct task_struct *curr, int ret; struct lock_list this; struct lock_list ...

Hello, Hmmm... maybe I'm mistaken but isn't that guaranteed by busiest->active_balance which is protected by the rq lock? active_load_balance_cpu_stop is scheduled iff busiest->active_balance was changed from zero and only active_load_balance_cpu_stop() can clear it at the end of its execution at which point the active_balance_work is safe to reuse. Thanks. -- tejun --

Hmmm... it's probably worthwhile to note tho. I'll add a comment and send out the updated patches soon. Thanks. -- tejun --

Hello, Updated to use WARN_ONCE() w/ print the function symbol and argument. Thanks. -- tejun --

Hello, Oh, I had code piece which wanted to discern between -ENOENT from non-excution and -ENOENT return from the work function which seems gone now. I'll check things again and drop ->executed if everything looks okay. Thanks. -- tejun --

Ah indeed. A well, drop it then, its not worth making a more complicated test. --

Hi, On Tue, Apr 20, 2010 at 20:07, Russell King - ARM Linux Seems correct to me, Is there any idea when this gets committed? Regards, Marcelo. --

On Tue, May 4, 2010 at 14:45, Russell King - ARM Linux I can test it, but I need help to figure out the test itself. I am porting the kernel 2.6 to nanoengine and my resources in that environment are still rather limited, not to mention I have not finished the PCI port, so I still have no network. On the other hand, the current situation is clearly broken and your solution can hardly be worse than having NR_SECTION_ROOTS == 0. Regards, Marcelo. --

That's very nice Arjan. That way we'll be able to select between performance and power savings, which is what most laptop users want after all ! Thanks, Willy --

Acked-by: Rik van Riel <riel@redhat.com> -- All rights reversed --

Actually I tend to get it from the tables at the beginning of the specification updates. -Andi -- ak@linux.intel.com -- Speaking for myself only. --

Ok, I'm not a big fan of 5, but I guess there's no way around that without adding lots more code. --

I did test my patch, but it didn't generate any warnings or errors on MIPS... Could you please apply this patch and retry: http://lists.infradead.org/pipermail/linux-mtd/2010-May/029904.html <linux/bug.h> should probably be added anyway since there are two other BUG statements in that file. Thanks. --

By ABS_MT_MAX I meant highest MT event currently defined. No need to go all the way to ABS_MAX if there are no MT events defined there. -- Dmitry --

The latest patchset is now also tested on the ARM-RealView PB11MPCore. My best friends over at Ericsson AB helped me out by lending me their board for a short session. See bootlog below... - UART console comes up fine and is interactive - MMCI card mounts and you can list and copy files No DMA in use since the PL081 in this machine does not have a driver yet, but no regressions in sight. This should be similar to Versatile or Integrator. Is this OK now Russell? Yours, Linus ...

I agree. then how about the Marek, even though LSI want it. they don't have enough experience with open source works. you can see the recent their works at their git. but we are trying to modify and make a patch with open source style. Also we setup the public git for open source Thank you, Kyungmin Park --

Steven, If you do not reply, I will do all the suggested changes myself and push the driver upstream. -- Jean Delvare --

Hey Dmitry, On Tue, 2010-05-04 at 10:23 -0700, Dmitry Torokhov wrote: Re-sent to linux-input with you on CC:. Cheers --

Mind resending the original patch? Apparently current situation causes issues and I guess DMI is not the wost way of taking care of it. -- Dmitry --

Yep! Cheers, Rusty. --