Home » Mailing list archives » linux-kernel » 2010 » May » 4

Re: [PATCH v2] fs: use kmalloc() to allocate fdmem if possible

Previous thread: [PATCH] serial: mpc52xx_uart: fix null pointer dereference by Anatolij Gustschin on Tuesday, May 4, 2010 - 3:18 pm. (5 messages)

Next thread: [PATCH 08/13] tty: release tty lock when blocking by Arnd Bergmann on Tuesday, May 4, 2010 - 3:33 pm. (1 message)
[view original message]
From: Andrew Morton
Subject: Re: [PATCH v2] fs: use kmalloc() to allocate fdmem if possible
Date: Tuesday, May 4, 2010 - 3:27 pm

On Mon,  3 May 2010 03:02:00 +0800

Seems a reasonable thing to do.  It might also be reasonable to make


And these should be uninlined - they're too large to be inlined.

My version of gcc seems to just uninline them anyway, but forcing them
to be inlined with __always_inline indeed causes 70-80 bytes more text,
and we figure that larger text generally causes a slower kernel due to
cache eviction effects.


--


[ message continues ]
[view original message]
From: Jiri Slaby
Subject: Re: [PATCH v2] fs: use kmalloc() to allocate fdmem if possible
Date: Wednesday, May 5, 2010 - 12:18 am

Hi,

So didn't we converge to something like this:
http://lkml.org/lkml/2010/5/3/53
instead of this patch?



is discussed there too btw.

thanks,
-- 
js
suse labs
--


[ message continues ]
[view original message]
From: Eric Dumazet
Subject: Re: [PATCH v2] fs: use kmalloc() to allocate fdmem if possible
Date: Wednesday, May 5, 2010 - 12:33 am

Its a start, I guess we also need some NUMA capability as well.

For example, iptables could use such an allocator only if it is NUMA
enabled.



--


[ message continues ]
Previous thread: [PATCH] serial: mpc52xx_uart: fix null pointer dereference by Anatolij Gustschin on Tuesday, May 4, 2010 - 3:18 pm. (5 messages)

Next thread: [PATCH 08/13] tty: release tty lock when blocking by Arnd Bergmann on Tuesday, May 4, 2010 - 3:33 pm. (1 message)