Home » Mailing list archives » linux-kernel » 2010 » May » 31

Re: [PATCH] mac8390: change an error return code and some cleanup, take 4

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: David Miller
Subject: Re: [PATCH] mac8390: change an error return code and some cleanup, take 4
Date: Monday, May 31, 2010 - 4:30 am

From: fthain@telegraphics.com.au
Date: Mon, 31 May 2010 21:07:09 +1000 (EST)


The only thing I care about is at the moment that you don't do
something that ends up dropping the pr_fmt prefix.

The pr_fmt define at the beginning of the driver is for nothing
if we end up adding exceptions that end up eliding it for no
good reason.  And that's what your patch was doing.

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
another cleanup patch gone wrong, Finn Thain, (Thu Apr 15, 7:34 pm)
Re: another cleanup patch gone wrong, David Miller, (Thu Apr 15, 8:01 pm)
Re: another cleanup patch gone wrong, Joe Perches, (Thu Apr 15, 8:11 pm)
Re: another cleanup patch gone wrong, Finn Thain, (Thu Apr 15, 8:21 pm)
[PATCH] mac8390: fix pr_info() calls, was Re: another clea ..., Finn Thain, (Thu Apr 15, 8:45 pm)
Re: [PATCH] mac8390: fix pr_info() calls, was Re: another ..., Joe Perches, (Thu Apr 15, 8:54 pm)
Re: [PATCH] mac8390: fix pr_info() calls, was Re: another ..., Finn Thain, (Thu Apr 15, 8:59 pm)
Re: [PATCH] mac8390: fix pr_info() calls and change return ..., Finn Thain, (Thu Apr 15, 9:21 pm)
Re: [PATCH] mac8390: fix pr_info() calls and change return ..., Joe Perches, (Thu Apr 15, 9:34 pm)
Re: [PATCH] mac8390: fix pr_info() calls and change return ..., David Miller, (Thu Apr 15, 10:53 pm)
Re: [PATCH] mac8390: fix pr_info() calls and change return ..., Finn Thain, (Fri Apr 16, 6:57 am)
[PATCH] mac8390: change an error return code and some cleanup, Finn Thain, (Fri Apr 16, 7:14 am)
Re: [PATCH] mac8390: fix pr_info() calls and change return ..., David Miller, (Fri Apr 16, 1:28 pm)
Re: [PATCH] mac8390: fix pr_info() calls and change return ..., Finn Thain, (Fri Apr 16, 7:28 pm)
[PATCH] mac8390: change an error return code and some clea ..., Finn Thain, (Fri Apr 16, 8:16 pm)
Re: [PATCH] mac8390: change an error return code and some ..., David Miller, (Wed Apr 21, 4:30 pm)
Re: [PATCH] mac8390: change an error return code and some ..., Finn Thain, (Wed Apr 21, 6:13 pm)
[PATCH] mac8390: change an error return code and some clea ..., Finn Thain, (Fri May 28, 10:29 am)
Re: [PATCH] mac8390: change an error return code and some ..., David Miller, (Mon May 31, 12:19 am)
Re: [PATCH] mac8390: change an error return code and some ..., fthain, (Mon May 31, 2:21 am)
Re: [PATCH] mac8390: change an error return code and some ..., Geert Uytterhoeven, (Mon May 31, 2:58 am)
Re: [PATCH] mac8390: change an error return code and some ..., fthain, (Mon May 31, 4:07 am)
Re: [PATCH] mac8390: change an error return code and some ..., David Miller, (Mon May 31, 4:27 am)
Re: [PATCH] mac8390: change an error return code and some ..., David Miller, (Mon May 31, 4:30 am)
Re: [PATCH] mac8390: change an error return code and some ..., Finn Thain, (Mon May 31, 5:55 am)
Re: [PATCH] mac8390: change an error return code and some ..., David Miller, (Mon May 31, 6:02 am)
Re: [PATCH] mac8390: change an error return code and some ..., Joe Perches, (Mon May 31, 8:08 am)
Re: [PATCH] mac8390: change an error return code and some ..., David Miller, (Mon May 31, 8:14 am)
Re: [PATCH] mac8390: change an error return code and some ..., Finn Thain, (Mon May 31, 8:19 am)
[PATCH 1/2] mac8390: propagate error code from request_irq, Finn Thain, (Tue Jun 1, 5:18 am)
[PATCH 2/2] mac8390: raise error logging priority, Finn Thain, (Tue Jun 1, 5:18 am)
Re: [PATCH 1/2] mac8390: propagate error code from request_irq, David Miller, (Wed Jun 2, 5:17 am)
Re: [PATCH 2/2] mac8390: raise error logging priority, David Miller, (Wed Jun 2, 7:06 am)
Re: [PATCH 2/2] mac8390: raise error logging priority, Finn Thain, (Wed Jun 2, 8:36 am)