Re: [PATCH] mac8390: change an error return code and some cleanup, take 4

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: David Miller
Date: Monday, May 31, 2010 - 4:27 am

From: fthain@telegraphics.com.au
Date: Mon, 31 May 2010 19:21:26 +1000 (EST)


I won't do that, because your change elides the pr_fmt prefix Joe
Perches added to the driver for the purposes of making sure such a
prefix would be added to all log messages output by the driver.

The whole idea is that everything the driver puts into the kernel
log has the driver module name at the beginning.  That's what the
pr_fmt define at the top of the driver does.

It's so you can tell which driver the message came from.

You're undoing that, which is a bug.  It's a step backwards, it's
wrong.

And to top it off we've had to explain this stuff to you multiple
times.

So, as long as the patch is incorrect I absolutely will not apply it.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
another cleanup patch gone wrong, Finn Thain, (Thu Apr 15, 7:34 pm)
Re: another cleanup patch gone wrong, David Miller, (Thu Apr 15, 8:01 pm)
Re: another cleanup patch gone wrong, Joe Perches, (Thu Apr 15, 8:11 pm)
Re: another cleanup patch gone wrong, Finn Thain, (Thu Apr 15, 8:21 pm)
Re: [PATCH] mac8390: change an error return code and some ..., Geert Uytterhoeven, (Mon May 31, 2:58 am)
Re: [PATCH] mac8390: change an error return code and some ..., David Miller, (Mon May 31, 4:27 am)
[PATCH 2/2] mac8390: raise error logging priority, Finn Thain, (Tue Jun 1, 5:18 am)
Re: [PATCH 2/2] mac8390: raise error logging priority, David Miller, (Wed Jun 2, 7:06 am)