Re: [PATCH 2/4] add the new generic kfifo API

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Ira W. Snyder
Date: Saturday, May 29, 2010 - 11:30 am

On Wed, May 12, 2010 at 10:49:25AM +0200, stefani@seibold.net wrote:

Hello Stefani,

I'm a bit concerned about the use of scatterlists here. I think that you
should be using sg_next(sgl) to get the next scatterlist entry. Just
incrementing the pointer will not work with chained scatterlists. See
struct sg_table in include/linux/scatterlist.h.

After you make this change, I don't think you'll need to explicity set
the sgl->page_link member anymore.

Jens, can you comment on the use of scatterlists here?

I hope this patch finally makes it in during this merge window. I'm
ready to start porting one of my drivers to use the DMA features. As
GregKH suggested, I'll submit them for mainline after I port to this
API.

Ira

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
really generic, type save and type definable. , stefani, (Wed May 12, 1:49 am)
[PATCH 2/4] add the new generic kfifo API, stefani, (Wed May 12, 1:49 am)
[PATCH 3/4] replace the old non generic API, stefani, (Wed May 12, 1:49 am)
Re: really generic, type save and type definable., Henrik Rydberg, (Fri May 28, 12:43 am)
Re: really generic, type save and type definable., Stefani Seibold, (Fri May 28, 3:32 am)
Re: really generic, type save and type definable., Henrik Rydberg, (Fri May 28, 4:11 am)
Re: [PATCH 2/4] add the new generic kfifo API, Ira W. Snyder, (Sat May 29, 11:30 am)
Re: [PATCH 2/4] add the new generic kfifo API, Stefani Seibold, (Sat May 29, 11:48 am)
Re: [PATCH 2/4] add the new generic kfifo API, Ira W. Snyder, (Sat May 29, 12:09 pm)