login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2010
»
May
»
27
Re: [PATCH] perf: fix use_browser infinite loop bug in annotate
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Arnaldo Carvalho de Melo
Subject:
Re: [PATCH] perf: fix use_browser infinite loop bug in annotate
Date: Thursday, May 27, 2010 - 7:51 am
Em Thu, May 27, 2010 at 02:50:01PM +0200, Stephane Eranian escreveu:
quoted text
> This patch fixes an infinite loop problem with perf annotate when > the TUI is not used. When the perfconfig file is not found use_browser > remains at -1, when found and tui is disabled use_browser = 0. Thus the > correct test for TUI is use_browser > 0. > > Signed-off-by: Stephane Eranian <eranian@google.com>
Thanks, I'm applying this one and doing an audit of other uses, I know of one more case reported by Frédéric that was fixed in a similar way.
quoted text
> diff --git a/tools/perf/builtin-annotate.c b/tools/perf/builtin-annotate.c > index 08278ed..96db524 100644 > --- a/tools/perf/builtin-annotate.c > +++ b/tools/perf/builtin-annotate.c > @@ -343,7 +343,7 @@ find_next: > continue; > } > > - if (use_browser) { > + if (use_browser > 0) { > key = hist_entry__tui_annotate(he); > if (is_exit_key(key)) > break;
--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH] perf: fix use_browser infinite loop bug in annotate
, Stephane Eranian
, (Thu May 27, 5:50 am)
Re: [PATCH] perf: fix use_browser infinite loop bug in ann ...
, Arnaldo Carvalho de Melo
, (Thu May 27, 7:51 am)
Re: [PATCH] perf: fix use_browser infinite loop bug in ann ...
, Arnaldo Carvalho de Melo
, (Thu May 27, 8:45 am)
Re: [PATCH] perf: fix use_browser infinite loop bug in ann ...
, Stephane Eranian
, (Thu May 27, 8:52 am)
Navigation
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Jesse Barnes
Re: [stable] [BUG][PATCH] cpqphp: fix kernel NULL pointer dereference
Greg KH
[003/136] p54usb: add Zcomax XG-705A usbid
Magnus Damm
[PATCH 03/07] ARM: Use shared GIC entry macros on Realview
Oliver Neukum
Re: [Bug #13682] The webcam stopped working when upgrading from 2.6.29 to 2.6.30
Martin Schwidefsky
Re: [PATCH] optimized ktime_get[_ts] for GENERIC_TIME=y
git
:
Junio C Hamano
Re: Some advanced index playing
Jeff King
Re: confusion over the new branch and merge config
Robin Rosenberg
Re: cvs2svn conversion directly to git ready for experimentation
Linus Torvalds
git binary size...
Ævar Arnfjörð Bjarmason