[PATCHv4 02/17] AFFS: do not manipulate s_dirt directly

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Artem Bityutskiy
Date: Tuesday, May 25, 2010 - 6:48 am

From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>

... use new VFS helpers instead.

Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Cc: Roman Zippel <zippel@linux-m68k.org>
---
 fs/affs/bitmap.c |    4 ++--
 fs/affs/super.c  |   14 +++++++++-----
 2 files changed, 11 insertions(+), 7 deletions(-)

diff --git a/fs/affs/bitmap.c b/fs/affs/bitmap.c
index 3e26271..e55ecde 100644
--- a/fs/affs/bitmap.c
+++ b/fs/affs/bitmap.c
@@ -103,7 +103,7 @@ affs_free_block(struct super_block *sb, u32 block)
 	*(__be32 *)bh->b_data = cpu_to_be32(tmp - mask);
 
 	mark_buffer_dirty(bh);
-	sb->s_dirt = 1;
+	mark_sb_dirty(sb);
 	bm->bm_free++;
 
 	mutex_unlock(&sbi->s_bmlock);
@@ -248,7 +248,7 @@ find_bit:
 	*(__be32 *)bh->b_data = cpu_to_be32(tmp + mask);
 
 	mark_buffer_dirty(bh);
-	sb->s_dirt = 1;
+	mark_sb_dirty(sb);
 
 	mutex_unlock(&sbi->s_bmlock);
 
diff --git a/fs/affs/super.c b/fs/affs/super.c
index 16a3e47..ea8d0cd 100644
--- a/fs/affs/super.c
+++ b/fs/affs/super.c
@@ -69,9 +69,13 @@ affs_write_super(struct super_block *sb)
 		//		if (buffer_dirty(sbi->s_bitmap[i].bm_bh)) {
 		//			clean = 0;
 		affs_commit_super(sb, clean);
-		sb->s_dirt = !clean;	/* redo until bitmap synced */
+		/* redo until bitmap synced */
+		if (clean)
+			mark_sb_clean(sb);
+		else
+			mark_sb_dirty(sb);
 	} else
-		sb->s_dirt = 0;
+		mark_sb_clean(sb);
 	unlock_super(sb);
 
 	pr_debug("AFFS: write_super() at %lu, clean=%d\n", get_seconds(), clean);
@@ -82,7 +86,7 @@ affs_sync_fs(struct super_block *sb, int wait)
 {
 	lock_super(sb);
 	affs_commit_super(sb, 2);
-	sb->s_dirt = 0;
+	mark_sb_clean(sb);
 	unlock_super(sb);
 	return 0;
 }
@@ -554,8 +558,8 @@ affs_remount(struct super_block *sb, int *flags, char *data)
 		return 0;
 	}
 	if (*flags & MS_RDONLY) {
-		sb->s_dirt = 1;
-		while (sb->s_dirt)
+		mark_sb_dirty(sb);
+		while (is_sb_dirty(sb))
 			affs_write_super(sb);
 		affs_free_bitmap(sb);
 	} else
-- 
1.6.6.1

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCHv4 00/17] kill unnecessary SB sync wake-ups, Artem Bityutskiy, (Tue May 25, 6:48 am)
[PATCHv4 01/17] VFS: introduce helpers for the s_dirty flag, Artem Bityutskiy, (Tue May 25, 6:48 am)
[PATCHv4 02/17] AFFS: do not manipulate s_dirt directly, Artem Bityutskiy, (Tue May 25, 6:48 am)
[PATCHv4 04/17] BTRFS: do not manipulate s_dirt directly, Artem Bityutskiy, (Tue May 25, 6:48 am)
[PATCHv4 05/17] EXOFS: do not manipulate s_dirt directly, Artem Bityutskiy, (Tue May 25, 6:49 am)
[PATCHv4 06/17] EXT2: do not manipulate s_dirt directly, Artem Bityutskiy, (Tue May 25, 6:49 am)
[PATCHv4 07/17] EXT4: do not manipulate s_dirt directly, Artem Bityutskiy, (Tue May 25, 6:49 am)
[PATCHv4 08/17] FAT: do not manipulate s_dirt directly, Artem Bityutskiy, (Tue May 25, 6:49 am)
[PATCHv4 09/17] HFS: do not manipulate s_dirt directly, Artem Bityutskiy, (Tue May 25, 6:49 am)
[PATCHv4 10/17] HFSPLUS: do not manipulate s_dirt directly, Artem Bityutskiy, (Tue May 25, 6:49 am)
[PATCHv4 11/17] JFFS2: do not manipulate s_dirt directly, Artem Bityutskiy, (Tue May 25, 6:49 am)
[PATCHv4 12/17] reiserfs: do not manipulate s_dirt directly, Artem Bityutskiy, (Tue May 25, 6:49 am)
[PATCHv4 13/17] SYSV: do not manipulate s_dirt directly, Artem Bityutskiy, (Tue May 25, 6:49 am)
[PATCHv4 14/17] UDF: do not manipulate s_dirt directly, Artem Bityutskiy, (Tue May 25, 6:49 am)
[PATCHv4 15/17] UFS: do not manipulate s_dirt directly, Artem Bityutskiy, (Tue May 25, 6:49 am)
[PATCHv4 16/17] VFS: rename s_dirt to s_dirty, Artem Bityutskiy, (Tue May 25, 6:49 am)
[PATCHv4 17/17] writeback: lessen sync_supers wakeup count, Artem Bityutskiy, (Tue May 25, 6:49 am)
Re: [PATCHv4 01/17] VFS: introduce helpers for the s_dirty ..., Artem Bityutskiy, (Sat May 29, 12:59 am)